From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95B05C83F1B for ; Mon, 14 Jul 2025 13:44:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 38FC48D0002; Mon, 14 Jul 2025 09:44:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 367EF8D0001; Mon, 14 Jul 2025 09:44:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2567E8D0002; Mon, 14 Jul 2025 09:44:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 128B98D0001 for ; Mon, 14 Jul 2025 09:44:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CE31A801AD for ; Mon, 14 Jul 2025 13:44:36 +0000 (UTC) X-FDA: 83662990152.18.E5F7024 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf28.hostedemail.com (Postfix) with ESMTP id 719B7C0006 for ; Mon, 14 Jul 2025 13:44:34 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sx0kOClg; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752500674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X+GS2rPtBARL/ESHq8iljkHKPEQ7wONWjHbxi92M2D8=; b=D3qo5coHM9ud9n5luw/lFkMvqlUcIkM5fZH7Zij0x8BjjfD4Fb8mvCJVKExvJtf5ucRFIA sDZlVEOy3SH7GO+NU5ypWlxXo9SJ4zTsro20lDV/X0+Y/g82aCFWr2h8rkvtrz48t4vYd0 /N6qKA618LPFizNTsTC2cZdGfTIwMG8= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752500674; a=rsa-sha256; cv=none; b=fA0zsq7jSBcc8yCsmKD5CGs5Ip5xI1yQdhTn9ttUe3egksbAtEpN78hSE4jB8d2dGbSRRq 7yICvGj6X3sxPR4LiQPIXqhtepeFzqWEwsJcJ2G/pRIBjlimi4aG6cJbjhYwq8xnf1UYGF L3XJgIWQ0FaGH8eXRKDiiMWyVGW6XhM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Sx0kOClg; spf=pass (imf28.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752500673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=X+GS2rPtBARL/ESHq8iljkHKPEQ7wONWjHbxi92M2D8=; b=Sx0kOClguq3BfG2Heo3DI1LQiZbi/N3tB1CxOJlpdKqiYFW9g1GpkEdxA9cfxC6tnPIECv ca1yOZM6y1MdJWLPi1diCvt2PINn4Gt04u/GP1DHgjd38HpEJb+oXSV0K5qrHLddvGhRtw ++Usl48VwP3L7Cs5xZ7J7VDJ8o6AXMs= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-HHvY4VElPRK9puLeJY-3FQ-1; Mon, 14 Jul 2025 09:44:32 -0400 X-MC-Unique: HHvY4VElPRK9puLeJY-3FQ-1 X-Mimecast-MFC-AGG-ID: HHvY4VElPRK9puLeJY-3FQ_1752500671 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-45526e19f43so11073095e9.3 for ; Mon, 14 Jul 2025 06:44:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752500671; x=1753105471; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=X+GS2rPtBARL/ESHq8iljkHKPEQ7wONWjHbxi92M2D8=; b=jWknvE9YBNihUlx8a7Izgi+opiL4Yz1y+EHmUPUzoyhwlfzXbo0oEqMoItD0RSdwre lXQTW/JlmGvYhqni+qAOp7nt/oGMbywGLLPTFoiyX5bMKPa5PiFpG1MlRQQKuxtAJ8Sp ruNEYPE4Wi8Ijc0b9vyFB3xKE4uDhrG+qU5u18P+alZ78jv9K1GdWw31lRu7Z3wz+6V1 zT8LHq7Mvf3OPsxU3Z0f5bvZJAvo/+PjR0QooG2EVkv4iRmsXfYT28wXsKVG9A0kZ8Es C631Nv2+kctYi1ubVFJTFQDgLj9yamraWmFJAG/PV0UDcHPcuEUsCtrYP7DfM2W6UyJv IyAw== X-Forwarded-Encrypted: i=1; AJvYcCXwbVRzeqN50wLMNRhs+qTgmD2zlEeczW9hvrYqCElIFrMfD1w8Zm1sxssQ3cgpBFP0xppgJ1b0ZQ==@kvack.org X-Gm-Message-State: AOJu0Yw32YOzb8j0AMrZBFPtbTnQV7GIR5aOyq0VRkKkD3r+avSOzN8y DUrRP3TUr2H7mwMsXIfYfuhGKMbz6N/M+XDoWxRjPDQzb4tL1Er/o+lriQYd2i9ZSl8h+IIvzyH sM8UhOfApbRo98PmpMJQBzNPo/eZjWUAxkRggLc9wOhsKRURxe71P X-Gm-Gg: ASbGncvJWxycGertCHUVJgQEzE5TltN/8fPEOFUEjtR6fqaO91Hzhyj9vRuvM7ZmCT3 702TlYKKVgFunQqfLcIRd7nAgxOBZ0ZktkfPzUuqlfjXIWkEwY1PS7kkPxIsZbLbVoFXr7P8qAj iZAYP9JTR+LImSWNnnI+jeOCBe52w7rTc5ofbqbhzKbjAz1GNDZsbl5TcDUCbhc+dFrPn9GQo8H fzIjN/gQbE6xsEXa+v+bWpTFx9+oZZ4+yNn7jmWrp2aeIo+jdd7w4AxijTFpTkobxdVHiJtuIcj QORM23TRlDfM1Bgyaod3oHf3uzjC8vOQzTwVBCujuDoVdXowr+ty/FW1UsoIlzWvxXsZlXKilHt WzpCmXQJdFJmSdan3BVmGcocGhlggydpX0dIYuFBkB9v88EaNS/ckQrrDPKVAkI/Y X-Received: by 2002:a05:600c:821a:b0:456:207e:fd86 with SMTP id 5b1f17b1804b1-456207f008bmr21905975e9.2.1752500671099; Mon, 14 Jul 2025 06:44:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH3ScZAKbeGoqX2wP9/gRIpia/X8+PS57jXCXwanug3eBTNK8Z/wPQG4PIBWgLe3XbF2i1MEw== X-Received: by 2002:a05:600c:821a:b0:456:207e:fd86 with SMTP id 5b1f17b1804b1-456207f008bmr21905615e9.2.1752500670671; Mon, 14 Jul 2025 06:44:30 -0700 (PDT) Received: from ?IPV6:2003:d8:2f38:ca00:ca3a:83da:653e:234? (p200300d82f38ca00ca3a83da653e0234.dip0.t-ipconnect.de. [2003:d8:2f38:ca00:ca3a:83da:653e:234]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3b5e8e0d732sm12689842f8f.52.2025.07.14.06.44.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 14 Jul 2025 06:44:30 -0700 (PDT) Message-ID: <4a3e0759-caa1-4cfa-bc3f-402593f1eee3@redhat.com> Date: Mon, 14 Jul 2025 15:44:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm: refactor common code and improve test skipping in guard_region To: Mark Brown , wang lian Cc: Andrew Morton , SeongJae Park , Lorenzo Stoakes , Zi Yan , linux-kernel@vger.kernel.org, Christian Brauner , Jann Horn , Liam Howlett , Shuah Khan , Vlastimil Babka , gkwang , p1ucky0923 , ryncsn , "zijing . zhang" , linux-kselftest@vger.kernel.org, linux-mm@kvack.org References: <20250714130009.14581-1-lianux.mm@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: tsoTkE-Moldgz1aJ0EHs9w5wW0Yh9zzywO_jLxEhADE_1752500671 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 719B7C0006 X-Stat-Signature: q4q187w3oxidisddnke9axxe617wxtg4 X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1752500674-949726 X-HE-Meta: U2FsdGVkX1/kl+RXs5yLzSNu7ledBL7tdCLdEGVuOwOqoDWwChgRPLRLzzB0luJvRKpc+d2pPZ2YeOAPdJtJLpYrDwNAvjaJ9unn7AO0pg4/6kZ1iU0cQHGIqs/q0A9GBDnNcoT7I04hPVW9Neh7e2GVfmCsUbwMszTq8ZIGzuYNlwMH4WvNnudcM9sQcCuVmhUBlRWHx2myXsQA9GcoYi4XAjtmp8LvpC04cHX86c1R/9BWTu40K16gtyKDP6rwc17I9xGOh6uMfczoyuaZhc4xBoWJUvuJnpwxDvczKVNA20xYwtdKK9yHITcRnNxvP5nI29avQ8Soc0CGUsdeemg0vDk58aekzrqXHl516G4XdQpIc1TbnIhlVmfh/KhhFH8jeAZ8ENnBh2+2VWO7Jb+Y9pa9efXWV5sDiSFCkcBYyLEk1hlWRahKydSnRZAAZDOfQSnQiJlsfhX7vXaHy9obphBJ/YkWb5BkVQxofdzb8vT0Hz+oqxUuFVAIqL3MHeFBJOvwBMwMmfIrVqlNNSL6I5U9uHWxQAE4gfcKtLsZAw21syFup00GwzCKJmqy9soCSEz2YpN2fhogOVHdOB51tTG2TOhlr63vBpwIn+LzHXxxqQv6Pz6MSwgQbqMPU5e4oCwdO3FhzgeWHxSNtOK7Jt0ArEK2NUOFUGNOoDWIj3JSG9WvEUoc+EC7ymDuKSsxvgBGSyel/CINtz5sU5+Z9TWQ44FMZWZ33q4GC0Eb5KSiIa6urT0qBzIvgzTSJflsYt5VqgdfPvoZNYJQroS551A1amv/IAnRfl5Z8n3ROUJ6oRfGTXPKdXDVKzC5EftlhcXppDlr3lA19yba/BThFmF7oQFa9AXvpPZL1jXP8ixG1w2pVXWEvNxkunpfUOSi2f02Jde43cZ2SQmQs+vbXwj4TZULlNDmgCh57BJ3lDCvLsurBTQi77xaewrORK3o8KFckWZ5fHHZt/D iqX9zx1o RkvWNJeEgGtWqIt3drZJWmz0PJjYSHyn2batewnnPiKaRy+H5+l30LMlqMMyv9Vi6alznT4NjLX8K1YSwvKhkw2F0kuC36Ttq6070gzfyQbZi2wgvVx+S6mEBz9zWHZpE8dJ23PszeNcIiiiYseA1Z7skD09VTtzWt4WQ8SU0toXUZF86aKJ9ADcfI3kM0SNyBuOjL0XxmIs1Y/LhSrDJMa5+cMtUj2XPM6MRkyopHN/7sgv14Y3NEyYxLLDZhvrdDYUF25qOo7QHbLW4JgRJQ2VUE77+TTF2+K/PbHFc6cUCU/RjvK2XVrBNek0cCHfFI6LMDPtloWb/YBID645xTBaXaNhm/zxRlfQ/yW+OKTtD8qvk9QYL/RZ9FuHoroL3znBgQLsn2eubrfKtSbfLjZl9mcJztCmtYkLNIHEpZBddfb9f+Onfg0Mr4s2cocRnVt09RG7oGm/+JPSvVQHXsUjYcFlVM2NdiAgJeCeitNBdXOJooy8mzYbFRTF6W1/lkb2a3nf2ZYRq/XZy0H89qH4uexE/4KLDDuIxIgngz7VJkELVBb/VV33+0K4P9LWUGQYVHSFc9f1aDaY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 14.07.25 15:39, Mark Brown wrote: > On Mon, Jul 14, 2025 at 09:00:09PM +0800, wang lian wrote: > >> Move the generic `FORCE_READ` macro from `guard-regions.c` to the shared >> `vm_util.h` header to promote code reuse. >> >> In `guard-regions.c`, replace `ksft_exit_skip()` with the `SKIP()` macro >> to ensure only the current test is skipped on permission failure, instead >> of terminating the entire test binary. > > These two changes look fine but they're not really related so should be > separate patches. Looking briefly at guard-regions.c I see a bunch more > use of ksft_exit_ functions that ought to be fixed as well, but your fix > is good. The FORCE_READ() could be factored out separately, and as part of the same patch, replace the "asm volatile("" : "+r" (XXX));" usage in * cow.c * hugetlb-madvise.c * migration.c * pagemap_ioctl.c * split_huge_page_test.c -- Cheers, David / dhildenb