From: David Hildenbrand <david@redhat.com>
To: Mark Brown <broonie@kernel.org>, wang lian <lianux.mm@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
SeongJae Park <sj@kernel.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Zi Yan <ziy@nvidia.com>,
linux-kernel@vger.kernel.org,
Christian Brauner <brauner@kernel.org>,
Jann Horn <jannh@google.com>,
Liam Howlett <Liam.Howlett@oracle.com>,
Shuah Khan <shuah@kernel.org>, Vlastimil Babka <vbabka@suse.cz>,
gkwang <gkwang@linx-info.com>, p1ucky0923 <p1ucky0923@gmail.com>,
ryncsn <ryncsn@gmail.com>,
"zijing . zhang" <zijing.zhang@proton.me>,
linux-kselftest@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] selftests/mm: refactor common code and improve test skipping in guard_region
Date: Mon, 14 Jul 2025 15:44:28 +0200 [thread overview]
Message-ID: <4a3e0759-caa1-4cfa-bc3f-402593f1eee3@redhat.com> (raw)
In-Reply-To: <a3457ab8-8bb7-4a43-913e-2eb73149ff20@sirena.org.uk>
On 14.07.25 15:39, Mark Brown wrote:
> On Mon, Jul 14, 2025 at 09:00:09PM +0800, wang lian wrote:
>
>> Move the generic `FORCE_READ` macro from `guard-regions.c` to the shared
>> `vm_util.h` header to promote code reuse.
>>
>> In `guard-regions.c`, replace `ksft_exit_skip()` with the `SKIP()` macro
>> to ensure only the current test is skipped on permission failure, instead
>> of terminating the entire test binary.
>
> These two changes look fine but they're not really related so should be
> separate patches. Looking briefly at guard-regions.c I see a bunch more
> use of ksft_exit_ functions that ought to be fixed as well, but your fix
> is good.
The FORCE_READ() could be factored out separately, and as part of the
same patch, replace the "asm volatile("" : "+r" (XXX));" usage in
* cow.c
* hugetlb-madvise.c
* migration.c
* pagemap_ioctl.c
* split_huge_page_test.c
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2025-07-14 13:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:00 wang lian
2025-07-14 13:39 ` Mark Brown
2025-07-14 13:44 ` David Hildenbrand [this message]
2025-07-14 14:21 ` Lorenzo Stoakes
2025-07-15 11:05 ` wang lian
2025-07-14 14:20 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a3e0759-caa1-4cfa-bc3f-402593f1eee3@redhat.com \
--to=david@redhat.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=broonie@kernel.org \
--cc=gkwang@linx-info.com \
--cc=jannh@google.com \
--cc=lianux.mm@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=p1ucky0923@gmail.com \
--cc=ryncsn@gmail.com \
--cc=shuah@kernel.org \
--cc=sj@kernel.org \
--cc=vbabka@suse.cz \
--cc=zijing.zhang@proton.me \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox