From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1AF1C7EE23 for ; Tue, 23 May 2023 09:55:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CD08900003; Tue, 23 May 2023 05:55:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 35694900002; Tue, 23 May 2023 05:55:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21DAB900003; Tue, 23 May 2023 05:55:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0E82C900002 for ; Tue, 23 May 2023 05:55:51 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 9AB8C1A0740 for ; Tue, 23 May 2023 09:55:50 +0000 (UTC) X-FDA: 80821063260.03.7671A5E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf01.hostedemail.com (Postfix) with ESMTP id 5B53140013 for ; Tue, 23 May 2023 09:55:48 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SF5DYx7r; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684835748; a=rsa-sha256; cv=none; b=2Qzj6RF+i0XkbHmJHj66GfF4wkF+QOvhGzLyO2mCbm7vFEnsFr1BFbTQ6chUJtJUJ1UF8y rknK16D4l00n8ffAM8h++nCkaQVCrznfec4cuuMsRCmmZRaK51xxif84/W6zeXkssjLsWf GPPdQNyTfmnt42uNQAZ0vhEhXTLrkpA= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SF5DYx7r; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684835748; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/YZVEtAbMGXAYdoIkesND/UzUOTQcJuA574999NK3d8=; b=PjkK2sxEMjTOCq5Nhru+03ow8VtHE/nR09v+mJ5YFLcmY17/tUxeAu8m0+ZybKC+kWarjq YuokYrlVNviwAeJ0hZah5Uf10VUp9UfxNjiJkfFXKXYWt2y7aMeifhZYstVn7tdcHgfOp9 JHMZXp/DsvDCj6tWM0NoBOuCZdLfDT8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684835747; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/YZVEtAbMGXAYdoIkesND/UzUOTQcJuA574999NK3d8=; b=SF5DYx7rvcuLwpmmrg6H5yCEEwBZBR0c3Tjpjh0N9GVd6kwxtay9eCL682mOOV8JO3U/CO dhwxy69w3b39U/ARNP/fb4wEvmoKvhX/QkMAlUkYSE0hwFsPho0R8CRtvY9qek0U/G/Qef 4B8R9tfX15BGlB74mWgEqBfr2RWg7UM= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-29-LWh05FzyM-Og702YcWCysA-1; Tue, 23 May 2023 05:55:46 -0400 X-MC-Unique: LWh05FzyM-Og702YcWCysA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f60a4470cdso2757695e9.2 for ; Tue, 23 May 2023 02:55:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684835745; x=1687427745; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/YZVEtAbMGXAYdoIkesND/UzUOTQcJuA574999NK3d8=; b=E2yJO/zGT8jP8Vp9ndq91HeK6jP3ntLB0mvX5bqcN0rQyOqNQl9ksCw8jXWt4iBPhr ZCUEYOONTWhPsk9Kr5kqoMZNBXWYRDtDP757IKvPm6vBnQdlo5pGqmC3e+eGExyTHpTZ N0u1W3+kl1AGJLc0l7DZUXbjYHEKJRAenqoHsfVJZC2ZbOQXb3HWpIMUafUbjLGb8cMR oN1etpoe88OgTzAF/+NU3j4zzpSBZMzO/UdEx6J18gtAQVonMRc4/MLTvg9O5nZ7Up9H GwCtsA8aGc3ie1dUQ6Uh77OAnChso9OBAb6knbHn7SeiSDZXw4ZDAvj26X6nNvrLHmPq pY4w== X-Gm-Message-State: AC+VfDzfMAMPKwzTzPY4lhp+w2JpPfYjRQUUoBM/T//ooWhpQAw0xxt7 c/bz9oGGNbN3m7VlxsQZvteZLqMP5e9cYB4sW1Q4VHKBmqiE0D3VyP3DBUdGsj2a0WDI3JO61SX tqsbk+qXvBxs= X-Received: by 2002:a05:600c:28c8:b0:3f4:2452:9666 with SMTP id h8-20020a05600c28c800b003f424529666mr7987553wmd.40.1684835745332; Tue, 23 May 2023 02:55:45 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5jiTVu/IhpqGDiYtn4owqhZUiBNGdKgOHblGxYFQ5Svb4v2MhESPjS2wI1nralmUIeeX1u8Q== X-Received: by 2002:a05:600c:28c8:b0:3f4:2452:9666 with SMTP id h8-20020a05600c28c800b003f424529666mr7987535wmd.40.1684835745019; Tue, 23 May 2023 02:55:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd? (p200300cbc74cb4005c8ba0b2f57ee1cd.dip0.t-ipconnect.de. [2003:cb:c74c:b400:5c8b:a0b2:f57e:e1cd]) by smtp.gmail.com with ESMTPSA id 8-20020a05600c22c800b003f4289b18a7sm11244609wmg.5.2023.05.23.02.55.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 02:55:44 -0700 (PDT) Message-ID: <4a38e04a-df69-5c5d-5631-152b662db7a7@redhat.com> Date: Tue, 23 May 2023 11:55:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v8 3/6] ksm: add ksm zero pages for each process To: Yang Yang , akpm@linux-foundation.org Cc: imbrenda@linux.ibm.com, jiang.xuexin@zte.com.cn, linux-kernel@vger.kernel.org, linux-mm@kvack.org, ran.xiaokai@zte.com.cn, xu.xin.sc@gmail.com, xu.xin16@zte.com.cn References: <202305221842587200002@zte.com.cn> <20230522105305.4126-1-yang.yang29@zte.com.cn> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230522105305.4126-1-yang.yang29@zte.com.cn> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5B53140013 X-Stat-Signature: ex14q4og973w3g81dw1bq3ji9bkxo3ao X-HE-Tag: 1684835748-53035 X-HE-Meta: U2FsdGVkX1+yDq4iNErcxli/VzsFNmgmX+eEvxUoeiLyoCTJnjxLeAXyhcHZqRkJ06f05y/zLjYZ4DVdJX3cixgkRdSr7Hr4TYHpTDAofvxDAsfsnF5ExQdXGee1Ul4xiA7iWxZvZr7Ora3HmnB+eBV0Z5GmDMZ1APMu3WaBy0CkPJSwYKymV3bRTo1/eEVzWuXwFtMZdzvopycbae7N0iUfsGg8gWfYUetWK+qtl+kBBqTtagCvK2o7Vmk6GqmUCd6KZfTkUvRsREBZBWrfGf/+AEkcCJQ/EPhoN5dpZU8J6jsufvjYpRpf1RZmH/+Ru00hgEAi/GPi6Pm0ss00QJEltnmuIw7o0x5xSIV8mYJ9/sQsKJdeKgbBLtn8fp44typTAEhkTXvpSzCgXOwI8L3NKHRpq9oxm3B+8N+ZAxoAsKENDNTShanaQDLpFcoHVk6T3VBt7Qb00tOMyDGrmqi9ZGQBaoZeMRyNxwTaheLMyoTWXaLtvkMveu+kDThQDnYU9iRsY+egv0D5EZkmjG4+kOrxMRvCIz6s3xmzusbF2W9nW4pnucb10lU8cZ5UDNjr32o3kogggyMIItGu2rJXrnNPrzSVdtBNc6evWagb29tUDMvIm0k5pUjPaoK5JwHzrSu4D+woCZXEnzMwCoynsz9A3NbspTqYjWp39Uv/AHFPntAZfV9UsfKJex3aGpXXcaEyRzrWUc77jV+RO8DbkiU3k1gEhWzIyo+jH5DDIlTGpkY4wmwmCxCHgBPCVYO9LQXoZctxTcll67YVfrrYJcvCiIzNr0EhhWomt7p5568O4GAZ2fsuvU8n4blbc/vV/DmWWV88xO8ftkA4z3PJXxZmFzfEeqC7CZBiedE2EIbE8ROk8CZzW+rOgJMQJ5+A96sdAoz2Fe2Gy9fgWt5phQmNUkUQgGgA/6Q+nP3waD1++jNGE2TVLTqAHmxwdk7c5wN413ZffvWt1zO BtZKuAcK vewEhuVr4MUbPyN7TABcmt+CqQmj+DLUNW+JsYRkFAoYqEu7EUz46NPoPPatlXFNpCTo9TgHQ0vlVueS9SRgI3QLrdDX1JX/iV1ksWNO6fONJ/QYeUrOV/cfV/FQ1KGZAEeNTpd8zvRfs0zrBXLWBbESiohE6PCrwLMTyECM7JNJ+LQofa1Wii4Xt16DDfkY3E1OdnGA3RbqNI8Dc+/WeO97iKxbIyMtYkp80Q4M84BZMsuepU+aPRKpfGXOrGWuzXpAyrJlSFYAlswxxP+LczHZsM0BClX9GJlL/oqk7bRC6BBE5XLCcBXeU9t/gDDGoD0qQ9aEF2bjkziNI3EthFSpTOAfjatbk4aawNQM5AONXTPXeQZXWfSdK4CeFnbZhBsaqURnoQYeC1wCccUPtD5+A0Uoj/Z5DXgxvGC1gyUxjIDMpqQwxfLG5PmWBHG8Nu++IWp0n3LiSQ5o36vXh+DBE0jvWPxizjvTtCW00nbPHrlLIkh10a9QxG2Kly5MAss+8jDDXjd5zYhNbVjE5w8SpJqA4yDjDEhVaRKKIhqNer2UN1AJNjUGchQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22.05.23 12:53, Yang Yang wrote: > From: xu xin > > As the number of ksm zero pages is not included in ksm_merging_pages per > process when enabling use_zero_pages, it's unclear of how many actual > pages are merged by KSM. To let users accurately estimate their memory > demands when unsharing KSM zero-pages, it's necessary to show KSM zero- > pages per process. In addition, it help users to know the actual KSM > profit because KSM-placed zero pages are also benefit from KSM. > > since unsharing zero pages placed by KSM accurately is achieved, then > tracking empty pages merging and unmerging is not a difficult thing any > longer. > > Since we already have /proc//ksm_stat, just add the information of > 'ksm_zero_pages' in it. > > Signed-off-by: xu xin > Cc: Claudio Imbrenda > Cc: David Hildenbrand > Cc: Xuexin Jiang > Cc: Xiaokai Ran > Cc: Yang Yang > --- LGTM. [inlining inc_ksm_zero_pages() and avoiding explicit dec_ksm_zero_pages() as noted on patch #2 ] -- Thanks, David / dhildenb