From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 082CDC43334 for ; Fri, 24 Jun 2022 06:09:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4FBB98E01E8; Fri, 24 Jun 2022 02:09:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4841D8E01E7; Fri, 24 Jun 2022 02:09:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 34A648E01E8; Fri, 24 Jun 2022 02:09:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 232928E01E7 for ; Fri, 24 Jun 2022 02:09:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id EE2F68131B for ; Fri, 24 Jun 2022 06:09:57 +0000 (UTC) X-FDA: 79612103634.05.A80E2C9 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf01.hostedemail.com (Postfix) with ESMTP id D1AE240019 for ; Fri, 24 Jun 2022 06:09:56 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D62B11FB; Thu, 23 Jun 2022 23:09:56 -0700 (PDT) Received: from [10.162.41.7] (unknown [10.162.41.7]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0BA523F66F; Thu, 23 Jun 2022 23:09:48 -0700 (PDT) Message-ID: <4a20d826-af0f-0d2c-162e-8797c2603ab1@arm.com> Date: Fri, 24 Jun 2022 11:39:46 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH V4 02/26] mm/mmap: Define DECLARE_VM_GET_PAGE_PROT Content-Language: en-US To: Christoph Hellwig Cc: linux-mm@kvack.org, christophe.leroy@csgroup.eu, Andrew Morton , linuxppc-dev@lists.ozlabs.org, sparclinux@vger.kernel.org, x86@kernel.org, openrisc@lists.librecores.org, linux-xtensa@linux-xtensa.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-parisc@vger.kernel.org, linux-alpha@vger.kernel.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-ia64@vger.kernel.org, linux-mips@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-um@lists.infradead.org, linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220624044339.1533882-1-anshuman.khandual@arm.com> <20220624044339.1533882-3-anshuman.khandual@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1656050997; a=rsa-sha256; cv=none; b=rCSISvTSy2eus26M+y9rc++cwUZeXuH0lAYRsXx52oF+OcxsxViKYLlYhIemm9+RDU5PFZ tZb9xcEyWTABRrEk+DgUGkyVQrW65MTto47SxrEOcJoIa0rMJh4KLl12NyYimg5weYiffp tt1StAdbvJVr9ggUzwisG9q/uok377U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1656050997; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/kOj2Z5hEWWJZ/ApemvhIuwIvlz9aduycEJCrkeijwY=; b=g9cVzw6GqNPmYSSqcfqegRauEiDsotWs7IDklv+KPF/+GxErX4wGTSnSIItxn1ft75KhhK yTKTPEHMTqT+3qEviahe0bg/2zurTVBfT3tzY+Xq/kNmlb8ExZ+wGo8ltn2fbrDAA5kt1e yrSCxoSlpRjYyldRc0wZu7JeUX+vJtk= X-Stat-Signature: po86m6ga1h1stnaszkwf851b6osr6dej X-Rspamd-Server: rspam08 X-Rspam-User: X-Rspamd-Queue-Id: D1AE240019 Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf01.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com X-HE-Tag: 1656050996-486226 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/24/22 10:39, Christoph Hellwig wrote: > On Fri, Jun 24, 2022 at 10:13:15AM +0530, Anshuman Khandual wrote: >> This just converts the generic vm_get_page_prot() implementation into a new >> macro i.e DECLARE_VM_GET_PAGE_PROT which later can be used across platforms >> when enabling them with ARCH_HAS_VM_GET_PAGE_PROT. This does not create any >> functional change. > > mm.h is a huhe header included by almost everything in the kernel. > I'd rather have it in something only included in a few files. If we > can't find anything suitable it might be worth to add a header just > for this even. I guess should be better ?