From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F3ACCF9E9 for ; Thu, 26 Sep 2024 08:27:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC26E6B007B; Thu, 26 Sep 2024 04:27:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4AEE6B009B; Thu, 26 Sep 2024 04:27:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 877396B0089; Thu, 26 Sep 2024 04:27:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 627586B00B6 for ; Thu, 26 Sep 2024 04:27:40 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id E3AB41C6056 for ; Thu, 26 Sep 2024 08:27:39 +0000 (UTC) X-FDA: 82606210638.15.D632575 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf01.hostedemail.com (Postfix) with ESMTP id A62CF40013 for ; Thu, 26 Sep 2024 08:27:37 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HB8LRM66; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727339137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=g5bR1aZAH3LgvrlLbozlzlRAEbSP/ccsu/05/fH/lFk=; b=jtx9o/wgGtLaqj+c1V8d6+KLMOf3jjSiFDB3hXI8oSTEUbnRT9CROjByKRVcPCC4GXodlx WinyK/Iz3hxi4Xu4Qd1Zj48o8haQqKl3V5Eox4ssLnQqLDyJEhhCNIDpch2KSkQWDOFES4 jytlBr6pHe5aDWgA40Sx/9i5WRzQzco= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727339137; a=rsa-sha256; cv=none; b=3O/Yj35DaiTxKv2qdFXim125f9MoApmV8TCYo4fMT3WKFscswfitLdPty67jlE0162g1KB 3Xbkz2wyZ/KOvAvOr5h1cHApWBAX7Ix+Er59Sfw4khSbLcTJSnMnFMngdlmc/r6Lw3xao3 BC9h71zvSZvl1lIIkb4khwt1EjTsS+E= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HB8LRM66; spf=pass (imf01.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727339257; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=g5bR1aZAH3LgvrlLbozlzlRAEbSP/ccsu/05/fH/lFk=; b=HB8LRM66/GGibyyYk9vUZADWd9raY7rSXAJfzvK6+AY7ldIIp66/b52qK39K+9xXSFz8Xp 0l5X9CFcDwEsKsUao6/TSb5UBSQP8EOJAA6kLgRtzUC+DfP+fxgafx2jO57Es+uZyaA+JP KzfemN98BwfIY/mO9CgKVz2pZKFwG0s= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-578-g0UzgM86NTKSmwtHZ38xkg-1; Thu, 26 Sep 2024 04:27:35 -0400 X-MC-Unique: g0UzgM86NTKSmwtHZ38xkg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-37cd19d0e83so96519f8f.2 for ; Thu, 26 Sep 2024 01:27:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727339254; x=1727944054; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g5bR1aZAH3LgvrlLbozlzlRAEbSP/ccsu/05/fH/lFk=; b=X1wsyDALC1D+ZSaHfxc9f3tqx9RIcnPagUtDmXdRpuiXJ0SArDvvWtiLnFaqiaxYJ9 5mlMcrH425thv8GckOiVzJPeonl1r03m/+6LD5YMUws0CBfmx+3qfxld4I4CCrz0kxsJ bj+Vjab14nID6LSCD3tY8uFIGykwV/xJyoPw311KBadtzvldnkqSlk+5Km8Mq2zPCkKL AJEtMLuIKFDYMn8W7YPjlFPP9rCzSXak0eyiNKmO5yraJMN1mpdhKPhARgO8hZhvJNpo Yts7H0IUZ74AcVb2gD8WZABltJeCliMj2VqSCamly4sH0zkXGJLDgsm86pIe9B/X08KR 55Ew== X-Forwarded-Encrypted: i=1; AJvYcCWeC0mLnYwGwnXSRwka1GMRSK79Z9HFfhKn960KGcmDUuloOFcbZNDkzOl2sajjBZ3pnnvcOypFMg==@kvack.org X-Gm-Message-State: AOJu0YwwHMGZ1CHVXQE/8D/G/U44a9sBCgoa/o5d9FQ301DH8YXSkx+w ztV4KOA5vj+T+oS+e8aATtL4U/mINmIlfuHp4JzMmXBZUWjBxRp8XanEKebNE1jtaU0aLf39JNa lZeKLZ5fBU5mE8j9EkSb3E4LF4VgOQB7wMCUntEUHehd9oMCP X-Received: by 2002:adf:f6d2:0:b0:374:c581:9f4f with SMTP id ffacd0b85a97d-37cc24ca5bamr2606982f8f.55.1727339254374; Thu, 26 Sep 2024 01:27:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6WUwCRX5yHjAs75ojmW47mwAx+1adc4U+hO4SEIYIR83/pbeh4Tz/lYWMH+KXco4+X42lWQ== X-Received: by 2002:adf:f6d2:0:b0:374:c581:9f4f with SMTP id ffacd0b85a97d-37cc24ca5bamr2606972f8f.55.1727339253980; Thu, 26 Sep 2024 01:27:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c744:ac00:ef5c:b66d:1075:254a? (p200300cbc744ac00ef5cb66d1075254a.dip0.t-ipconnect.de. [2003:cb:c744:ac00:ef5c:b66d:1075:254a]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37cbc2a8c02sm5815308f8f.10.2024.09.26.01.27.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Sep 2024 01:27:33 -0700 (PDT) Message-ID: <4a1f6d36-a720-4259-92c4-4d1f9b90cc25@redhat.com> Date: Thu, 26 Sep 2024 10:27:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2] mm: migrate LRU_REFS_MASK bits in folio_migrate_flags To: "zhaoyang.huang" , Andrew Morton , Matthew Wilcox , Yu Zhao , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhaoyang Huang , steve.kang@unisoc.com References: <20240926050647.5653-1-zhaoyang.huang@unisoc.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240926050647.5653-1-zhaoyang.huang@unisoc.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A62CF40013 X-Stat-Signature: hzkshrtp1xdgaheskdjgcwtrobhkqbz6 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1727339257-640999 X-HE-Meta: U2FsdGVkX1+BSpt32XfWip4fg6ZUzFes1IVaQoSVssbc0UtwjbIVseooYqmirMPrqDJAdzrVVkkaHUJ391ANfO4sYDSfbuLtbrgYq5ypko08EQ4DJD7G9rSwPaJ3mp3FYNj6CXhZQrKgG1HfM+6GZN0IkLM0pyiP56Rpng3bJKWYkuavEagSG5Nd7ic2OlFcjYKZprYt7pr+RWqu1nobNrrnbOfEsTSuVeIKnKwP8/zy0uNY+el+jFu1M4ysjK87E+/X4vka1VJVij+6h3XjNuJ+2Xr2pfWEcy6swceEMGQMF66u6jODYB3Wf+96PW0sRqd7X9t8/RSvvR58vqK/415rZbU6/HqZqJFoPpiy9RDpkVuMgkvwqrJtnsRZfJvsHmenclmtYEwP7fGBwGRAdk8A5x1NVXcQsq/cHp6f3ziCGSYaA41miRMcm8flh1vHsQ5YzFK0XRKLz+f/HLnvhnfybu3/A2tQCEpt/cncp6d4vhZYgdpkf00kRkfMN/UyBHUow0YWbv+2V5K4dtnRj+s+HC1HjgSw904z9dpzVYdRNKZTQcg3s5PrRdPA+e3kPsGYR017wJDLZDBaKL1DVVfruPrF0p7B/I0JAlDfpEd0yYH40YIf+CCkpZ+pbPQiUKXn401A7ZRIo4QV9R9Owy9bwUwjVK8ON9MI3ZmgE6IFK81U24yeI/925UsQ/ovpNCQZ0hj7X/IV+szMDfurUDXYapF0jYjq2OHBGzQN6k9Y3TVc4FiQR9P0nfNx+E5pSOZjMxsbZz51yrP1r/2MdqwpuasYlQFZNVG9dRKgaFLD+1MDTk2SL4AdgtJ68wYhZ0YBixlzwql+DeDRm8ferlDQ2z2YAacS/7F5zoDGLPZiRq5XynXMteeOVwrew40JePByaVO+oZNowQ5UbzT+zmRJdR1Soe4rBr1yHI6iduh0Res5W8EUKNhcnIktSPoT3eZU4qRa+xob7f2+pSX f0o2uPsn 6Q5ZIefBgP7/pBr5nSSURaugTFAjH2kgghZHGAv/LYeRmZLQBxZ+eLQ8UjnA3IXEw8TakYrKIRABrm10sWxdF8mfuT9+joDRvaQKeEW7PUMzu0deJTzOGuNk1UW2UQ60VXONBcSz0lNAbWRFziOZBKubAZTEWynKizQqtfevqVzefVj3VhYjRNABpr8eMgi1SaXflcsKJgq0W8YK/FlsNSzJ39Ug21nrrZ8lpq/DMayTohuNUigaphwHd3w+bd9kONfRggFG0aawgbDlMrJ7VngAfn0r5NtcwnqOUAAums/2ZRehqFG+qmYRSREieCMSwvlnwtJ9zxqQ/9T/W+ywM69xd5Xgecn3h3nf1ENX/fIinSz0LVeAIRbUpWMeSG/GieKoz4D9RtIUvGdtc8T6HxMoSX2tB1EgPc7/VRFaKxY1xL7q26M8+XFzFa0qV2IYgmBbvjmuqWKP/wZdVVwM8cj4Do+2XRtwPb+nKpb4djfR/nzAiJFxyIsFT1M6k8rOBkPJ8A4lC+hsXFYxodZkxtOKy8ZtsD/CEOFRiQq8Wcwkxhzs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.09.24 07:06, zhaoyang.huang wrote: > From: Zhaoyang Huang > > Bits of LRU_REFS_MASK are not inherited during migration which lead to > new folio start from tier0 when MGLRU enabled. Try to bring as much bits > of folio->flags as possible since compaction and alloc_contig_range > which introduce migration do happen at times. > > Suggested-by: Yu Zhao > Signed-off-by: Zhaoyang Huang > --- > v2: modification as Yu Zhao suggested Looks reasonable to me Acked-by: David Hildenbrand -- Cheers, David / dhildenb