From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 613F0C3DA49 for ; Fri, 26 Jul 2024 15:32:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD68C6B00A9; Fri, 26 Jul 2024 11:32:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D86886B00AA; Fri, 26 Jul 2024 11:32:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFFB46B00AB; Fri, 26 Jul 2024 11:32:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A28656B00A9 for ; Fri, 26 Jul 2024 11:32:11 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 330B241925 for ; Fri, 26 Jul 2024 15:32:11 +0000 (UTC) X-FDA: 82382294862.19.28B3233 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id CD26CA0011 for ; Fri, 26 Jul 2024 15:32:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LnEgtyuM; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722007904; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Ycth9+LBlSYBAQt5hef55NWuGeGl5lxoPpY/WIRu5w=; b=dKh6AXv1M6QFpgiPjry+tGozcpQmogEHFUqhnj0biuI1q/aXcbj9Jjww7cn4SrwDlzeIMU 5ozleCHk5nZQYnZdPXyc6AfLVlBG5eTcH4ntKNHmwokm4UldYs0LY+rI8gIes3zIVua6pe tid4xQp8tSkz/CztgrUs7UtPUEWp50c= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LnEgtyuM; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722007904; a=rsa-sha256; cv=none; b=uzd3Gf1m9HV0zXKwuaDay5xCCtDv9EjWx6ek0oP2mVYVSEFMLq0vjyS/88oaTZYL26+cDD FwN35caDyFlBybauosuQOPBhYP1W2hJHTIKuN/YebikFpjFoHhN+p0t5b+cM+E2mFEkGsi wD7xCV4VZADSC3jaibuCKuBL+7xanrg= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722007928; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=8Ycth9+LBlSYBAQt5hef55NWuGeGl5lxoPpY/WIRu5w=; b=LnEgtyuMoXxlb1yFGobekAB+Q7CzXhsCNvQb0wNDGbhOfGZxWOeuLS06YjDY7wkEpQeoKs pWWCNJZg47eZDpsXupxymNejHptYrWAinI4d/u/ZXLkvYXhk8TVsstFUsrn0r2Ixsbj88+ 3l+bz35uJmtT2qEM2F3wHV2O5uVt/b4= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-398-c6WnwDINNUqF_iDAWO9sFg-1; Fri, 26 Jul 2024 11:32:06 -0400 X-MC-Unique: c6WnwDINNUqF_iDAWO9sFg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2ee81ff717fso15036621fa.3 for ; Fri, 26 Jul 2024 08:32:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722007925; x=1722612725; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=8Ycth9+LBlSYBAQt5hef55NWuGeGl5lxoPpY/WIRu5w=; b=VYRt4LSrsgjVj5FNXvqWaBdbvUd5Gh/77GOGaXy99mFN6WQa7GvA836vcS7ZNPVky4 wzoWwSWeXY7FgYdjXIG48sOYBjPmYle66o2knrEjLAu2hxU4wtKgRPrZThtkVR/Z1RLz p/L84QdupAoIWVO7EYaANMHPHvGDBTsKObxa73A+WgB67Qdv2ZMLvMqdcy3q8SVcXT1p wc0zdQX67SG3091bbSqkQ/LiPn+N5Gxdp0idn8PDYfWNLmIVJgUZ+7yunqqxcJxeYZ2N p1W2ILOwJ+i04XEXEOgghO/2se1EsO092eynjAJkD+ZN3jyNtZBt2/+EZsezQj7Ll9nQ r+0w== X-Forwarded-Encrypted: i=1; AJvYcCWTUJJarK83LwMWSfWK5Xd08nKA6rKWMzz4WDXvBDuXpx/H4cnykB9WxI3hKSpTHFnfUfDRCZREJIY9zKrLBxvcqCg= X-Gm-Message-State: AOJu0YySQJ/oKeEnJkiNXSzYgJdTF6+qcvi4G+xni8neSBEOOVNEdw5I vibczJ52PE5lfZ0Bz8E4kIPfsn2zRdvrK6JYQgFjFSeb9lIPMcHFTF5Equ1l/IHsu3e3GVvB36Z Zogmz8EJLRUBvMQjWoxRv+sdlaisijlzwm0PBLI3Ywq6VA9Z3 X-Received: by 2002:a2e:80cd:0:b0:2ef:2332:5e63 with SMTP id 38308e7fff4ca-2f12edd6bc9mr350301fa.23.1722007924874; Fri, 26 Jul 2024 08:32:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGFyXy8M7HOVMNlPdorYprerISt2DRk41ZnUMBik8Qskml6v/WdKDelYreTxESB6bf7zGgnPg== X-Received: by 2002:a2e:80cd:0:b0:2ef:2332:5e63 with SMTP id 38308e7fff4ca-2f12edd6bc9mr350041fa.23.1722007924353; Fri, 26 Jul 2024 08:32:04 -0700 (PDT) Received: from ?IPV6:2003:cb:c713:a600:7ca0:23b3:d48a:97c7? (p200300cbc713a6007ca023b3d48a97c7.dip0.t-ipconnect.de. [2003:cb:c713:a600:7ca0:23b3:d48a:97c7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-428057b7274sm83556925e9.40.2024.07.26.08.32.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Jul 2024 08:32:03 -0700 (PDT) Message-ID: <4a12630b-bd2b-45ec-9a2d-57ed9ac2faa0@redhat.com> Date: Fri, 26 Jul 2024 17:32:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/2] mm/hugetlb: fix hugetlb vs. core-mm PT locking To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Andrew Morton , Muchun Song , Oscar Salvador , stable@vger.kernel.org References: <20240725183955.2268884-1-david@redhat.com> <20240725183955.2268884-3-david@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: CD26CA0011 X-Stat-Signature: ud64j3ceso8mqystd85fqukfiqxpdpcd X-HE-Tag: 1722007928-643083 X-HE-Meta: U2FsdGVkX18yOkTSOiBeV+RhQdFHGBTAfNNn6UzL8YHRdHI9ucuZzgp1wG0m7UkKJlDGR/FvZXI12rRIqQX8SdXufRJPQaNBcwVeG45EjlAGlv/UyV4Tu99ORGnWcPX+E+Tblu9olWL18hdC1W1Bqa6sxTqF8U0D7geIzdSZtwnbQrrmt1DvOnEaXP0AtOS7X1BrGaQpyYQXV1DlQyt/sVrWTFN1A48aKU/mLE2qUiZmAuANO+X5OFHa00+71rLqCC78CDGasIJ2hOzT7ffHT9md1BA1UmKA3HXTANcINY85QymZniNSe3enBS5HOQWhU+8jkQrRDlDOPEZtu987YdbzLWEYwkaSiVXVQ4k7fRq5QgqfTURp0ofobAErz/FO5qNLqy6Y3xOlHmeuiLp80+tzLrIP8F54AEEnQZdFcsnEYaYjxV+aEvSAuHAGQi1GJsA5obL381F1ChM3KOfaJVCjyZfeN8MB77fFSgm5c3DqC0IGwUXXGk3x0BgmoZjsLhbs3Tm4QsHgqpK3/AQuuTa5WGgLX677pB9dehZiP1ymVMd8BxbUaOm4DbFDsrqOjFExnpNThxvkCNSa6gxZPluUhyjNvuEDHmYnBy4kCiJkycY1i5uJpKXvbnTRvbkSlTQGZOVQ35ytmvxGJm0T7+c0w9PhKTBA1BteTRbxohC02mNV7fpEg3PDqR0a7Fg3W3SRqtLUhEsijjzh0PP2KfmloA+WaK8yrCRKF/iJhIs8B1sob0Mk8CtkQ4zvYj2N4CPEyC5aYyrIcDEgp5Za0HAJDVj2b10pz0SGdld/xtQgyTLah4M44x90g+7cOraZt81e+1AUAyQkagOsE9Y1sYhIQ/EZebdM6TZsAVZkj0d9jDIHCcHzEj8JXrWznIPryqVWbC3G14u32aOribl3Hjqsel2BfmBQrnmsxjZ9HK6j1IXUpH+X/AHtRxoU2AHYld8tL0RaHAJ5yth8Gg/ hOwuyhQd GEbyWkRIzoy2gTHuCYvOVGzWLd8PCCBwZnQGOTWmvPDpAQZ5vHsQ6Omfp9zuBQOq1WRZQpNufF4cIX1iD20tT5Aho3uS+ZdXsf69Ho+J/4V+tVWSsK9ZGcatb7e4OGggddB78MgZ66XrnPGVnGD0YkagvsvrdmzlEL7ea5Xh7xOkHc6EdIKfHgHU0LrcGHg2WdAGTo1cehNzOUiG2hPFjjDT0o/eoCzqZpLAsxqUjZEnvN8ZegcxLj4+5QeZgE3mkRak4Lewril6ihSLw90XJj2CA45kjw8iAjwn3oGNV7UWM1G6QdLE3I8dOQFfRJYzxxFnW1St+by5idlvq2YBSfI7u6QLctkFDbuEPOGMEbOTR2u9E91bREu4Z4Ryc/6AYmSRbI79CeG4FLSwnZGKaQkLPUcPEGgi/3uVsLs3Dgn3Y8sQsiJKUPb6vZ28oPkaA8TeTK2nJCkCgsWU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 26.07.24 17:26, Peter Xu wrote: > On Thu, Jul 25, 2024 at 08:39:55PM +0200, David Hildenbrand wrote: >> We recently made GUP's common page table walking code to also walk >> hugetlb VMAs without most hugetlb special-casing, preparing for the >> future of having less hugetlb-specific page table walking code in the >> codebase. Turns out that we missed one page table locking detail: page >> table locking for hugetlb folios that are not mapped using a single >> PMD/PUD. >> >> Assume we have hugetlb folio that spans multiple PTEs (e.g., 64 KiB >> hugetlb folios on arm64 with 4 KiB base page size). GUP, as it walks the >> page tables, will perform a pte_offset_map_lock() to grab the PTE table >> lock. >> >> However, hugetlb that concurrently modifies these page tables would >> actually grab the mm->page_table_lock: with USE_SPLIT_PTE_PTLOCKS, the >> locks would differ. Something similar can happen right now with hugetlb >> folios that span multiple PMDs when USE_SPLIT_PMD_PTLOCKS. >> >> Let's make huge_pte_lockptr() effectively uses the same PT locks as any >> core-mm page table walker would. >> >> There is one ugly case: powerpc 8xx, whereby we have an 8 MiB hugetlb >> folio being mapped using two PTE page tables. While hugetlb wants to take >> the PMD table lock, core-mm would grab the PTE table lock of one of both >> PTE page tables. In such corner cases, we have to make sure that both >> locks match, which is (fortunately!) currently guaranteed for 8xx as it >> does not support SMP. > > Do you mean "does not support SPLIT_PMD_PTLOCK" here instead of SMP? Split PT locks are only enabled once we have NR_CPUS >= 4, so without SMP (NR_CPUS == 1), no split PT locks are used. I document that in the other series that I just sent out in a better way. > >> >> Fixes: 9cb28da54643 ("mm/gup: handle hugetlb in the generic follow_page_mask code") >> Cc: >> Signed-off-by: David Hildenbrand > > Patch looks all right to me: > > Reviewed-by: Peter Xu > > Thanks! Thanks Peter! -- Cheers, David / dhildenb