From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E59EC25B7A for ; Wed, 22 May 2024 13:13:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AAEFB6B009B; Wed, 22 May 2024 09:13:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5B916B009C; Wed, 22 May 2024 09:13:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D52C6B009D; Wed, 22 May 2024 09:13:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6ED0C6B009B for ; Wed, 22 May 2024 09:13:13 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 2678880163 for ; Wed, 22 May 2024 13:13:13 +0000 (UTC) X-FDA: 82146072666.26.A06CEDF Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2043.outbound.protection.outlook.com [40.107.101.43]) by imf08.hostedemail.com (Postfix) with ESMTP id 4224D160005 for ; Wed, 22 May 2024 13:13:10 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=Xf1w9Lzv; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf08.hostedemail.com: domain of Vignesh.Balasubrmanian@amd.com designates 40.107.101.43 as permitted sender) smtp.mailfrom=Vignesh.Balasubrmanian@amd.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1716383590; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=126vmUXEHnr6d3eZPbJF1N47h9bf2Gg/6iKrDl6p4gk=; b=1mCROR8fgekbqu/PaF+T3Yq03tR+UUHwHnLWEL2TimEd1kV8OL/z73SpiprgefkWlt7XE0 PXh1BUnTmi20OiU9cHwsdqd2CvtFoZPFuRI4aHJoWM1wO641l3J+Eoi6bA3QVh9opmv3aP 1FRl/0a5FFy3fBKVrMsQH69Cgmv0+1w= ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1716383590; a=rsa-sha256; cv=pass; b=XEaR/nFf1AQrDjbZMxzu4sS+cuSfB5wHszW32VIeCu4CYIUHfSac6RmHmth06bIug8WeH5 bEl/6tXv8xmMND2AQ2euT5+woG+LfwLWKqWNj4TggC99HEr4kxydX40hvTKq24nLqiMS/k IbKsOzZkKbFItQ6NgbutsNhdq9emCDs= ARC-Authentication-Results: i=2; imf08.hostedemail.com; dkim=pass header.d=amd.com header.s=selector1 header.b=Xf1w9Lzv; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=quarantine) header.from=amd.com; spf=pass (imf08.hostedemail.com: domain of Vignesh.Balasubrmanian@amd.com designates 40.107.101.43 as permitted sender) smtp.mailfrom=Vignesh.Balasubrmanian@amd.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MH4+h5Mvkb0KX0V20DmWA3bFj0CW9Swuxx6V6tSCr9VW7TurGQJ/NqPzdDSLfEJONHLnz7WD7JlrhVxQ1ZBxyYoLZ9rTgUll3fztlW05CKA7RaoUq/ilgAn4aDuOr0qIzJFD5cwXWimIU6aRbNinyuoMxp29APw8vjyIpskwHxR7rXyR8I0yg38f/SkTsMUu9gdxTfkfe5GgKvJLgoTgOS+rPllve/Z8Oh2SM2oNEWr+vRhl13T8JtEQrMxGdljm9z+vcHtdJPRpnfDYOYAIeeiB+JWIbOYjv5pGNAkUX/wEyv0l0BWqqjEnwAaJgqWQJDmy0j3fN1lmadVJaadAJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=126vmUXEHnr6d3eZPbJF1N47h9bf2Gg/6iKrDl6p4gk=; b=k10Oxnx5lolhXIYKBtHbvmyNHWMb43k9Su1Im5tG+8Icx9Nlftg5aqvxf4SJ7gVEex4kTWb6mE2giNRy3niIVB/Z0AYNBS7Ud6m/DlVXwoMxcUMSwnC8iCfRY8aEH2iAEjk5nH5Yj+A0KTZ1HdGex4XBGz0TF3wuSdDmJnbOq7R1BzqxUTyVgfkJtvG+cegd06S0gyta+SEOJLCj02OpdswS/jSw1eqdKqd9i+gpssbIfH5GhtEhVosSVACiRfW7uX0puhntxh1ZHpHPOmBY99wlptsKJOeHNCve6g/roZ8Qd7kY967NKWdk9IHGwThLvcaBzmooR/fmG8vr3yuM9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=126vmUXEHnr6d3eZPbJF1N47h9bf2Gg/6iKrDl6p4gk=; b=Xf1w9LzvTK5Ddu2GywbtGiQ0f2qMdQlj2CQUsHj2+LJ9iO2FLT4IDVzKrUuDmH7HzwtNptZLrvunEgZDRkNfv6D8EqrodiD+d7/SBOcJamb2DXcFspfa9TWh6drvKXrtJkg2eRVP9+u59rn9n++Qt1bB9in2JpbqETUAYH/7SWo= Received: from SJ1PR12MB6124.namprd12.prod.outlook.com (2603:10b6:a03:459::15) by PH0PR12MB7011.namprd12.prod.outlook.com (2603:10b6:510:21c::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.38; Wed, 22 May 2024 13:13:06 +0000 Received: from SJ1PR12MB6124.namprd12.prod.outlook.com ([fe80::c15b:b99d:8d9e:fb25]) by SJ1PR12MB6124.namprd12.prod.outlook.com ([fe80::c15b:b99d:8d9e:fb25%6]) with mapi id 15.20.7587.035; Wed, 22 May 2024 13:13:06 +0000 Message-ID: <4a090901-9705-40aa-ac3d-d67c52660f22@amd.com> Date: Wed, 22 May 2024 18:42:55 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] x86/elf: Add a new .note section containing Xfeatures information to x86 core files Content-Language: en-US To: Thomas Gleixner , "Balasubrmanian, Vignesh" , "linux-kernel@vger.kernel.org" , "linux-toolchains@vger.kernel.org" Cc: "mpe@ellerman.id.au" , "npiggin@gmail.com" , "christophe.leroy@csgroup.eu" , "aneesh.kumar@kernel.org" , "naveen.n.rao@linux.ibm.com" , "ebiederm@xmission.com" , "keescook@chromium.org" , "x86@kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-mm@kvack.org" , "Petkov, Borislav" , "George, Jini Susan" , "matz@suse.de" , "binutils@sourceware.org" , "jhb@FreeBSD.org" , "felix.willgerodt@intel.com" References: <87wmo4o3r4.ffs@tglx> From: "Balasubrmanian, Vignesh" In-Reply-To: <87wmo4o3r4.ffs@tglx> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SG2PR01CA0137.apcprd01.prod.exchangelabs.com (2603:1096:4:8f::17) To SJ1PR12MB6124.namprd12.prod.outlook.com (2603:10b6:a03:459::15) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PR12MB6124:EE_|PH0PR12MB7011:EE_ X-MS-Office365-Filtering-Correlation-Id: d8a7ecb2-75c7-46f6-e9b0-08dc7a60eb37 X-LD-Processed: 3dd8961f-e488-4e60-8e11-a82d994e183d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|366007|1800799015|7416005; X-Microsoft-Antispam-Message-Info: =?utf-8?B?RlQ5Ym1xS3NTU2RWS3VKZkt6V2JQYWpxR2IxY08rZm4vUW5WcWpiRm8rdnlo?= =?utf-8?B?OEt2Ti9FT1NhLzRvcWUzWmxHRU5PVTZnZFlwZXRvazVQUG51Tk8yU2FrNk9I?= =?utf-8?B?bWl0VlpUOXd6NVBWdTZTMkhuSk12cVlhTHRjUWFtbVFBVmlCa1VONnRQbUpW?= =?utf-8?B?Z0ErcU1CRFR4SmZScGlKdkdRdlZGc09JVWkvUTlsRFFzcSswNGFJSW9Ka3hE?= =?utf-8?B?RmEwME9LTWxGVUpBY0pwRFlLbEpHc3ludzdVQ2wwS0tQY0hoV3B3WjNzTVVv?= =?utf-8?B?bUVzMFNLaGxwelkyZXZwMkJtYytMLzRJTFRFd0NKUVQwUFBqVmxuVXV2ZXY3?= =?utf-8?B?Vi9HRGM4T1dpc2N2RUFvb2hJSFNnZ2tCWXlZeDhDNWoyRU5ENFN6czZlMjZa?= =?utf-8?B?S1RWL0pXdTlXQ2FieU13eU1rb0tyYVA3Y0JvRWluZ0h2RmxtMlZWS2lYdjF6?= =?utf-8?B?MHhBM211Tlh3ZVloOGxkaytxaTZWbkRpY0hseW5pUUk4MUxTTStnQ3BGL1F0?= =?utf-8?B?M1lvMmo4c2Z4Ym5mUGFscC92YWUvRU1JUlpuakdPa1JXdVQ0RjczRWJ6cXB6?= =?utf-8?B?ckxNMG9xRGVQSmkyOWNEVFZCRUwxTUU1Z1QwVHMreHZDb1VPeEVuVklrK2Zk?= =?utf-8?B?djVzWU9DdXh0NWNsSE5SSExsTHM1ZlY5WUxPdWI4cndScEYrdHlqcVREYjFm?= =?utf-8?B?bklLL2tzY2JkNDVCb3ZNWDE2ZTNhbXV0aXp6dFJBY1F0RjhOSUZkQVZjbkR4?= =?utf-8?B?YSsyRGk5L3dhNy9LbUVKUGc4YUNrMWdUSEhqK1Q5MlkxVFJUd2pwaWFCZUtU?= =?utf-8?B?d0Q3azRhWHpVaG1OUlYrRHJnSGdSVmNpWWFxaURnR09sZk1lODR6djZlaWFj?= =?utf-8?B?YW43b1dFV2E4djJ4V1RNTjBWNTZxMml0VU5Wc1daamJUdjF1ZzQ2TXBMbHdU?= =?utf-8?B?LzVpV3JzU3BjcXNQd2g0VUdodDdBU2ZORUkwZmxUcmlnTHJ1SzVLNzZ5SGZr?= =?utf-8?B?SzQxUzdWdTRzZG5WSGpiMWRIbnFSbGFHbzdpY09ONStTNSs1TXkzK3oxTG4y?= =?utf-8?B?cmUvd2VudzVId1ZSbElic3pHbnFGVk8zSVJnd0doUlJvZnh3SjNOZllrY0dj?= =?utf-8?B?VGI1U0VoYXBzL3R0V1I5aXNpQlRmSWJEVXAzNGY5eEx3VnFRUDhTdlljb2wr?= =?utf-8?B?eEFCS2Q1WkE3bEFoQTVXSWZrNjd5VVh4Zk01SEI5Sm5sNDJrdDBrTms2WVYv?= =?utf-8?B?SUxuR1owS3VVOE1BREUzYkJtakd2VnZPalhicXdKNzF2QUpmUmt1WVdtTE5X?= =?utf-8?B?UjlWTTNqbzVobGVHK2Z6QmkyeVNRT0lEU2RzZm00S0pxNm11NHYzTzFGV21h?= =?utf-8?B?dWhZL0licHM1bVJ2b1l2enZ4UE5lenR3MnBuT0FteDhtMUNDR2VpQ3pPNFRJ?= =?utf-8?B?RGVrZVd5Qkd0cVFQeGZpUVlMR1FCYzcrejNUNEljVkwxSTVSTmpVdkNNVm5Z?= =?utf-8?B?TG9Vc0JFd2d2TEJYTGtXam1TcnppeVhHUXZFTWxhNjg1d25KRFh0ZEZyRk13?= =?utf-8?B?VEsrNHF6QitEMUJaRURpcUI5RWFWNEhOd29JV1NoYVFabTJsYy9sZE1oTXc3?= =?utf-8?Q?jsJPM2298J+9XNkN3/4BY92Zl4Yr+pA9ubuP+TZsDNdg=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SJ1PR12MB6124.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(366007)(1800799015)(7416005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RllPTjN0V0gvc1diYVRpL1hTdjE5akRKSSt6ZW5MdUtCNTdKdzNYeGQzNCtl?= =?utf-8?B?N1VEOWIzOVl1SDB2ckY0R3llS2xlbGNEa2R2L0xNb3REb1JnaUFyNVZiVWlQ?= =?utf-8?B?d3AvZ1ZvMG0xVVlvYmNMNkhlQlRMOXU2M0tIMVIwaUFuRThQZHY0Z1d6NnpO?= =?utf-8?B?WThGTVRtaXhGSjZXTWptT3psV1o4OXNHaVQ4M1Z0dHY5ZnZzWGZTb21YSW5z?= =?utf-8?B?S0VMWU1ZVm1UWjE2MjZWRGtWZG91dXZtaVlkVXl2VFZaL016ZzhGbHYwNnRU?= =?utf-8?B?bGM3VTFWU29HYWhaQXU5Mjd0Y1NCYmN3d284OHFJeXJDcW1kTVpYVForaDZH?= =?utf-8?B?Ri9pWno5aSt0cm1mcWlpQ2k0UDMvN3UyTGlpTTJzanh3WnpWcUJ4Mkl4dmRS?= =?utf-8?B?T2F2RWVkeGREeHhyRFhaYjhNQ1lpRi9YcStMMGdHOTRQUnRKcG1xNldmTXpS?= =?utf-8?B?dVNxSGwxVlF5Szh4OUJWcnhGREM2cUZtaWhKRUVnR2pJVjdHS3dmYmc2RUlu?= =?utf-8?B?TWc3WkdwUml1MlkyMkR4R3N2NHBVeGJxelZHbmVkclhuOHNoK2pxRnFjZ0Rz?= =?utf-8?B?dTc1ek5VZkhVR0c5QnZMYVQrZm9aMitnQkhzWHZsM2JVMmNDRys2UjBwZHBN?= =?utf-8?B?WEUrKzZ2YmdNVGxTcklGcVhKd2h6eDdSREg4TVRPSnlyRDc1MllYck8zYnpK?= =?utf-8?B?c1hkbXI3UHF6Tjd1KzUrYm55bGNrcjRYY0sxRUVRNnFnaUdtcXNRdG1xM1RW?= =?utf-8?B?RTRHZjMxWjd2aSt5cHk5N3Z2dmt2M2Z5a1hEc1dKRW1ZbjliYUNRNUpzQitS?= =?utf-8?B?VUFFR3ZxajBzY3JJd2FIQ1loZUVPZ3NTVGRCR1Rvb2NSK1VIMGJZSU5waFYz?= =?utf-8?B?MXFQOFhZczBDZ21HOXVmaVVKTVo5WGtvb2NnaG9BVEY1ektwT0RpNklhNTlJ?= =?utf-8?B?RkJCclh1QWsxeEJyU21ZeDhqMFk1TTZiT0Y3RFFzYy81MmxERnRtcmZoSEJx?= =?utf-8?B?eDdtekFZaGpKcGtqelk1OUFvWTllMW9IWk9qalMzaDMyeWdWNTJCbHhvTzA3?= =?utf-8?B?OXZyYVRNaTBMY0xkSHBYQlp2ek9oZ0htNG5PUDlUVDVaUnAyYW9TR3pHdHlJ?= =?utf-8?B?QlZMUmp4aE5YSXVPYndLenRSNUJSY1d2ZXYvWEYrOGhyWWEwdDBGUEhuNXRP?= =?utf-8?B?TXJydkhMRUV5bmdmVFQ5bG0xT1ZpRWtMa1NObDk4aXQzWUp2RDNIdnlxNGx5?= =?utf-8?B?eEI2RS9wWXh4MmtlRkpQRW8yeEt6WEV4MDk2MExVWW44TzFpL05aL2Q3VHVr?= =?utf-8?B?QmdKRThrZXdLN2dCMnlLMkNBSXQzMFVnZ0JsUGRBK3BsWm9mQVRwcEpvZllK?= =?utf-8?B?Nk1NbmtVTzN0Zm4vbnBHSGIzTGVSUDI0WE9Sc0pUaHBvQnlSalAyVjNqcXJK?= =?utf-8?B?L1NpYTdZaFJZbFlnV0srQ3F0SGlHMEwwd3VLMEFnQ1JMb1dCNU5zbmdEanE4?= =?utf-8?B?NVpJMW5ZdlZEbmdWMUZmSHlYV1JXSklCVFM1cXRLMy9BeDRNMUFZQmxXbUl5?= =?utf-8?B?bDVQNkRzb3NwUmo1K3AwSzVFNzc4SzV0SGFVY0psU2JBOERvYjBSKzVOaDlo?= =?utf-8?B?WktibElxczkvUEltOFFUUjZiVGRxZzVld0Y0K1lqWlRsYTk3cnJmRzRkUGlh?= =?utf-8?B?YjFtd0NEc3lHZ1d0K01hOFZjbXRJeHRYSUt6OThXR0MyTkJDeTdFNWdvQkdO?= =?utf-8?B?VzBjNHowck1tOXhXZHk3Z1lUUjdTK0RERVBsRmZKOTNwV2UraDFuazIrZW8r?= =?utf-8?B?OTlNMmRydjFNTnh1dTMzSGk4ang3K3lDZVZYWUszTStMeVcxME1LditqUUJR?= =?utf-8?B?R0dNc0FLYmh0Z09BZ0NtdGxKNWJnSWtuQVhyTXErK2VlU3JjL09ERTN4c3Za?= =?utf-8?B?WTNQNkpGaXNFVWpkc2lDYUpRa3VvWStVZGVEREhrTjRURDhTWnRqbUFqekI0?= =?utf-8?B?bm9uQVVIVDdsTlNFTEVPZFEzdnUwa2V2SmZjOFhMYjFzUXF2VngrN0I5VEJE?= =?utf-8?B?dk5nd3lOeDFRb21IZ1RwWW9Mbmc1V0xhY0g0R0t5QUZuMFkwa090ajNBUGZI?= =?utf-8?Q?6ezgMczFJs47ofQTsMT6FJHsJ?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: d8a7ecb2-75c7-46f6-e9b0-08dc7a60eb37 X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6124.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 May 2024 13:13:06.3932 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rHLmuNIms05OKwKvU4kzy3LDb+VfhM96ajCvghw/mUPQCP0feguVQsI+x6/woe4DJaAfOl0Hu9afkNri6ClgfQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7011 X-Stat-Signature: 6pys54e7gs9u67e9x5jjqgpe4kz8yg54 X-Rspamd-Queue-Id: 4224D160005 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1716383590-289967 X-HE-Meta: U2FsdGVkX1/r3Wz6q/MVLe9TTPUDknsO+B68RZ6kUs1mpqsmZDdl4Pa16kValSzK+CmJZa4mlAI+mPT4ckweSvjkKRBz53Zs4WIyOnxfhBuX2odlHnSVBJxLYa9XDdfmicsFzVVue30hHjjVeEm2ayzuUXG1VM8210ROOJ52VpJ/Fo2B1JgUy4Uo4KXGHQ8VmOmKap/RH38GdKRHwd03Ri1djagG5e8TfVnmwxCIrwI/IRoqL84ABcgRtRL+PA5M8fPTODc4Z58grj+kzShwPAsE44yIJvcQFiWAliDQab7CkYW+lbB6ivmJrzCLMDUK7Z/pVmimrQG5ZiQ35AkzlSZwYwNW83e7oUY39s0ltDcwtlgW1GQXixQnS84WzDKY52uKwT0MgEovmW/p9u0GaObHIFXUom01q3FjyEEysSIE8gUVTIod17IMHe2MV5R6tdtgYUj+/YeUsWC6EaRhpCC1cAcWwQQ2Y8h1Tt/jt1eusIHeV6/moK2OuHCEUEJOixAyNdL0g1UH3UwCUk5opFcKDyBa5hU+Ey1HtTPdOa9MUdoFkYYgiSTgNJMxXestBUB2lBKOGVIhcQFAMgEaPc28p1lkhLXrg4Hv07vWq1kEKPYVy8La/m+PPClwwjFOmPWjP69zP7jXNqxW1DZDxCHC1LQ29kY7tah25wLoPhE1WP6MHLBqLmEJu8R6Ae6COdXgiYFB2SsmET7EV0Q18xvNPW3Hc3rYyWhfeCj/CGYKUInclwDOyl/7EPiX5JCgttFb5DpR7MwTTYU/75rMJhaVg56TRv/CfqzeiFW+SGsQ99tvRS8D1REftztBeJSLp8mJvOFQvbCO3059/GBgvXRQ70eKiotbSqdOQMCQECP/O9Bi144CpJhoJZrrRSa3Ap1NErBRHLWAgjFcDcLcbKdgAszdUeqPPGklGXv3etHjI7Gi5DYdfcAakfKJAs7u4m3rHkDx8OvVnc+X+HS KKg78fSr G6PNaadQJY7wGF5hdur92GsRYA867CLR8ErtVFSwstdWDgLNhskp8YBwOOZXmYQecV5Y+tfKOntP7riJmfbJGxu7HfzNdDySK+jX3zUNWyRFj8J7RyFuGYR1t4jMFHH6AxoWlIvf+b2kEKa3Rd3oO/qTZ6ub74KNHL0On X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 5/8/2024 6:32 PM, Thomas Gleixner wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > On Tue, May 07 2024 at 15:23, Vignesh Balasubramanian wrote: >> +struct xfeat_component { >> + u32 xfeat_type; >> + u32 xfeat_sz; >> + u32 xfeat_off; >> + u32 xfeat_flags; >> +} __packed; > Why repeating xfeat_ for all member names? > > u32 type; > u32 size; > u32 offset; > u32 flags; > > is sufficient and obvious, no? > >> +enum custom_feature { >> + FEATURE_XSAVE_FP = 0, >> + FEATURE_XSAVE_SSE = 1, >> + FEATURE_XSAVE_YMM = 2, >> + FEATURE_XSAVE_BNDREGS = 3, >> + FEATURE_XSAVE_BNDCSR = 4, >> + FEATURE_XSAVE_OPMASK = 5, >> + FEATURE_XSAVE_ZMM_Hi256 = 6, >> + FEATURE_XSAVE_Hi16_ZMM = 7, >> + FEATURE_XSAVE_PT = 8, >> + FEATURE_XSAVE_PKRU = 9, >> + FEATURE_XSAVE_PASID = 10, >> + FEATURE_XSAVE_CET_USER = 11, >> + FEATURE_XSAVE_CET_SHADOW_STACK = 12, >> + FEATURE_XSAVE_HDC = 13, >> + FEATURE_XSAVE_UINTR = 14, >> + FEATURE_XSAVE_LBR = 15, >> + FEATURE_XSAVE_HWP = 16, >> + FEATURE_XSAVE_XTILE_CFG = 17, >> + FEATURE_XSAVE_XTILE_DATA = 18, >> + FEATURE_MAX, >> + FEATURE_XSAVE_EXTENDED_START = FEATURE_XSAVE_YMM, >> + FEATURE_XSAVE_EXTENDED_END = FEATURE_XSAVE_XTILE_DATA, >> +}; > Why can't this use the existing 'enum xfeature' which is providing > exactly the same information already? First version of patch was similar to what you mentioned here and other review comments to use existing kernel definitions. https://lore.kernel.org/linux-mm/20240314112359.50713-1-vigbalas@amd.com/T/ As per the review comment https://lore.kernel.org/linux-mm/20240314162954.GAZfMmAnYQoRjRbRzc@fat_crate.local/ , modified the patch to be a independent of kernel internal definitions. Though this enum and below function  "get_sub_leaf" are not useful now,  it will be required when we extend for a new/different features. Please let  us know your suggestions. I will fix all other review comments in my next version. >> +#ifdef CONFIG_COREDUMP >> +static int get_sub_leaf(int custom_xfeat) >> +{ >> + switch (custom_xfeat) { >> + case FEATURE_XSAVE_YMM: return XFEATURE_YMM; >> + case FEATURE_XSAVE_BNDREGS: return XFEATURE_BNDREGS; >> + case FEATURE_XSAVE_BNDCSR: return XFEATURE_BNDCSR; >> + case FEATURE_XSAVE_OPMASK: return XFEATURE_OPMASK; >> + case FEATURE_XSAVE_ZMM_Hi256: return XFEATURE_ZMM_Hi256; >> + case FEATURE_XSAVE_Hi16_ZMM: return XFEATURE_Hi16_ZMM; >> + case FEATURE_XSAVE_PT: return XFEATURE_PT_UNIMPLEMENTED_SO_FAR; >> + case FEATURE_XSAVE_PKRU: return XFEATURE_PKRU; >> + case FEATURE_XSAVE_PASID: return XFEATURE_PASID; >> + case FEATURE_XSAVE_CET_USER: return XFEATURE_CET_USER; >> + case FEATURE_XSAVE_CET_SHADOW_STACK: return XFEATURE_CET_KERNEL_UNUSED; >> + case FEATURE_XSAVE_HDC: return XFEATURE_RSRVD_COMP_13; >> + case FEATURE_XSAVE_UINTR: return XFEATURE_RSRVD_COMP_14; >> + case FEATURE_XSAVE_LBR: return XFEATURE_LBR; >> + case FEATURE_XSAVE_HWP: return XFEATURE_RSRVD_COMP_16; >> + case FEATURE_XSAVE_XTILE_CFG: return XFEATURE_XTILE_CFG; >> + case FEATURE_XSAVE_XTILE_DATA: return XFEATURE_XTILE_DATA; >> + default: >> + pr_warn_ratelimited("Not a valid XSAVE Feature."); >> + return 0; >> + } >> +} > This function then maps the identical enums one to one. The only actual > "functionality" is the default case and that's completely pointless. thanks, vigneshbalu.