From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B4BFC282EC for ; Tue, 11 Mar 2025 09:19:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAEEA280002; Tue, 11 Mar 2025 05:19:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B5F4F280001; Tue, 11 Mar 2025 05:19:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D885280002; Tue, 11 Mar 2025 05:19:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7DC0F280001 for ; Tue, 11 Mar 2025 05:19:40 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 09114161C67 for ; Tue, 11 Mar 2025 09:19:42 +0000 (UTC) X-FDA: 83208722604.17.28A8F56 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf07.hostedemail.com (Postfix) with ESMTP id 7C73E40009 for ; Tue, 11 Mar 2025 09:19:39 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bc23iuOx; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741684779; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HYrmKhtPai2LPdacEcsqL3kmpFFiX3Wa+ZrPyUQ9258=; b=2FFGiAX43fyQSpFUfRuaXlEw61FuoqfQnYSku8tO2P/AEvVR0ktKCV162JCAsNThiupdZZ AOMg2z+AbhomQChDrEfdn+AVrcvtRG1EZSQLl2pG5bNzNU0JVPf1DyGUen7tQr4ZJ1UdRf n7JJEtbmZmBZQJaZDZeKN8h853aPVdg= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Bc23iuOx; spf=pass (imf07.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741684779; a=rsa-sha256; cv=none; b=XRoaVBrpM/mMEACBoXl5/BjClp/SEMyJupPJq9CfPfCIo0PIhMFDDFCi4SgOn5gzNXkr8+ UAKUlReOeQtkRU1cyIGAmeXOzXgEAPTct3/uE0uRVBYdCKtA0nGrj+HNSxVetcsVwe/V2q vEV2QTnzW//wnxQrt7PMlexUUJa4FCI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1741684778; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=HYrmKhtPai2LPdacEcsqL3kmpFFiX3Wa+ZrPyUQ9258=; b=Bc23iuOx2FNrqrBvK1rdUZxzKy8qxN+49fTtazw2GVFotlOyntN2uavzO7zUIFv3jUosmX 4BYDaVYKA7AJiefy9OusclyJcaJ+060UdqdNavnLzIhRRcPKEKXCxme7Rn48slfizSqLAb y7/NFPkvQKVcK4T7J/PIddhLF3AWFUk= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-320-kljDsgvIMqeyNL5mVOvtUw-1; Tue, 11 Mar 2025 05:19:35 -0400 X-MC-Unique: kljDsgvIMqeyNL5mVOvtUw-1 X-Mimecast-MFC-AGG-ID: kljDsgvIMqeyNL5mVOvtUw_1741684774 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cf5196c25so11200545e9.0 for ; Tue, 11 Mar 2025 02:19:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741684774; x=1742289574; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=HYrmKhtPai2LPdacEcsqL3kmpFFiX3Wa+ZrPyUQ9258=; b=dMJsWSg6QGnqniwdl0tSBZAm6v3WmGbYxkiywdLobNdUDrzFV+MizWaiFjqnusxGuK sSfDeP7ILoeK/cMlnGFNF1VgaesxCCfplk9Zi7z/mzuwCcQTpNW0Pz8w8n1pC9s3Qo9s 9S5Oa9noMoENcLQbwkB4rDi41lPffaY8l/nSnYPwZWQ3Fo0JALNtYAmai5/vzT+JhR5D uEsPWjDSn4ekdLd3ADEAJ8NCNvzx8ZptJe63yvpUIk8tLyop4kfidzZdBIJ+zmypKRwS PVah/ez4GPX/oQFNZi9YGvic5eLl6JPgXM/E7meXVJYd+zfbZIt65wNQqT5SbVrgWDyy wR1w== X-Gm-Message-State: AOJu0YzBgipp51xXAW5V+5UBkdYUKAXc2nzWXxf4dyO+v87P+8xRZmV2 obcH6s+JJPKittkbg0leVbw9hQV2bSZ5bV9NUnuDXHMGkvQbUEqjTiiWUxlsiRqxeNEJlQIDnbS L64d+QW7LsH9U117dII0icCr+TxKLyhkw4LbWQIiSp+o9S8PH X-Gm-Gg: ASbGncvxwpTPM0Chp0wW/9HhVdhF+c82jVQENe2OSjYr6GCO9C9w1lI3pXvNGTWZYtK fbst239HPCVKdjVqqIjW1GHIckXKy3u/V365hFtVccyWnPuk6QAu5AhhH8FHp0MBIiK5bHkysNb Ri/GJKBwaq5h1reBCxLSIl3uzSkbNhQyO/+vYY7KLWFcjS8A1Dchx+z0Um4qRuVhoSdNOzHkt2Q PPN98C7ruT3RKDiLS10X2IJpkdkKg6rJTUOmitR43ES7iCpD7n+Np794fbm9+hKagVBu+2nCrK/ UkyXvxBHOzsjsJsdgadxE4671AImXYf4plLOzidcEyqh7p7OX5lSPo82RJ5zqvJo9oBq5OWAMoZ oBHz/8omxRHKPAxJISxmJLpTQc1IDVtyHTmRlera8DK8= X-Received: by 2002:a05:600c:470c:b0:43c:f050:fed3 with SMTP id 5b1f17b1804b1-43cf051022dmr92517705e9.11.1741684774357; Tue, 11 Mar 2025 02:19:34 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0Lxs5i27MDjud5TrhD9KawVefCONxScQwN/Kn4gcIWpRE2Eeb/bg06AHrefH2S3zDLbi60g== X-Received: by 2002:a05:600c:470c:b0:43c:f050:fed3 with SMTP id 5b1f17b1804b1-43cf051022dmr92517295e9.11.1741684773950; Tue, 11 Mar 2025 02:19:33 -0700 (PDT) Received: from ?IPV6:2003:cb:c720:ed00:a9b3:5954:823e:3427? (p200300cbc720ed00a9b35954823e3427.dip0.t-ipconnect.de. [2003:cb:c720:ed00:a9b3:5954:823e:3427]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43cf595a771sm71598245e9.36.2025.03.11.02.19.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Mar 2025 02:19:33 -0700 (PDT) Message-ID: <4a068856-328f-48ae-9b1c-0ec7d65dde6b@redhat.com> Date: Tue, 11 Mar 2025 10:19:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests/mm/cow: Fix the incorrect error handling To: Cyan Yang , akpm@linux-foundation.org, shuah@kernel.org Cc: linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250311023730.56658-1-cyan.yang@sifive.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250311023730.56658-1-cyan.yang@sifive.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PflBHP_OyugSnU_3ljLiJGjTKCVzSfW0j8wnCMTx0GE_1741684774 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 7C73E40009 X-Stat-Signature: cuxgc6ik97zya5iy4x1r4syytad5msz9 X-Rspamd-Server: rspam09 X-HE-Tag: 1741684779-602126 X-HE-Meta: U2FsdGVkX19vDqfm7cnYPWfKBB50Au1z0umfdYj3HuQhMvKAvf68HfbGt5YBisptJTNR4ugsqM5ptI5Hqhq1395l3z+LJKLvgstUE7cPbAQlWObODlKaYwasFle8iFaSVyGQygNVv79ATg8ELLGETqpeo9W2Tc4dD9f22MYmA7/XopvJswYkF214iJKjZ4LR6LeCoiYxqEdoIXRxaJVby8U7j9e5p7nSgJvnS8Gx31Ri1DHizVzD3zFdv7K0RD7OHrIDsgaoUFY7i63FrNwU5N0svap7VGKtjVvh3Y6jES+LXL3Tbw1NKATTbPPuuZFeFu4Hbj4qXANSvqf7fH9gLoZEcERYPJp2Lax++/FF6/PUHceEm2kAdMGRW+xGZGy4eaSQtS9Hqt3dqKYsXZfhU4vGvrvJpbRyiRJrE5/MjjY+2ssm88XgDuT6ApiWzpM//qjAjN+zvC9gzSytXhsp259rIuoZuARIQmrqPqYoO+9atobUdcidq+SRm8ma5mxcum2djeFRfuA2m1uGYMod3y2VRPIoVGbnP6vUOaLUbqUfdOmaEE5zrALoFzzs1iIVq5CexlWL+BYtMgb7cM/bGFcNrkrvq3sbbhcJa0RE8SfWtlLPMOSZo+DTHzxDB486gI3c+fZXPGW7zyQ+PCcfQyBaC9RcwMtlaOURkLy2RZjPU3C8w83GCoXTIAyH4BKBc1Qv7p30WJljwsYEHn1BdYmmiyRxThYbNoJJx8/RGxywrNGFnRmyPzqXtx6EAgbLR7wd4rhPph2CYwpOvikRDQzK+xVorVIdAvJC2cNnRgILzKahE+i+zAdSLd5bW+utLd4g37iAp29il5Pqi6OsHLK9aBurskaXr4StXvwgkCD2MnZpEXqTv0eblwQU9UrzXTaOzwPnTBr0XbydAvcFNnjsnNbZPL3iGysB9E9FztFrTzhzV3nuazBB2/tbXxsUNCFRb9E9YipPOxvbbv9 uuOWpquo 9iruGUcyp5BhH+qLGE0DjojSHEsSjyT3dVqUjNQJEZLz5B7udufWyR5aTDrX1N5rbdEm0+ESQvLMojFFpkQdwHLVjjvP0SVEZlPbA7me6qeqgid1b3Rp5MfpUhfl+mS5V2ucFN9L5XPzzJ6pK3PWaWIC3kcWPR/Z+d/U2D0zY8hjq3pkt3bG/JOlLMDu6Ji7hle8e/8/gUV1xdSqjIyT+iQPhHv3XQFmWvbX5PIlQO3OLhEXN+EvqVH9+YHGZ8SSmAV7Xan+AZGsfE2QLtyvA6p2e+LgKOldxj3VpV6ddUTaKh7j0zPHEJcFxgta+BXrLeqtruvNVmlp+p5Xc8yHKtjh0qXXkMnBuT1U5tOu82CbFG0h1RXoDRxv9gvv2mxkk+8iMFJRlBzqM23xal5G3rA8A24kcEpQ8ZIDTS7Kr2Kz3iipQTl0g9J69lrBsRqakQ3kiV7D6URjA1HI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.03.25 03:37, Cyan Yang wrote: > There are two error handlings did not check the correct return value. > This patch will fix them. > > Fixes: f4b5fd6946e244cdedc3bbb9a1f24c8133b2077a ("selftests/vm: anon_cow: THP tests") > Signed-off-by: Cyan Yang > --- > tools/testing/selftests/mm/cow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/mm/cow.c b/tools/testing/selftests/mm/cow.c > index 9446673645eb..16fcadc090a4 100644 > --- a/tools/testing/selftests/mm/cow.c > +++ b/tools/testing/selftests/mm/cow.c > @@ -876,13 +876,13 @@ static void do_run_with_thp(test_fn fn, enum thp_run thp_run, size_t thpsize) > mremap_size = thpsize / 2; > mremap_mem = mmap(NULL, mremap_size, PROT_NONE, > MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); > - if (mem == MAP_FAILED) { > + if (mremap_mem == MAP_FAILED) { > ksft_test_result_fail("mmap() failed\n"); > goto munmap; > } Yes, that check is wrong. > tmp = mremap(mem + mremap_size, mremap_size, mremap_size, > MREMAP_MAYMOVE | MREMAP_FIXED, mremap_mem); > - if (tmp != mremap_mem) { > + if (tmp == MAP_FAILED) { > ksft_test_result_fail("mremap() failed\n"); > goto munmap; > } As Dev says, this one is just fine. Leave it as it is. -- Cheers, David / dhildenb