From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27F5C433FE for ; Tue, 26 Apr 2022 06:47:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62A5D6B0074; Tue, 26 Apr 2022 02:47:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5DA1D6B0075; Tue, 26 Apr 2022 02:47:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C8AB6B0078; Tue, 26 Apr 2022 02:47:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.28]) by kanga.kvack.org (Postfix) with ESMTP id 3CE9D6B0074 for ; Tue, 26 Apr 2022 02:47:58 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1603395D for ; Tue, 26 Apr 2022 06:47:58 +0000 (UTC) X-FDA: 79398100236.30.E474315 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 2922B16003A for ; Tue, 26 Apr 2022 06:47:52 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7A48223A; Mon, 25 Apr 2022 23:47:56 -0700 (PDT) Received: from [192.168.225.134] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E817D3F5A1; Mon, 25 Apr 2022 23:47:53 -0700 (PDT) Message-ID: <4a004118-ff5a-ca2e-e707-5886c41045b5@arm.com> Date: Tue, 26 Apr 2022 12:18:39 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Anshuman Khandual Subject: Re: [PATCH v2] mm/memory-failure.c: skip huge_zero_page in memory_failure() To: =?UTF-8?B?SE9SSUdVQ0hJIE5BT1lBKOWggOWPoyDnm7TkuZ8p?= , Yu Xu Cc: "linux-mm@kvack.org" , Yang Shi , David Hildenbrand , "akpm@linux-foundation.org" , "linmiaohe@huawei.com" , "osalvador@suse.de" References: <497d3835612610e370c74e697ea3c721d1d55b9c.1649775850.git.xuyu@linux.alibaba.com> <8e1a882c-8568-57f2-216a-703f220e0e3f@linux.alibaba.com> <20220425141649.GB3767079@hori.linux.bs1.fc.nec.co.jp> Content-Language: en-US In-Reply-To: <20220425141649.GB3767079@hori.linux.bs1.fc.nec.co.jp> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: r1sasw6pmuqquj6bw1adaerth4xbg7hr X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 2922B16003A Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com X-Rspam-User: X-HE-Tag: 1650955672-866774 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/25/22 19:46, HORIGUCHI NAOYA(堀口 直也) wrote: > On Sat, Apr 23, 2022 at 11:16:20AM +0800, Yu Xu wrote: >> For this patch v2, >> >> Yang, David, Anshuman and Naoya all agree to fix the bug in >> split_huge_page_to_list(), i.e., to replace the BUG to >> WARN + returning -EBUSY for huge_zero_page. >> >> However, this patch v2 has just been merged into linux mainline. >> Sorry for that I didn't hurry up. >> >> So now, should we continue sending v3, or should we end this >> thread, and start a successive patch for optimization? > > No problem, you can start a new thread for additional patches. > Maybe it's better to have separate patches (starting with one > reverting v2 and then one doing v3). May be also pull in the following patch which adds MF_MSG_HUGE_ZERO in the same series ? https://lore.kernel.org/linux-mm/20220425080306.1771480-1-anshuman.khandual@arm.com/