Re: + memcg-rename-config-variables.patch added to -mm tree

Re: + memcg-rename-config-variables.patch added to -mm tree

[Johannes Weiner]

On Tue, Jun 26, 2012 at 12:21:07PM -0700, akpm@linux-foundation.org wrote:
> 
> The patch titled
>      Subject: memcg: rename config variables
> has been added to the -mm tree.  Its filename is
>      memcg-rename-config-variables.patch
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> 
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@linux-foundation.org>
> Subject: memcg: rename config variables
> 
> Sanity:
> 
> CONFIG_CGROUP_MEM_RES_CTLR -> CONFIG_MEMCG
> CONFIG_CGROUP_MEM_RES_CTLR_SWAP -> CONFIG_MEMCG_SWAP
> CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED -> CONFIG_MEMCG_SWAP_ENABLED
> CONFIG_CGROUP_MEM_RES_CTLR_KMEM -> CONFIG_MEMCG_KMEM

Yes!  Thank you.

When would be the best time to fix the function/variable namespace? :)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: + memcg-rename-config-variables.patch added to -mm tree

[Glauber Costa]

On 06/26/2012 11:56 PM, Johannes Weiner wrote:
> On Tue, Jun 26, 2012 at 12:21:07PM -0700, akpm@linux-foundation.org wrote:
>>
>> The patch titled
>>      Subject: memcg: rename config variables
>> has been added to the -mm tree.  Its filename is
>>      memcg-rename-config-variables.patch
>>
>> Before you just go and hit "reply", please:
>>    a) Consider who else should be cc'ed
>>    b) Prefer to cc a suitable mailing list as well
>>    c) Ideally: find the original patch on the mailing list and do a
>>       reply-to-all to that, adding suitable additional cc's
>>
>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>>
>> The -mm tree is included into linux-next and is updated
>> there every 3-4 working days
>>
>> ------------------------------------------------------
>> From: Andrew Morton <akpm@linux-foundation.org>
>> Subject: memcg: rename config variables
>>
>> Sanity:
>>
>> CONFIG_CGROUP_MEM_RES_CTLR -> CONFIG_MEMCG
>> CONFIG_CGROUP_MEM_RES_CTLR_SWAP -> CONFIG_MEMCG_SWAP
>> CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED -> CONFIG_MEMCG_SWAP_ENABLED
>> CONFIG_CGROUP_MEM_RES_CTLR_KMEM -> CONFIG_MEMCG_KMEM
> 
> Yes!  Thank you.
> 
> When would be the best time to fix the function/variable namespace? :)
> 
Andrew,

This patch forgets to convert some users, and my build breaks.

In particular, the ones in include/net/sock.h are not converted.
There may be others as well, my build break log is quite extensive =p

Just to be clear, I am perfectly happy with the change, just it needs to
be fixed.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: + memcg-rename-config-variables.patch added to -mm tree

[Michal Hocko]

On Wed 27-06-12 16:02:05, Glauber Costa wrote:
> On 06/26/2012 11:56 PM, Johannes Weiner wrote:
> > On Tue, Jun 26, 2012 at 12:21:07PM -0700, akpm@linux-foundation.org wrote:
> >>
> >> The patch titled
> >>      Subject: memcg: rename config variables
> >> has been added to the -mm tree.  Its filename is
> >>      memcg-rename-config-variables.patch
> >>
> >> Before you just go and hit "reply", please:
> >>    a) Consider who else should be cc'ed
> >>    b) Prefer to cc a suitable mailing list as well
> >>    c) Ideally: find the original patch on the mailing list and do a
> >>       reply-to-all to that, adding suitable additional cc's
> >>
> >> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> >>
> >> The -mm tree is included into linux-next and is updated
> >> there every 3-4 working days
> >>
> >> ------------------------------------------------------
> >> From: Andrew Morton <akpm@linux-foundation.org>
> >> Subject: memcg: rename config variables
> >>
> >> Sanity:
> >>
> >> CONFIG_CGROUP_MEM_RES_CTLR -> CONFIG_MEMCG
> >> CONFIG_CGROUP_MEM_RES_CTLR_SWAP -> CONFIG_MEMCG_SWAP
> >> CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED -> CONFIG_MEMCG_SWAP_ENABLED
> >> CONFIG_CGROUP_MEM_RES_CTLR_KMEM -> CONFIG_MEMCG_KMEM
> > 
> > Yes!  Thank you.
> > 
> > When would be the best time to fix the function/variable namespace? :)
> > 
> Andrew,
> 
> This patch forgets to convert some users, and my build breaks.
> 
> In particular, the ones in include/net/sock.h are not converted.
> There may be others as well, my build break log is quite extensive =p

I have already sent the missing parts as a follow up email.
-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

Re: + memcg-rename-config-variables.patch added to -mm tree

[Glauber Costa]

On 06/27/2012 04:20 PM, Michal Hocko wrote:
> On Wed 27-06-12 16:02:05, Glauber Costa wrote:
>> On 06/26/2012 11:56 PM, Johannes Weiner wrote:
>>> On Tue, Jun 26, 2012 at 12:21:07PM -0700, akpm@linux-foundation.org wrote:
>>>>
>>>> The patch titled
>>>>      Subject: memcg: rename config variables
>>>> has been added to the -mm tree.  Its filename is
>>>>      memcg-rename-config-variables.patch
>>>>
>>>> Before you just go and hit "reply", please:
>>>>    a) Consider who else should be cc'ed
>>>>    b) Prefer to cc a suitable mailing list as well
>>>>    c) Ideally: find the original patch on the mailing list and do a
>>>>       reply-to-all to that, adding suitable additional cc's
>>>>
>>>> *** Remember to use Documentation/SubmitChecklist when testing your code ***
>>>>
>>>> The -mm tree is included into linux-next and is updated
>>>> there every 3-4 working days
>>>>
>>>> ------------------------------------------------------
>>>> From: Andrew Morton <akpm@linux-foundation.org>
>>>> Subject: memcg: rename config variables
>>>>
>>>> Sanity:
>>>>
>>>> CONFIG_CGROUP_MEM_RES_CTLR -> CONFIG_MEMCG
>>>> CONFIG_CGROUP_MEM_RES_CTLR_SWAP -> CONFIG_MEMCG_SWAP
>>>> CONFIG_CGROUP_MEM_RES_CTLR_SWAP_ENABLED -> CONFIG_MEMCG_SWAP_ENABLED
>>>> CONFIG_CGROUP_MEM_RES_CTLR_KMEM -> CONFIG_MEMCG_KMEM
>>>
>>> Yes!  Thank you.
>>>
>>> When would be the best time to fix the function/variable namespace? :)
>>>
>> Andrew,
>>
>> This patch forgets to convert some users, and my build breaks.
>>
>> In particular, the ones in include/net/sock.h are not converted.
>> There may be others as well, my build break log is quite extensive =p
> 
> I have already sent the missing parts as a follow up email.
> 
Oops, I somehow missed it in my mailbox - or it is delayed.
I've just done the same.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>