From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-acpi@vger.kernel.org
Cc: len.brown@intel.com, benh@kernel.crashing.org, paulus@samba.org,
cl@linux.com, minchan.kim@gmail.com, akpm@linux-foundation.org,
kosaki.motohiro@jp.fujitsu.com, wency@cn.fujitsu.com
Subject: [RFC PATCH 11/12] memory-hotplug : add node_device_release
Date: Wed, 27 Jun 2012 14:57:54 +0900 [thread overview]
Message-ID: <4FEAA0E2.2080003@jp.fujitsu.com> (raw)
In-Reply-To: <4FEA9C88.1070800@jp.fujitsu.com>
When calling unregister_node(), the function shows following message at
device_release().
Device 'node2' does not have a release() function, it is broken and must be fixed.
So the patch implements node_device_release()
CC: Len Brown <len.brown@intel.com>
CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Christoph Lameter <cl@linux.com>
Cc: Minchan Kim <minchan.kim@gmail.com>
CC: Andrew Morton <akpm@linux-foundation.org>
CC: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Index: linux-3.5-rc1/drivers/base/node.c
===================================================================
--- linux-3.5-rc1.orig/drivers/base/node.c 2012-06-14 09:09:53.000000000 +0900
+++ linux-3.5-rc1/drivers/base/node.c 2012-06-25 18:40:45.810261969 +0900
@@ -252,6 +252,12 @@ static inline void hugetlb_register_node
static inline void hugetlb_unregister_node(struct node *node) {}
#endif
+static void node_device_release(struct device *dev)
+{
+ struct node *node_dev = to_node(dev);
+
+ memset(node_dev, 0, sizeof(struct node));
+}
/*
* register_node - Setup a sysfs device for a node.
@@ -265,6 +271,7 @@ int register_node(struct node *node, int
node->dev.id = num;
node->dev.bus = &node_subsys;
+ node->dev.release = node_device_release;
error = device_register(&node->dev);
if (!error){
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-27 5:58 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 5:39 [RFC PATCH 0/12] memory-hotplug : hot-remove physical memory Yasuaki Ishimatsu
2012-06-27 5:42 ` [RFC PATCH 1/12] memory-hotplug : rename remove_memory to offline_memory Yasuaki Ishimatsu
2012-06-27 6:10 ` David Rientjes
2012-06-27 7:14 ` Wen Congyang
2012-06-27 8:47 ` Wen Congyang
2012-06-28 3:01 ` Yasuaki Ishimatsu
2012-06-28 3:25 ` Wen Congyang
2012-06-28 4:50 ` Yasuaki Ishimatsu
2012-06-27 5:44 ` [RFC PATCH 2/12] memory-hogplug : check memory offline in offline_pages Yasuaki Ishimatsu
2012-06-27 6:16 ` David Rientjes
2012-06-28 7:01 ` Yasuaki Ishimatsu
2012-06-27 8:49 ` Wen Congyang
2012-06-28 5:06 ` Yasuaki Ishimatsu
2012-06-28 5:27 ` KOSAKI Motohiro
2012-06-28 6:01 ` Yasuaki Ishimatsu
2012-06-28 5:26 ` KOSAKI Motohiro
2012-06-28 6:51 ` Yasuaki Ishimatsu
2012-06-30 15:46 ` Jiang Liu
2012-07-02 2:53 ` Yasuaki Ishimatsu
2012-06-30 15:51 ` Jiang Liu
2012-07-02 2:56 ` Yasuaki Ishimatsu
2012-06-27 5:45 ` [RFC PATCH 3/12] memory-hotplug : add physical memory hotplug code to acpi_memory_device_remove Yasuaki Ishimatsu
2012-06-27 5:47 ` [RFC PATCH 4/12] memory-hotplug : remove /sys/firmware/memmap/X sysfs Yasuaki Ishimatsu
2012-06-28 6:32 ` Wen Congyang
2012-06-28 8:07 ` Yasuaki Ishimatsu
2012-06-28 8:38 ` Wen Congyang
2012-06-29 3:09 ` Yasuaki Ishimatsu
2012-06-27 5:48 ` [RFC PATCH 5/12] memory-hotplug : does not release memory region in PAGES_PER_SECTION chunks Yasuaki Ishimatsu
2012-06-27 5:52 ` [RFC PATCH 6/12] memory-hotplug : remove_memory calls __remove_pages Yasuaki Ishimatsu
2012-06-27 5:53 ` [RFC PATCH 7/12] memory-hotplug : check page type in get_page_bootmem Yasuaki Ishimatsu
2012-06-27 5:54 ` [RFC PATCH 8/12] memory-hotplug : move register_page_bootmem_info_node and put_page_bootmem for sparse-vmemmap Yasuaki Ishimatsu
2012-06-27 5:55 ` [RFC PATCH 9/12] memory-hotplug : implement register_page_bootmem_info_section of sparse-vmemmap Yasuaki Ishimatsu
2012-06-27 5:56 ` [RFC PATCH 10/12] memory-hotplug : free memmap " Yasuaki Ishimatsu
2012-06-30 15:58 ` Jiang Liu
2012-07-02 3:01 ` Yasuaki Ishimatsu
2012-06-27 5:57 ` Yasuaki Ishimatsu [this message]
2012-06-27 5:59 ` [RFC PATCH 12/12] memory-hotplug : remove sysfs file of node Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEAA0E2.2080003@jp.fujitsu.com \
--to=isimatu.yasuaki@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=cl@linux.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=minchan.kim@gmail.com \
--cc=paulus@samba.org \
--cc=wency@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox