From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx142.postini.com [74.125.245.142]) by kanga.kvack.org (Postfix) with SMTP id 8E01C6B0069 for ; Tue, 12 Jun 2012 04:37:26 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail6.fujitsu.co.jp (Postfix) with ESMTP id C28113EE0C0 for ; Tue, 12 Jun 2012 17:37:24 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id A719045DEB9 for ; Tue, 12 Jun 2012 17:37:24 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 8021C45DEB3 for ; Tue, 12 Jun 2012 17:37:24 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 718D91DB8044 for ; Tue, 12 Jun 2012 17:37:24 +0900 (JST) Received: from ml14.s.css.fujitsu.com (ml14.s.css.fujitsu.com [10.240.81.134]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 126A11DB803B for ; Tue, 12 Jun 2012 17:37:24 +0900 (JST) Message-ID: <4FD6FF47.8080200@jp.fujitsu.com> Date: Tue, 12 Jun 2012 17:35:19 +0900 From: Kamezawa Hiroyuki MIME-Version: 1.0 Subject: Re: [PATCH -V8 13/16] hugetlb/cgroup: add hugetlb cgroup control files References: <1339232401-14392-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1339232401-14392-14-git-send-email-aneesh.kumar@linux.vnet.ibm.com> In-Reply-To: <1339232401-14392-14-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, dhillf@gmail.com, rientjes@google.com, mhocko@suse.cz, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org (2012/06/09 17:59), Aneesh Kumar K.V wrote: > From: "Aneesh Kumar K.V" > > Add the control files for hugetlb controller > > Signed-off-by: Aneesh Kumar K.V > --- > include/linux/hugetlb.h | 5 ++ > include/linux/hugetlb_cgroup.h | 6 ++ > mm/hugetlb.c | 8 +++ > mm/hugetlb_cgroup.c | 130 ++++++++++++++++++++++++++++++++++++++++ > 4 files changed, 149 insertions(+) > > diff --git a/include/linux/hugetlb.h b/include/linux/hugetlb.h > index 4aca057..9650bb1 100644 > --- a/include/linux/hugetlb.h > +++ b/include/linux/hugetlb.h > @@ -4,6 +4,7 @@ > #include > #include > #include > +#include > > struct ctl_table; > struct user_struct; > @@ -221,6 +222,10 @@ struct hstate { > unsigned int nr_huge_pages_node[MAX_NUMNODES]; > unsigned int free_huge_pages_node[MAX_NUMNODES]; > unsigned int surplus_huge_pages_node[MAX_NUMNODES]; > +#ifdef CONFIG_CGROUP_HUGETLB_RES_CTLR > + /* cgroup control files */ > + struct cftype cgroup_files[5]; > +#endif > char name[HSTATE_NAME_LEN]; > }; > > diff --git a/include/linux/hugetlb_cgroup.h b/include/linux/hugetlb_cgroup.h > index ceff1d5..ba4836f 100644 > --- a/include/linux/hugetlb_cgroup.h > +++ b/include/linux/hugetlb_cgroup.h > @@ -62,6 +62,7 @@ extern void hugetlb_cgroup_uncharge_page(int idx, unsigned long nr_pages, > struct page *page); > extern void hugetlb_cgroup_uncharge_cgroup(int idx, unsigned long nr_pages, > struct hugetlb_cgroup *h_cg); > +extern int hugetlb_cgroup_file_init(int idx) __init; > #else > static inline struct hugetlb_cgroup *hugetlb_cgroup_from_page(struct page *page) > { > @@ -106,5 +107,10 @@ hugetlb_cgroup_uncharge_cgroup(int idx, unsigned long nr_pages, > { > return; > } > + > +static inline int __init hugetlb_cgroup_file_init(int idx) > +{ > + return 0; > +} > #endif /* CONFIG_MEM_RES_CTLR_HUGETLB */ > #endif > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 1ca2d8f..bf79131 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -30,6 +30,7 @@ > #include > #include > #include > +#include > #include "internal.h" > > const unsigned long hugetlb_zero = 0, hugetlb_infinity = ~0UL; > @@ -1916,6 +1917,13 @@ void __init hugetlb_add_hstate(unsigned order) > h->next_nid_to_free = first_node(node_states[N_HIGH_MEMORY]); > snprintf(h->name, HSTATE_NAME_LEN, "hugepages-%lukB", > huge_page_size(h)/1024); > + /* > + * Add cgroup control files only if the huge page consists > + * of more than two normal pages. This is because we use > + * page[2].lru.next for storing cgoup details. > + */ > + if (order>= 2) > + hugetlb_cgroup_file_init(hugetlb_max_hstate - 1); > What happens at hugetlb module exit ? please see hugetlb_exit(). BTW, module unload of hugetlbfs is restricted if hugetlb cgroup is mounted ?? Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org