linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Minchan Kim <minchan@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: dan.magenheimer@oracle.com, konrad.wilk@oracle.com,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 09/10] mm: frontswap: split out function to clear a page out
Date: Mon, 11 Jun 2012 15:16:08 +0900	[thread overview]
Message-ID: <4FD58D28.2030808@kernel.org> (raw)
In-Reply-To: <1339325468-30614-10-git-send-email-levinsasha928@gmail.com>

On 06/10/2012 07:51 PM, Sasha Levin wrote:

> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
>  mm/frontswap.c |   15 +++++++++------
>  1 files changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/mm/frontswap.c b/mm/frontswap.c
> index 7da55a3..c056f6e 100644
> --- a/mm/frontswap.c
> +++ b/mm/frontswap.c
> @@ -120,6 +120,12 @@ void __frontswap_init(unsigned type)
>  }
>  EXPORT_SYMBOL(__frontswap_init);
>  
> +static inline void __frontswap_clear(struct swap_info_struct *sis, pgoff_t offset)
> +{
> +	frontswap_clear(sis, offset);
> +	atomic_dec(&sis->frontswap_pages);
> +}


Nipick:
Strange, Normally, NOT underscore function calls underscore function.
But this is opposite. :(

-- 
Kind regards,
Minchan Kim

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2012-06-11  6:16 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-10 10:50 [PATCH v3 00/10] minor frontswap cleanups and tracing support Sasha Levin
2012-06-10 10:50 ` [PATCH v3 01/10] mm: frontswap: remove casting from function calls through ops structure Sasha Levin
2012-06-11  5:20   ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 02/10] mm: frontswap: trivial coding convention issues Sasha Levin
2012-06-11  5:24   ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 03/10] mm: frontswap: split out __frontswap_curr_pages Sasha Levin
2012-06-11  5:28   ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 04/10] mm: frontswap: split out __frontswap_unuse_pages Sasha Levin
2012-06-11  5:43   ` Minchan Kim
2012-06-11 10:30     ` Sasha Levin
2012-06-11 14:27       ` Dan Magenheimer
2012-06-11 14:31         ` Konrad Rzeszutek Wilk
2012-06-11 14:38           ` Sasha Levin
2012-06-10 10:51 ` [PATCH v3 05/10] mm: frontswap: split frontswap_shrink further to simplify locking Sasha Levin
2012-06-11  5:49   ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 06/10] mm: frontswap: make all branches of if statement in put page consistent Sasha Levin
2012-06-11  5:52   ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 07/10] mm: frontswap: remove unnecessary check during initialization Sasha Levin
2012-06-11  5:54   ` Minchan Kim
2012-06-10 10:51 ` [PATCH v3 08/10] mm: frontswap: add tracing support Sasha Levin
2012-06-11  6:12   ` Minchan Kim
2012-06-11  8:33     ` Pekka Enberg
2012-06-11 10:39       ` Sasha Levin
2012-06-10 10:51 ` [PATCH v3 09/10] mm: frontswap: split out function to clear a page out Sasha Levin
2012-06-11  6:16   ` Minchan Kim [this message]
2012-06-10 10:51 ` [PATCH v3 10/10] mm: frontswap: remove unneeded headers Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FD58D28.2030808@kernel.org \
    --to=minchan@kernel.org \
    --cc=dan.magenheimer@oracle.com \
    --cc=konrad.wilk@oracle.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox