From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx120.postini.com [74.125.245.120]) by kanga.kvack.org (Postfix) with SMTP id 3F89F6B0069 for ; Thu, 31 May 2012 03:58:10 -0400 (EDT) Message-ID: <4FC724B1.70508@cn.fujitsu.com> Date: Thu, 31 May 2012 15:58:41 +0800 From: Gao feng MIME-Version: 1.0 Subject: Re: [PATCH] meminfo: show /proc/meminfo base on container's memcg References: <1338260214-21919-1-git-send-email-gaofeng@cn.fujitsu.com> <4FC6B68C.2070703@jp.fujitsu.com> <4FC6BC3E.5010807@jp.fujitsu.com> <4FC6C111.2060108@jp.fujitsu.com> <4FC6D881.4090706@jp.fujitsu.com> <4FC70355.70805@jp.fujitsu.com> <4FC70E5E.1010003@gmail.com> <4FC711A5.4090003@gmail.com> <4FC720EE.3010307@gmail.com> In-Reply-To: <4FC720EE.3010307@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: KOSAKI Motohiro Cc: David Rientjes , Kamezawa Hiroyuki , hannes@cmpxchg.org, mhocko@suse.cz, bsingharora@gmail.com, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, containers@lists.linux-foundation.org =E4=BA=8E 2012=E5=B9=B405=E6=9C=8831=E6=97=A5 15:42, KOSAKI Motohiro =E5=86= =99=E9=81=93: > (5/31/12 3:35 AM), David Rientjes wrote: >> On Thu, 31 May 2012, KOSAKI Motohiro wrote: >> >>>> As I said, LXC and namespace isolation is a tangent to the discussion = of >>>> faking the /proc/meminfo for the memcg context of a thread. >>> >>> Because of, /proc/meminfo affect a lot of libraries behavior. So, it's = not only >>> application issue. If you can't rewrite =5Fall=5F of userland assets, f= ake meminfo >>> can't be escaped. Again see alternative container implementation. >>> >> >> It's a tangent because it isn't a complete psuedo /proc/meminfo for all >> threads attached to a memcg regardless of any namespace isolation; the L= XC >> solution has existed for a couple of years by its procfs patchset that >> overlaps procfs with fuse and can suppress or modify any output in the >> context of a memory controller using things like >> memory.{limit,usage}=5Fin=5Fbytes. I'm sure all other fields could be >> modified if outputted in some structured way via memcg; it looks like >> memory.stat would need to be extended to provide that. If that's mounted >> prior to executing the application, then your isolation is achieved and >> all libraries should see the new output that you've defined in LXC. >> >> However, this seems like a seperate topic than the patch at hand which >> does this directly to /proc/meminfo based on a thread's memcg context, >> that's the part that I'm nacking. >=20 > Then, I NAKed current patch too. Yeah, current one is ugly. It assume =5F= all=5F > user need namespace isolation and it clearly is not. >=20 >=20 >> I'd recommend to Gao to expose this >> information via memory.stat and then use fuse and the procfs lxc support >> as your way of contextualizing the resources. >=20 > It's one of a option. But, I seriously doubt fuse can make simpler than k= amezawa-san's > idea. But yeah, I might NACK kamezawa-san's one if he will post ugly patc= h. >=20 It seams I should do some homework to make the implement beautifully. I think kamezawa-san's idea is more simpler. thanks for your advice. >=20 > --=20 > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >=20 = -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org