From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx204.postini.com [74.125.245.204]) by kanga.kvack.org (Postfix) with SMTP id BB2A96B0083 for ; Thu, 24 May 2012 08:08:31 -0400 (EDT) Message-ID: <4FBE243F.3080002@parallels.com> Date: Thu, 24 May 2012 16:06:23 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH] slab+slob: dup name string References: <4FBBAE95.6080608@parallels.com> <1337773595.3013.15.camel@dabdike.int.hansenpartnership.com> <4FBCD328.6060406@parallels.com> <1337775878.3013.16.camel@dabdike.int.hansenpartnership.com> <4FBCF951.3040105@parallels.com> <20120524001831.GQ25351@dastard> In-Reply-To: <20120524001831.GQ25351@dastard> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Dave Chinner Cc: Christoph Lameter , James Bottomley , David Rientjes , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Pekka Enberg On 05/24/2012 04:18 AM, Dave Chinner wrote: >> Of course reasoning about why it was added helps (so let's try to >> > determine that), but so far the only reasonably strong argument in >> > favor of keeping it was robustness. > I'm pretty sure it was added because there are slab names > constructed by snprintf on a stack buffer, so the name doesn't exist > beyond the slab initialisation function call... > > Cheers, > > Dave. If that was the reason, we'd be seeing slab failing miserably where slub succeeds, since slab keeps no copy. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org