From: Glauber Costa <glommer@parallels.com>
To: Christoph Lameter <cl@linux.com>
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
linux-mm@kvack.org, Pekka Enberg <penberg@cs.helsinki.fi>,
David Rientjes <rientjes@google.com>
Subject: Re: [PATCH v2] slab+slob: dup name string
Date: Tue, 22 May 2012 19:27:21 +0400 [thread overview]
Message-ID: <4FBBB059.1060903@parallels.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205220857380.17600@router.home>
On 05/22/2012 05:58 PM, Christoph Lameter wrote:
> On Tue, 22 May 2012, Glauber Costa wrote:
>
>> [ v2: Also dup string for early caches, requested by David Rientjes ]
>
> kstrdups that early could cause additional issues. Its better to leave
> things as they were.
>
For me is really all the same. But note that before those kstrdups, we
do a bunch of kmallocs as well already. (ex:
/* 4) Replace the bootstrap head arrays */
{
struct array_cache *ptr;
ptr = kmalloc(sizeof(struct arraycache_init), GFP_NOWAIT);
Which other point of issues do you see besides the memory allocation
done by strdup?
I agree with your comment that we shouldn't worry about those caches,
because only init code uses it.
Weather or not David's concern of wanting to delete those caches some
day is valid, I'll leave up to you guys to decide
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-05-22 15:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 9:51 Glauber Costa
2012-05-22 13:58 ` Christoph Lameter
2012-05-22 15:27 ` Glauber Costa [this message]
2012-05-22 17:18 ` Christoph Lameter
2012-05-23 3:55 ` David Rientjes
2012-05-23 9:25 ` Glauber Costa
2012-05-23 13:53 ` Christoph Lameter
2012-05-24 1:01 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FBBB059.1060903@parallels.com \
--to=glommer@parallels.com \
--cc=cgroups@vger.kernel.org \
--cc=cl@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@cs.helsinki.fi \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox