From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx102.postini.com [74.125.245.102]) by kanga.kvack.org (Postfix) with SMTP id 7916D6B00EB for ; Tue, 22 May 2012 11:21:53 -0400 (EDT) Message-ID: <4FBBAE95.6080608@parallels.com> Date: Tue, 22 May 2012 19:19:49 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH] slab+slob: dup name string References: <1337613539-29108-1-git-send-email-glommer@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: David Rientjes , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Pekka Enberg On 05/22/2012 05:56 PM, Christoph Lameter wrote: > On Mon, 21 May 2012, David Rientjes wrote: > >> This doesn't work if you kmem_cache_destroy() a cache that was created >> when g_cpucache_cpu<= EARLY, the kfree() will explode. That never >> happens for any existing cache created in kmem_cache_init(), but this >> would introduce the first roadblock in doing so. So you'll need some >> magic to determine whether the cache was allocated statically and suppress >> the kfree() in such a case. > > Nope. Only slab management caches will be created that early. The patch is > fine as is. > > I think that's precisely David's point: that we might want to destroy them eventually. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org