From: Chris Metcalf <cmetcalf@tilera.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Hillf Danton <dhillf@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Michal Hocko <mhocko@suse.cz>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v2] hugetlb: fix race condition in hugetlb_fault()
Date: Fri, 6 Apr 2012 20:25:54 -0400 [thread overview]
Message-ID: <4F7F8992.4050004@tilera.com> (raw)
In-Reply-To: <alpine.LSU.2.00.1204061631160.3820@eggly.anvils>
On 4/6/2012 7:35 PM, Hugh Dickins wrote:
> On Fri, 6 Apr 2012, Andrew Morton wrote:
>> On Fri, 6 Apr 2012 16:10:13 -0700 (PDT)
>> Hugh Dickins <hughd@google.com> wrote:
>>> The resulting patch is okay; but let's reassure Chris that his
>>> original patch was better, before he conceded to make the get_page
>>> and put_page unconditional, and added unnecessary detail of the race.
>>>
>> Yes, the v1 patch was better. No reason was given for changing it?
> I think Chris was aiming to be a model citizen, and followed review
> suggestions that he would actually have done better to resist.
Yes, exactly. I figure if I'm submitting patches to mm, I should defer to
suggestions from someone like Hillf who has committed a lot more of them
than I have. :-) Arguably the unconditional version is simpler at the
source code level in any case, and I figure more is usually better when it
comes to documenting race conditions, so it didn't seem necessary to push
back. Frankly I'm happy to keep my sign-off on either version of the patch
and defer to Andrew or whomever as to which one gets taken.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-04-07 0:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-01 16:51 Chris Metcalf
2012-03-30 20:07 ` [PATCH] " Chris Metcalf
2012-03-30 20:07 ` [PATCH v2] " Chris Metcalf
2012-04-01 12:10 ` Hillf Danton
2012-03-30 20:07 ` [PATCH v3] " Chris Metcalf
2012-03-31 12:27 ` [PATCH] " Hillf Danton
2012-03-30 19:37 ` [PATCH v2] arch/tile: support multiple huge page sizes dynamically Chris Metcalf
2012-03-31 14:03 ` Hillf Danton
2012-03-30 19:37 ` [PATCH v3] " Chris Metcalf
2012-04-01 12:33 ` Hillf Danton
2012-04-01 16:46 ` Chris Metcalf
2012-04-02 2:21 ` Hillf Danton
2012-04-06 22:23 ` [PATCH v2] hugetlb: fix race condition in hugetlb_fault() Andrew Morton
2012-04-06 23:10 ` Hugh Dickins
2012-04-06 23:26 ` Andrew Morton
2012-04-06 23:35 ` Hugh Dickins
2012-04-07 0:25 ` Chris Metcalf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F7F8992.4050004@tilera.com \
--to=cmetcalf@tilera.com \
--cc=akpm@linux-foundation.org \
--cc=dhillf@gmail.com \
--cc=hughd@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox