From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
"cgroups@vger.kernel.org" <cgroups@vger.kernel.org>,
Hugh Dickins <hughd@google.com>,
"n-horiguchi@ah.jp.nec.com" <n-horiguchi@ah.jp.nec.com>,
Michal Hocko <mhocko@suse.cz>,
Glauber Costa <glommer@parallels.com>
Subject: Re: [PATCH] memcg: change behavior of moving charges at task move
Date: Fri, 23 Mar 2012 18:00:34 +0900 [thread overview]
Message-ID: <4F6C3BB2.6090108@jp.fujitsu.com> (raw)
In-Reply-To: <20120323085301.GA1739@cmpxchg.org>
(2012/03/23 17:53), Johannes Weiner wrote:
> On Fri, Mar 23, 2012 at 09:52:28AM +0900, KAMEZAWA Hiroyuki wrote:
>> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
>> index b2ee6df..ca8b3a1 100644
>> --- a/mm/memcontrol.c
>> +++ b/mm/memcontrol.c
>> @@ -5147,7 +5147,7 @@ static struct page *mc_handle_present_pte(struct vm_area_struct *vma,
>> return NULL;
>> if (PageAnon(page)) {
>> /* we don't move shared anon */
>> - if (!move_anon() || page_mapcount(page) > 2)
>> + if (!move_anon())
>> return NULL;
>> } else if (!move_file())
>> /* we ignore mapcount for file pages */
>> @@ -5158,26 +5158,32 @@ static struct page *mc_handle_present_pte(struct vm_area_struct *vma,
>> return page;
>> }
>>
>> +#ifdef CONFFIG_SWAP
>
> That will probably disable it for good :)
>
Thank you for your good eyes.. I feel I can't trust my eyes ;(
==
next prev parent reply other threads:[~2012-03-23 9:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-21 9:52 KAMEZAWA Hiroyuki
2012-03-22 15:17 ` Naoya Horiguchi
2012-03-22 21:29 ` Andrew Morton
2012-03-23 0:05 ` KAMEZAWA Hiroyuki
2012-03-22 21:36 ` Andrew Morton
2012-03-23 0:18 ` KAMEZAWA Hiroyuki
2012-03-23 0:30 ` Andrew Morton
2012-03-23 0:52 ` KAMEZAWA Hiroyuki
2012-03-23 8:53 ` Johannes Weiner
2012-03-23 9:00 ` KAMEZAWA Hiroyuki [this message]
2012-03-23 9:45 ` Michal Hocko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F6C3BB2.6090108@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.cz \
--cc=n-horiguchi@ah.jp.nec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox