From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx174.postini.com [74.125.245.174]) by kanga.kvack.org (Postfix) with SMTP id 9BC0D6B0083 for ; Mon, 19 Mar 2012 03:02:51 -0400 (EDT) Received: from m3.gw.fujitsu.co.jp (unknown [10.0.50.73]) by fgwmail5.fujitsu.co.jp (Postfix) with ESMTP id AAFEE3EE0BD for ; Mon, 19 Mar 2012 16:02:49 +0900 (JST) Received: from smail (m3 [127.0.0.1]) by outgoing.m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 8E9E345DEC1 for ; Mon, 19 Mar 2012 16:02:49 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (s3.gw.fujitsu.co.jp [10.0.50.93]) by m3.gw.fujitsu.co.jp (Postfix) with ESMTP id 7369E45DEB8 for ; Mon, 19 Mar 2012 16:02:49 +0900 (JST) Received: from s3.gw.fujitsu.co.jp (localhost.localdomain [127.0.0.1]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 5D8E31DB8047 for ; Mon, 19 Mar 2012 16:02:49 +0900 (JST) Received: from m107.s.css.fujitsu.com (m107.s.css.fujitsu.com [10.240.81.147]) by s3.gw.fujitsu.co.jp (Postfix) with ESMTP id 0520D1DB8044 for ; Mon, 19 Mar 2012 16:02:49 +0900 (JST) Message-ID: <4F66D993.2080100@jp.fujitsu.com> Date: Mon, 19 Mar 2012 16:00:35 +0900 From: KAMEZAWA Hiroyuki MIME-Version: 1.0 Subject: Re: [PATCH -V4 04/10] memcg: Add HugeTLB extension References: <1331919570-2264-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1331919570-2264-5-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <4F669C2E.1010502@jp.fujitsu.com> <874ntlkrp6.fsf@linux.vnet.ibm.com> In-Reply-To: <874ntlkrp6.fsf@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: "Aneesh Kumar K.V" Cc: linux-mm@kvack.org, mgorman@suse.de, dhillf@gmail.com, aarcange@redhat.com, mhocko@suse.cz, akpm@linux-foundation.org, hannes@cmpxchg.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org (2012/03/19 15:52), Aneesh Kumar K.V wrote: > On Mon, 19 Mar 2012 11:38:38 +0900, KAMEZAWA Hiroyuki wrote: >> (2012/03/17 2:39), Aneesh Kumar K.V wrote: >> >>> From: "Aneesh Kumar K.V" >>> >>> This patch implements a memcg extension that allows us to control >>> HugeTLB allocations via memory controller. >>> >> >> >> If you write some details here, it will be helpful for review and >> seeing log after merge. > > Will add more info. > >> >> >>> Signed-off-by: Aneesh Kumar K.V >>> --- >>> include/linux/hugetlb.h | 1 + >>> include/linux/memcontrol.h | 42 +++++++++++++ >>> init/Kconfig | 8 +++ >>> mm/hugetlb.c | 2 +- >>> mm/memcontrol.c | 138 ++++++++++++++++++++++++++++++++++++++++++++ >>> 5 files changed, 190 insertions(+), 1 deletions(-) > > .... > >>> +#ifdef CONFIG_MEM_RES_CTLR_HUGETLB >>> +static bool mem_cgroup_have_hugetlb_usage(struct mem_cgroup *memcg) >>> +{ >>> + int idx; >>> + for (idx = 0; idx < hugetlb_max_hstate; idx++) { >>> + if (memcg->hugepage[idx].usage > 0) >>> + return 1; >>> + } >>> + return 0; >>> +} >> >> >> Please use res_counter_read_u64() rather than reading the value directly. >> > > The open-coded variant is mostly derived from mem_cgroup_force_empty. I > have updated the patch to use res_counter_read_u64. > Ah, ok. it's(maybe) my bad. I'll schedule a fix. Thanks, -Kame -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org