From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx173.postini.com [74.125.245.173]) by kanga.kvack.org (Postfix) with SMTP id BECB56B002C for ; Tue, 6 Mar 2012 05:37:56 -0500 (EST) Message-ID: <4F55E8BB.5060704@parallels.com> Date: Tue, 6 Mar 2012 14:36:43 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH 04/10] memcg: Introduce __GFP_NOACCOUNT. References: <1330383533-20711-1-git-send-email-ssouhlal@FreeBSD.org> <1330383533-20711-5-git-send-email-ssouhlal@FreeBSD.org> <20120229150041.62c1feeb.kamezawa.hiroyu@jp.fujitsu.com> <20120301091044.1a62d42c.kamezawa.hiroyu@jp.fujitsu.com> <4F4EC1AB.8050506@parallels.com> <20120301150537.8996bbf6.kamezawa.hiroyu@jp.fujitsu.com> <4F522910.1050402@parallels.com> <4F52A81A.3030408@parallels.com> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Suleiman Souhlal Cc: KAMEZAWA Hiroyuki , Suleiman Souhlal , cgroups@vger.kernel.org, penberg@kernel.org, yinghan@google.com, hughd@google.com, gthelen@google.com, linux-mm@kvack.org, devel@openvz.org On 03/04/2012 04:10 AM, Suleiman Souhlal wrote: > On Sat, Mar 3, 2012 at 3:24 PM, Glauber Costa wrote: >> On 03/03/2012 01:38 PM, Suleiman Souhlal wrote: >>> Another possible example might be the skb data, which are just kmalloc >>> and are already accounted by your TCP accounting changes, so we might >>> not want to account them a second time. >> >> >> How so? >> >> struct sk_buff *__alloc_skb(unsigned int size, gfp_t gfp_mask, >> int fclone, int node) >> { >> [ ... ] >> cache = fclone ? skbuff_fclone_cache : skbuff_head_cache; >> >> /* Get the HEAD */ >> skb = kmem_cache_alloc_node(cache, gfp_mask& ~__GFP_DMA, node); > > Just a few lines below: > > data = kmalloc_node_track_caller(size, gfp_mask, node); > > -- Suleiman Can't we just make sure those come from the root cgroup's slabs? Then we need no flag. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org