From: Konstantin Khlebnikov <khlebnikov@openvz.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Johannes Weiner <jweiner@redhat.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [PATCH resend] mm: drain percpu lru add/rotate page-vectors on cpu hot-unplug
Date: Thu, 01 Mar 2012 12:06:46 +0400 [thread overview]
Message-ID: <4F4F2E16.5080703@openvz.org> (raw)
In-Reply-To: <20120229123818.61a61e9d.akpm@linux-foundation.org>
Andrew Morton wrote:
> On Tue, 28 Feb 2012 23:40:45 +0400
> Konstantin Khlebnikov<khlebnikov@openvz.org> wrote:
>
>> This cpu hotplug hook was accidentally removed in commit v2.6.30-rc4-18-g00a62ce
>> ("mm: fix Committed_AS underflow on large NR_CPUS environment")
>
> That was a long time ago - maybe we should leave it removed ;) I mean,
> did this bug(?) have any visible effect? If so, what was that effect?
It's because cpu hotplug/unplug isn't widely used feature.
Visible effect -- some pages are borrowed in per-cpu page-vectors.
Truncate can deal with it, but these pages cannot be reused while this cpu is offline.
So this is like temporary memory leak.
>
> IOW, the changelog didn't give anyone any reason to apply the patch to
> anything!
Sorry, I'm just stuck in pile of patches. It seems I should stop and send them one by one.
This one isn't critical, so there no reasons for pushing it into stable branches.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-03-01 8:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 19:40 Konstantin Khlebnikov
2012-02-29 0:37 ` KAMEZAWA Hiroyuki
2012-02-29 20:38 ` Andrew Morton
2012-03-01 8:06 ` Konstantin Khlebnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4F2E16.5080703@openvz.org \
--to=khlebnikov@openvz.org \
--cc=akpm@linux-foundation.org \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox