From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx106.postini.com [74.125.245.106]) by kanga.kvack.org (Postfix) with SMTP id B2DF56B007E for ; Wed, 22 Feb 2012 09:03:29 -0500 (EST) Message-ID: <4F44F54A.8010902@parallels.com> Date: Wed, 22 Feb 2012 18:01:46 +0400 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH 1/7] small cleanup for memcontrol.c References: <1329824079-14449-1-git-send-email-glommer@parallels.com> <1329824079-14449-2-git-send-email-glommer@parallels.com> <20120222094619.caffc432.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20120222094619.caffc432.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: cgroups@vger.kernel.org, devel@openvz.org, linux-mm@kvack.org, "Kirill A. Shutemov" , Greg Thelen , Johannes Weiner , Michal Hocko , Paul Turner , Frederic Weisbecker On 02/22/2012 04:46 AM, KAMEZAWA Hiroyuki wrote: > On Tue, 21 Feb 2012 15:34:33 +0400 > Glauber Costa wrote: > >> Move some hardcoded definitions to an enum type. >> >> Signed-off-by: Glauber Costa >> CC: Kirill A. Shutemov >> CC: Greg Thelen >> CC: Johannes Weiner >> CC: Michal Hocko >> CC: Hiroyouki Kamezawa >> CC: Paul Turner >> CC: Frederic Weisbecker > > seems ok to me. > > Acked-by: KAMEZAWA Hiroyuki BTW, this series is likely to go through many rounds of discussion. This patch can be probably picked separately, if you want to. > a nitpick.. > >> --- >> mm/memcontrol.c | 10 +++++++--- >> 1 files changed, 7 insertions(+), 3 deletions(-) >> >> diff --git a/mm/memcontrol.c b/mm/memcontrol.c >> index 6728a7a..b15a693 100644 >> --- a/mm/memcontrol.c >> +++ b/mm/memcontrol.c >> @@ -351,9 +351,13 @@ enum charge_type { >> }; >> >> /* for encoding cft->private value on file */ >> -#define _MEM (0) >> -#define _MEMSWAP (1) >> -#define _OOM_TYPE (2) >> + >> +enum mem_type { >> + _MEM = 0, > > =0 is required ? I believe not, but I always liked to use it to be 100 % explicit. Personal taste... Can change it, if this is a big deal. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org