* [PATCH] cleanup: mm/migrate.c: cleanup comment for function migration_entry_wait
@ 2011-12-21 11:09 Wang Sheng-Hui
2011-12-21 11:43 ` Minchan Kim
0 siblings, 1 reply; 2+ messages in thread
From: Wang Sheng-Hui @ 2011-12-21 11:09 UTC (permalink / raw)
To: Andrew Morton, Mel Gorman, Minchan Kim, Hugh Dickins,
Johannes Weiner, linux-mm, linux-kernel
migration_entry_wait can also be called from hugetlb_fault now.
Cleanup the comment.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
---
mm/migrate.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index 177aca4..640002a 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -181,8 +181,6 @@ static void remove_migration_ptes(struct page *old, struct page *new)
* Something used the pte of a page under migration. We need to
* get to the page and wait until migration is finished.
* When we return from this function the fault will be retried.
- *
- * This function is called from do_swap_page().
*/
void migration_entry_wait(struct mm_struct *mm, pmd_t *pmd,
unsigned long address)
--
1.7.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cleanup: mm/migrate.c: cleanup comment for function migration_entry_wait
2011-12-21 11:09 [PATCH] cleanup: mm/migrate.c: cleanup comment for function migration_entry_wait Wang Sheng-Hui
@ 2011-12-21 11:43 ` Minchan Kim
0 siblings, 0 replies; 2+ messages in thread
From: Minchan Kim @ 2011-12-21 11:43 UTC (permalink / raw)
To: Wang Sheng-Hui
Cc: Andrew Morton, Mel Gorman, Minchan Kim, Hugh Dickins,
Johannes Weiner, linux-mm, linux-kernel
On Wed, Dec 21, 2011 at 07:09:29PM +0800, Wang Sheng-Hui wrote:
> migration_entry_wait can also be called from hugetlb_fault now.
> Cleanup the comment.
>
> Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com>
Alternative is to add hugetlbe_fault in comment but I think it's not useful
because We can find caller easily with cscope or just grep.
My feeling is that the comment isn't helpful.
So I am okay to remove this comment.
Acked-by: Minchan Kim <minchan@kernel.org>
--
Kind regards,
Minchan Kim
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-21 11:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-12-21 11:09 [PATCH] cleanup: mm/migrate.c: cleanup comment for function migration_entry_wait Wang Sheng-Hui
2011-12-21 11:43 ` Minchan Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox