From: Andy Lutomirski <luto@amacapital.net>
To: Jan Kara <jack@suse.cz>
Cc: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
"Darrick J. Wong" <djwong@us.ibm.com>,
Theodore Tso <tytso@mit.edu>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jens Axboe <axboe@kernel.dk>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Jeff Layton <jlayton@redhat.com>,
Dave Chinner <david@fromorbit.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Christoph Hellwig <hch@infradead.org>,
linux-mm@kvack.org, Chris Mason <chris.mason@oracle.com>,
Joel Becker <jlbec@evilplan.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
linux-ext4@vger.kernel.org, Mingming Cao <mcao@us.ibm.com>
Subject: Re: [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses
Date: Sun, 23 Oct 2011 09:38:50 -0700 [thread overview]
Message-ID: <4EA4431A.3010104@amacapital.net> (raw)
In-Reply-To: <20110510162237.GM4402@quack.suse.cz>
On 05/10/2011 09:22 AM, Jan Kara wrote:
> On Wed 11-05-11 01:12:13, OGAWA Hirofumi wrote:
>> Jan Kara<jack@suse.cz> writes:
>>
>>>> Did you already consider, to copy only if page was writeback (like
>>>> copy-on-write)? I.e. if page is on I/O, copy, then switch the page for
>>>> writing new data.
>>> Yes, that was considered as well. We'd have to essentially migrate the
>>> page that is under writeback and should be written to. You are going to pay
>>> the cost of page allocation, copy, increased memory& cache pressure.
>>> Depending on your backing storage and workload this may or may not be better
>>> than waiting for IO...
>>
>> Maybe possible, but you really think on usual case just blocking is
>> better?
> Define usual case... As Christoph noted, we don't currently have a real
> practical case where blocking would matter (since frequent rewrites are
> rather rare). So defining what is usual when we don't have a single real
> case is kind of tough ;)
>
I'm a bit late to the party, but I have such a use case. I have a
real-time program that generates logs. There's a thread that makes sure
that there are always mlocked, MAP_SHARED, writable pages for the logs,
and under normal (or even very heavy) load, the mlocked pages always
stay far ahead of the logs. On 2.6.39, it works great [1]. On 3.0,
it's unusable -- latencies of 30-100 ms are very common.
In this case, neither throughput nor available memory matter at all --
I'm not stressing either. So copying the pages (especially if they're
mlocked) would be more than a small percentage win -- it would be the
difference between great performance and unusability.
I wonder if we want a stronger version of mlock that says "this page
must not be swapped out and, in addition, ptes must always be mapped
with all appropriate permission bits set". (This is only possible with
hardware dirty and accessed bits, but we could come close even without
them.)
[1] file_update_time is a problem. patches coming.
--Andy
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-23 16:39 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-09 23:03 Darrick J. Wong
2011-05-09 23:03 ` [PATCH 1/7] mm: Wait for writeback when grabbing pages to begin a write Darrick J. Wong
2011-05-09 23:03 ` [PATCH 2/7] fs: block_page_mkwrite should wait for writeback to finish Darrick J. Wong
2011-05-10 12:41 ` Jan Kara
2011-05-10 17:12 ` Darrick J. Wong
2011-05-09 23:03 ` [PATCH 3/7] mm: Provide stub page_mkwrite functionality to stabilize pages during writes Darrick J. Wong
2011-05-09 23:03 ` [PATCH 4/7] ext4: Clean up some wait_on_page_writeback calls Darrick J. Wong
2011-05-18 18:16 ` [4/7] " Ted Ts'o
2011-05-09 23:03 ` [PATCH 5/7] ext4: Wait for writeback to complete while making pages writable Darrick J. Wong
2011-05-18 18:17 ` [5/7] " Ted Ts'o
2011-05-09 23:04 ` [PATCH 6/7] ext2: Lock buffer_head during metadata update Darrick J. Wong
2011-05-09 23:04 ` [PATCH 7/7] fat: Lock buffer_head during metadata updates Darrick J. Wong
2011-05-10 0:06 ` [PATCHSET v3.1 0/7] data integrity: Stabilize pages during writeback for various fses Dave Chinner
2011-05-10 1:59 ` OGAWA Hirofumi
2011-05-10 12:38 ` Jan Kara
2011-05-10 13:12 ` OGAWA Hirofumi
2011-05-10 13:29 ` Jan Kara
2011-05-10 13:46 ` OGAWA Hirofumi
2011-05-10 14:05 ` OGAWA Hirofumi
2011-05-10 14:54 ` Jan Kara
2011-05-10 16:12 ` OGAWA Hirofumi
2011-05-10 16:22 ` Jan Kara
2011-05-10 16:28 ` OGAWA Hirofumi
2011-05-16 18:47 ` Darrick J. Wong
2011-05-16 19:31 ` OGAWA Hirofumi
2011-05-17 1:23 ` Darrick J. Wong
2011-05-17 3:30 ` OGAWA Hirofumi
2011-10-23 16:38 ` Andy Lutomirski [this message]
2011-05-10 13:36 ` Christoph Hellwig
2011-05-10 13:52 ` OGAWA Hirofumi
2011-05-10 14:49 ` Jan Kara
2011-05-10 15:24 ` OGAWA Hirofumi
2011-05-10 16:18 ` Jan Kara
2011-05-10 16:29 ` OGAWA Hirofumi
2011-05-10 17:03 ` Jan Kara
2011-05-10 17:03 ` Christoph Hellwig
2011-05-10 20:50 ` OGAWA Hirofumi
2011-05-11 5:55 ` Christoph Hellwig
2011-05-11 9:36 ` OGAWA Hirofumi
2011-05-10 12:51 ` Jan Kara
2011-05-10 16:24 ` Chris Mason
2011-05-11 18:19 ` Darrick J. Wong
2011-05-12 9:42 ` Jan Kara
2011-05-16 18:49 ` Darrick J. Wong
2011-05-16 18:59 ` Jan Kara
2011-05-16 19:09 ` Darrick J. Wong
2011-05-16 19:04 ` Darrick J. Wong
2011-05-16 20:27 ` Christoph Hellwig
2011-05-16 20:55 ` Darrick J. Wong
2011-05-17 14:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA4431A.3010104@amacapital.net \
--to=luto@amacapital.net \
--cc=axboe@kernel.dk \
--cc=chris.mason@oracle.com \
--cc=dave@linux.vnet.ibm.com \
--cc=david@fromorbit.com \
--cc=djwong@us.ibm.com \
--cc=hch@infradead.org \
--cc=hirofumi@mail.parknet.co.jp \
--cc=jack@suse.cz \
--cc=jlayton@redhat.com \
--cc=jlbec@evilplan.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcao@us.ibm.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox