From: Glauber Costa <glommer@parallels.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, paul@paulmenage.org,
lizf@cn.fujitsu.com, ebiederm@xmission.com, davem@davemloft.net,
gthelen@google.com, netdev@vger.kernel.org, linux-mm@kvack.org,
kirill@shutemov.name, avagin@parallels.com, devel@openvz.org
Subject: Re: [PATCH v6 3/8] foundations of per-cgroup memory pressure controlling.
Date: Thu, 13 Oct 2011 12:25:53 +0400 [thread overview]
Message-ID: <4E96A091.4000705@parallels.com> (raw)
In-Reply-To: <20111013145353.161009ea.kamezawa.hiroyu@jp.fujitsu.com>
On 10/13/2011 09:53 AM, KAMEZAWA Hiroyuki wrote:
> On Mon, 10 Oct 2011 14:24:23 +0400
> Glauber Costa<glommer@parallels.com> wrote:
>
>> This patch converts struct sock fields memory_pressure,
>> memory_allocated, sockets_allocated, and sysctl_mem (now prot_mem)
>> to function pointers, receiving a struct mem_cgroup parameter.
>>
>> enter_memory_pressure is kept the same, since all its callers
>> have socket a context, and the kmem_cgroup can be derived from
>> the socket itself.
>>
>> To keep things working, the patch convert all users of those fields
>> to use acessor functions.
>>
>> In my benchmarks I didn't see a significant performance difference
>> with this patch applied compared to a baseline (around 1 % diff, thus
>> inside error margin).
>>
>> Signed-off-by: Glauber Costa<glommer@parallels.com>
>> CC: David S. Miller<davem@davemloft.net>
>> CC: Hiroyouki Kamezawa<kamezawa.hiroyu@jp.fujitsu.com>
>> CC: Eric W. Biederman<ebiederm@xmission.com>
>
> Reviewed-by: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
>
> a nitpick.
>
>
>> #ifdef CONFIG_INET
>> +enum {
>> + UNDER_LIMIT,
>> + OVER_LIMIT,
>> +};
>> +
>
> It may be better to move this to res_counter.h or memcontrol.h
>
Sorry Kame,
It is in memcontrol.h already. What exactly do you mean here ?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-10-13 8:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-10 10:24 [PATCH v6 0/8] per-cgroup tcp memory pressure handling Glauber Costa
2011-10-10 10:24 ` [PATCH v6 1/8] Basic kernel memory functionality for the Memory Controller Glauber Costa
2011-10-13 5:44 ` KAMEZAWA Hiroyuki
2011-10-13 7:18 ` Greg Thelen
2011-10-13 8:19 ` Glauber Costa
2011-10-10 10:24 ` [PATCH v6 2/8] socket: initial cgroup code Glauber Costa
2011-10-10 10:24 ` [PATCH v6 3/8] foundations of per-cgroup memory pressure controlling Glauber Costa
2011-10-13 5:53 ` KAMEZAWA Hiroyuki
2011-10-13 8:25 ` Glauber Costa [this message]
2011-10-10 10:24 ` [PATCH v6 4/8] per-cgroup tcp buffers control Glauber Costa
2011-10-13 5:56 ` KAMEZAWA Hiroyuki
2011-10-10 10:24 ` [PATCH v6 5/8] per-netns ipv4 sysctl_tcp_mem Glauber Costa
2011-10-10 10:24 ` [PATCH v6 6/8] tcp buffer limitation: per-cgroup limit Glauber Costa
2011-10-13 5:58 ` KAMEZAWA Hiroyuki
2011-10-10 10:24 ` [PATCH v6 7/8] Display current tcp memory allocation in kmem cgroup Glauber Costa
2011-10-13 5:59 ` KAMEZAWA Hiroyuki
2011-10-10 10:24 ` [PATCH v6 8/8] Disable task moving when using kernel memory accounting Glauber Costa
2011-10-13 6:00 ` KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E96A091.4000705@parallels.com \
--to=glommer@parallels.com \
--cc=avagin@parallels.com \
--cc=davem@davemloft.net \
--cc=devel@openvz.org \
--cc=ebiederm@xmission.com \
--cc=gthelen@google.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kirill@shutemov.name \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizf@cn.fujitsu.com \
--cc=netdev@vger.kernel.org \
--cc=paul@paulmenage.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox