From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: jweiner@redhat.com
Cc: consul.kautuk@gmail.com, akpm@linux-foundation.org,
mel@csn.ul.ie, minchan.kim@gmail.com,
kamezawa.hiroyu@jp.fujitsu.com, riel@redhat.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
lee.schermerhorn@hp.com
Subject: Re: [patch] mm: remove sysctl to manually rescue unevictable pages
Date: Wed, 28 Sep 2011 10:00:53 +0900 [thread overview]
Message-ID: <4E8271C5.3080500@jp.fujitsu.com> (raw)
In-Reply-To: <20110926112944.GC14333@redhat.com>
(2011/09/26 20:29), Johannes Weiner wrote:
> On Sun, Sep 25, 2011 at 04:29:40PM +0530, Kautuk Consul wrote:
>> write_scan_unavictable_node checks the value req returned by
>> strict_strtoul and returns 1 if req is 0.
>>
>> However, when strict_strtoul returns 0, it means successful conversion
>> of buf to unsigned long.
>>
>> Due to this, the function was not proceeding to scan the zones for
>> unevictable pages even though we write a valid value to the
>> scan_unevictable_pages sys file.
>
> Given that there is not a real reason for this knob (anymore) and that
> it apparently never really worked since the day it was introduced, how
> about we just drop all that code instead?
>
> Hannes
>
> ---
> From: Johannes Weiner <jweiner@redhat.com>
> Subject: mm: remove sysctl to manually rescue unevictable pages
>
> At one point, anonymous pages were supposed to go on the unevictable
> list when no swap space was configured, and the idea was to manually
> rescue those pages after adding swap and making them evictable again.
> But nowadays, swap-backed pages on the anon LRU list are not scanned
> without available swap space anyway, so there is no point in moving
> them to a separate list anymore.
>
> The manual rescue could also be used in case pages were stranded on
> the unevictable list due to race conditions. But the code has been
> around for a while now and newly discovered bugs should be properly
> reported and dealt with instead of relying on such a manual fixup.
>
> Signed-off-by: Johannes Weiner <jweiner@redhat.com>
About three years ago when we introduced unevictable pages feature,
we were worry about there are mlock, shmmem-lock abuse in the real
world and we broke such assumption. And we expected this knob help
to dig unevictable pages bug report. Briefly says, If this knob works
meangfully, our unevictable handling code or their driver code are buggy.
Fortunately, Such bug report was never happen. So, this knob finished
the role.
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2011-09-28 0:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-25 10:59 [PATCH 1/1] vmscan.c: Invalid strict_strtoul check in write_scan_unevictable_node Kautuk Consul
2011-09-26 9:20 ` KAMEZAWA Hiroyuki
2011-09-26 11:29 ` [patch] mm: remove sysctl to manually rescue unevictable pages Johannes Weiner
2011-09-26 12:10 ` kautuk.c @samsung.com
2011-09-26 12:29 ` kautuk.c @samsung.com
2011-09-26 14:25 ` Johannes Weiner
2011-09-26 14:55 ` kautuk.c @samsung.com
2011-09-26 14:18 ` Johannes Weiner
2011-09-26 23:11 ` Andrew Morton
2011-09-27 7:27 ` [patch] mm: disable user interface " Johannes Weiner
2011-09-28 2:14 ` Minchan Kim
2011-10-04 10:10 ` Johannes Weiner
2011-09-28 4:51 ` KAMEZAWA Hiroyuki
2011-09-28 1:00 ` KOSAKI Motohiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E8271C5.3080500@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=consul.kautuk@gmail.com \
--cc=jweiner@redhat.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=minchan.kim@gmail.com \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox