From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 8D0F09000C4 for ; Mon, 26 Sep 2011 18:48:55 -0400 (EDT) Message-ID: <4E81012F.2070001@parallels.com> Date: Mon, 26 Sep 2011 19:48:15 -0300 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v3 4/7] per-cgroup tcp buffers control References: <1316393805-3005-1-git-send-email-glommer@parallels.com> <1316393805-3005-5-git-send-email-glommer@parallels.com> <20110926195906.f1f5831c.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20110926195906.f1f5831c.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: KAMEZAWA Hiroyuki Cc: linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, ebiederm@xmission.com, davem@davemloft.net, gthelen@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, kirill@shutemov.name On 09/26/2011 07:59 AM, KAMEZAWA Hiroyuki wrote: > On Sun, 18 Sep 2011 21:56:42 -0300 > Glauber Costa wrote: > >> With all the infrastructure in place, this patch implements >> per-cgroup control for tcp memory pressure handling. >> >> Signed-off-by: Glauber Costa >> CC: David S. Miller >> CC: Hiroyouki Kamezawa >> CC: Eric W. Biederman > > a comment below. > >> +int tcp_init_cgroup(struct proto *prot, struct cgroup *cgrp, >> + struct cgroup_subsys *ss) >> +{ >> + struct mem_cgroup *cg = mem_cgroup_from_cont(cgrp); >> + unsigned long limit; >> + >> + cg->tcp_memory_pressure = 0; >> + atomic_long_set(&cg->tcp_memory_allocated, 0); >> + percpu_counter_init(&cg->tcp_sockets_allocated, 0); >> + >> + limit = nr_free_buffer_pages() / 8; >> + limit = max(limit, 128UL); >> + >> + cg->tcp_prot_mem[0] = sysctl_tcp_mem[0]; >> + cg->tcp_prot_mem[1] = sysctl_tcp_mem[1]; >> + cg->tcp_prot_mem[2] = sysctl_tcp_mem[2]; >> + > > Then, the parameter doesn't inherit parent's one ? > > I think sockets_populate should pass 'parent' and > > > I think you should have a function > > mem_cgroup_should_inherit_parent_settings(parent) > > (This is because you made this feature as a part of memcg. > please provide expected behavior.) > All right Kame, will do. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org