From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail144.messagelabs.com (mail144.messagelabs.com [216.82.254.51]) by kanga.kvack.org (Postfix) with ESMTP id 3A5CE9000BD for ; Sat, 17 Sep 2011 23:33:38 -0400 (EDT) Message-ID: <4E756666.9000009@parallels.com> Date: Sun, 18 Sep 2011 00:32:54 -0300 From: Glauber Costa MIME-Version: 1.0 Subject: Re: [PATCH v2 4/7] per-cgroup tcp buffers control References: <1316051175-17780-1-git-send-email-glommer@parallels.com> <1316051175-17780-5-git-send-email-glommer@parallels.com> <20110917181132.GC1658@shutemov.name> <20110917183358.GB2783@moon> In-Reply-To: <20110917183358.GB2783@moon> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Cyrill Gorcunov Cc: "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, paul@paulmenage.org, lizf@cn.fujitsu.com, kamezawa.hiroyu@jp.fujitsu.com, ebiederm@xmission.com, davem@davemloft.net, gthelen@google.com, netdev@vger.kernel.org, linux-mm@kvack.org On 09/17/2011 03:33 PM, Cyrill Gorcunov wrote: > On Sat, Sep 17, 2011 at 09:11:32PM +0300, Kirill A. Shutemov wrote: >> On Wed, Sep 14, 2011 at 10:46:12PM -0300, Glauber Costa wrote: >>> +int tcp_init_cgroup_fill(struct proto *prot, struct cgroup *cgrp, >>> + struct cgroup_subsys *ss) >>> +{ >>> + prot->enter_memory_pressure = tcp_enter_memory_pressure; >>> + prot->memory_allocated = memory_allocated_tcp; >>> + prot->prot_mem = tcp_sysctl_mem; >>> + prot->sockets_allocated = sockets_allocated_tcp; >>> + prot->memory_pressure = memory_pressure_tcp; >> >> No fancy formatting, please. >> > > What's wrong with having fancy formatting? It's indeed easier to read > when members are assigned this way. It's always up to maintainer to > choose what he prefers, but I see nothing wrong in such style (if only it > doesn't break the style of the whole file). > > Cyrill I am in agreement with Cyrill, but I really, really don't care... -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org