linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Seth Jennings <sjenning@linux.vnet.ibm.com>
To: Dan Magenheimer <dan.magenheimer@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	jeremy@goop.org, hughd@google.com, ngupta@vflare.org,
	konrad.wilk@oracle.com, JBeulich@novell.com,
	kurt.hackel@oracle.com, npiggin@kernel.dk,
	akpm@linux-foundation.org, riel@redhat.com, hannes@cmpxchg.org,
	matthew@wil.cx, chris.mason@oracle.com,
	kamezawa.hiroyu@jp.fujitsu.com, jackdachef@gmail.com,
	cyclonusj@gmail.com, levinsasha928@gmail.com
Subject: Re: [PATCH V9 5/6] mm: cleancache: update to match akpm frontswap feedback
Date: Tue, 13 Sep 2011 15:46:01 -0500	[thread overview]
Message-ID: <4E6FC109.5090608@linux.vnet.ibm.com> (raw)
In-Reply-To: <20110913174106.GA11330@ca-server1.us.oracle.com>

Hey Dan,

Same typecasting needed here:

mm/cleancache.c: In function ?init_cleancache?:
mm/cleancache.c:214:5: warning: passing argument 4 of ?debugfs_create_size_t? from incompatible pointer type
include/linux/debugfs.h:68:16: note: expected ?size_t *? but argument is of type ?long unsigned int *?
mm/cleancache.c:216:5: warning: passing argument 4 of ?debugfs_create_size_t? from incompatible pointer type
include/linux/debugfs.h:68:16: note: expected ?size_t *? but argument is of type ?long unsigned int *?
mm/cleancache.c:218:5: warning: passing argument 4 of ?debugfs_create_size_t? from incompatible pointer type
include/linux/debugfs.h:68:16: note: expected ?size_t *? but argument is of type ?long unsigned int *?

On 09/13/2011 12:41 PM, Dan Magenheimer wrote:
> +#ifdef CONFIG_DEBUG_FS
> +	struct dentry *root = debugfs_create_dir("cleancache", NULL);
> +	if (root == NULL)
> +		return -ENXIO;
> +	debugfs_create_size_t("succ_gets", S_IRUGO,
> +				root, &cleancache_succ_gets);
> +	debugfs_create_size_t("failed_gets", S_IRUGO,
> +				root, &cleancache_failed_gets);
> +	debugfs_create_size_t("puts", S_IRUGO,
> +				root, &cleancache_puts);
> +	debugfs_create_size_t("invalidates", S_IRUGO,
> +				root, &cleancache_invalidates);
> +#endif

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

      reply	other threads:[~2011-09-13 20:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-13 17:41 Dan Magenheimer
2011-09-13 20:46 ` Seth Jennings [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6FC109.5090608@linux.vnet.ibm.com \
    --to=sjenning@linux.vnet.ibm.com \
    --cc=JBeulich@novell.com \
    --cc=akpm@linux-foundation.org \
    --cc=chris.mason@oracle.com \
    --cc=cyclonusj@gmail.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=hannes@cmpxchg.org \
    --cc=hughd@google.com \
    --cc=jackdachef@gmail.com \
    --cc=jeremy@goop.org \
    --cc=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=konrad.wilk@oracle.com \
    --cc=kurt.hackel@oracle.com \
    --cc=levinsasha928@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=matthew@wil.cx \
    --cc=ngupta@vflare.org \
    --cc=npiggin@kernel.dk \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox