From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id ECF6A6B0169 for ; Mon, 22 Aug 2011 13:25:02 -0400 (EDT) Message-ID: <4E5290D6.5050406@zytor.com> Date: Mon, 22 Aug 2011 10:24:38 -0700 From: "H. Peter Anvin" MIME-Version: 1.0 Subject: Re: [RFC] x86, mm: start mmap allocation for libs from low addresses References: <20110812102954.GA3496@albatros> <20110816090540.GA7857@albatros> <20110822101730.GA3346@albatros> In-Reply-To: <20110822101730.GA3346@albatros> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Vasiliy Kulikov Cc: Thomas Gleixner , Ingo Molnar , kernel-hardening@lists.openwall.com, Peter Zijlstra , Andrew Morton , x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org On 08/22/2011 03:17 AM, Vasiliy Kulikov wrote: > Hi Ingo, Peter, Thomas, > > On Tue, Aug 16, 2011 at 13:05 +0400, Vasiliy Kulikov wrote: >> As the changes are not intrusive, we'd want to see this feature in the >> upstream kernel. If you know why the patch cannot be a part of the >> upstream kernel - please tell me, I'll try to address the issues. > > Any comments on the RFC? Otherwise, may I resend it as a PATCH for > inclusion? > > Thanks! Conceptually: I also have to admit to being somewhat skeptical to the concept on a littleendian architecture like x86. Code-wise: The code is horrific; it is full of open-coded magic numbers; it also puts a function called arch_get_unmapped_exec_area() in a generic file, which could best be described as "WTF" -- the arch_ prefix we use specifically to denote a per-architecture hook function. As such, your claim that the changes are not intrusive is plain false. -hpa -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org