From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 101546B00EE for ; Thu, 11 Aug 2011 09:12:48 -0400 (EDT) Message-ID: <4E43D54D.8030202@suse.cz> Date: Thu, 11 Aug 2011 15:12:45 +0200 From: Michal Marek MIME-Version: 1.0 Subject: Re: [PATCH] mm: Switch NUMA_BUILD and COMPACTION_BUILD to new IS_ENABLED() syntax References: <1312989160-737-1-git-send-email-mmarek@suse.cz> <20110811125133.GJ8023@tiehlicka.suse.cz> <20110811130110.GK8023@tiehlicka.suse.cz> In-Reply-To: <20110811130110.GK8023@tiehlicka.suse.cz> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Michal Hocko Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org On 11.8.2011 15:01, Michal Hocko wrote: > On Thu 11-08-11 14:51:33, Michal Hocko wrote: >> On Wed 10-08-11 17:12:40, Michal Marek wrote: >>> Introduced in 3.1-rc1, IS_ENABLED(CONFIG_NUMA) expands to a true value >>> iff CONFIG_NUMA is set. This makes it easier to grep for code that >>> depends on CONFIG_NUMA. > > I have just looked closer at all available macros. Wouldn't it make more > sense to use IS_BUILTIN instead? Both symbols can be only on or off. > Not that it would make any difference in the end. I even like IS_ENABLED > naming more. IS_ENABLED() and IS_BUILTIN() are equivalent for boolean symbols. IS_BUILTIN() and IS_MODULE() are meant for the (rare) case when someone needs to distinguish between built in and module for tristate options in the code. Michal -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org