From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail6.bemta8.messagelabs.com (mail6.bemta8.messagelabs.com [216.82.243.55]) by kanga.kvack.org (Postfix) with ESMTP id 8D0516B00F1 for ; Tue, 28 Jun 2011 17:04:17 -0400 (EDT) Message-ID: <4E0A41CB.1020908@candelatech.com> Date: Tue, 28 Jun 2011 14:04:11 -0700 From: Ben Greear MIME-Version: 1.0 Subject: Re: [PATCH] slub: reduce overhead of slub_debug References: <20110626193918.GA3339@joi.lan> <4E0A2E26.5000001@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: David Rientjes Cc: David Daney , Christoph Lameter , Marcin Slusarz , Pekka Enberg , Matt Mackall , LKML , linux-mm@kvack.org On 06/28/2011 01:58 PM, David Rientjes wrote: > On Tue, 28 Jun 2011, David Daney wrote: > >> On 06/28/2011 12:32 PM, Christoph Lameter wrote: >>> On Sun, 26 Jun 2011, Marcin Slusarz wrote: >>> >>>> slub checks for poison one byte by one, which is highly inefficient >>>> and shows up frequently as a highest cpu-eater in perf top. >>> >>> Ummm.. Performance improvements for debugging modes? If you need >>> performance then switch off debuggin. >> >> There is no reason to make things gratuitously slow. I don't know about the >> merits of this particular patch, but I must disagree with the general >> sentiment. >> >> We have high performance tracing, why not improve this as well. >> >> Just last week I was trying to find the cause of memory corruption that only >> occurred at very high network packet rates. Memory allocation speed was >> definitely getting in the way of debugging. For me, faster SLUB debugging >> would be welcome. >> > > SLUB debugging is useful only to diagnose issues or test new code, nobody > is going to be enabling it in production environment. We don't need 30 > new lines of code that make one thing slightly faster, in fact we'd prefer > to have as simple and minimal code as possible for debugging features > unless you're adding more debugging coverage. If your problem happens under load, then the overhead of slub could significantly change the behaviour of the system. Anything that makes it more efficient without unduly complicating code should be a win. That posted patch wasn't all that complicated, and even if it has bugs, it could be fixed easily enough. Thanks, Ben > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Ben Greear Candela Technologies Inc http://www.candelatech.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org