From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail143.messagelabs.com (mail143.messagelabs.com [216.82.254.35]) by kanga.kvack.org (Postfix) with SMTP id C7A1D9000BD for ; Mon, 20 Jun 2011 13:27:06 -0400 (EDT) Message-ID: <4DFF82E2.1010409@redhat.com> Date: Tue, 21 Jun 2011 01:26:58 +0800 From: Cong Wang MIME-Version: 1.0 Subject: Re: [PATCH 3/3] mm: print information when THP is disabled automatically References: <1308587683-2555-1-git-send-email-amwang@redhat.com> <1308587683-2555-3-git-send-email-amwang@redhat.com> <20110620170106.GC9396@suse.de> In-Reply-To: <20110620170106.GC9396@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Mel Gorman Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, Andrea Arcangeli , Rik van Riel , Johannes Weiner , KAMEZAWA Hiroyuki , linux-mm@kvack.org ao? 2011a1'06ae??21ae?JPY 01:01, Mel Gorman a??e??: > On Tue, Jun 21, 2011 at 12:34:30AM +0800, Amerigo Wang wrote: >> Print information when THP is disabled automatically so that >> users can find this info in dmesg. >> >> Signed-off-by: WANG Cong >> --- >> mm/huge_memory.c | 5 ++++- >> 1 files changed, 4 insertions(+), 1 deletions(-) >> >> diff --git a/mm/huge_memory.c b/mm/huge_memory.c >> index 7fb44cc..07679da 100644 >> --- a/mm/huge_memory.c >> +++ b/mm/huge_memory.c >> @@ -544,8 +544,11 @@ static int __init hugepage_init(void) >> * where the extra memory used could hurt more than TLB overhead >> * is likely to save. The admin can still enable it through /sys. >> */ >> - if (totalram_pages< (CONFIG_TRANSPARENT_HUGEPAGE_THRESHOLD<< (20 - PAGE_SHIFT))) >> + if (totalram_pages< (CONFIG_TRANSPARENT_HUGEPAGE_THRESHOLD >> + << (20 - PAGE_SHIFT))) { >> + printk(KERN_INFO "hugepage: disabled auotmatically\n"); >> transparent_hugepage_flags = 0; >> + } >> >> start_khugepaged(); >> > > Guess this doesn't hurt. You misspelled automatically though and > mentioning "hugepage" could be confused with hugetlbfs. > Yeah, sorry for the typo. But, there are many printk messages in the same file start with "hugepage:". :-) I can send a patch to replace all of them with "THP" if you want... Thanks! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org