From: Chris Metcalf <cmetcalf@tilera.com>
To: David Rientjes <rientjes@google.com>
Cc: Tejun Heo <tj@kernel.org>,
Christoph Lameter <cl@linux-foundation.org>,
Pekka Enberg <penberg@kernel.org>, Matt Mackall <mpm@selenic.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] slub: always align cpu_slab to honor cmpxchg_double requirement
Date: Thu, 2 Jun 2011 14:13:00 -0400 [thread overview]
Message-ID: <4DE7D2AC.1070503@tilera.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1106021015220.18350@chino.kir.corp.google.com>
On 6/2/2011 1:16 PM, David Rientjes wrote:
> On Thu, 2 Jun 2011, Chris Metcalf wrote:
>> On an architecture without CMPXCHG_LOCAL but with DEBUG_VM enabled,
>> the VM_BUG_ON() in __pcpu_double_call_return_bool() will cause an early
>> panic during boot unless we always align cpu_slab properly.
>>
>> In principle we could remove the alignment-testing VM_BUG_ON() for
>> architectures that don't have CMPXCHG_LOCAL, but leaving it in means
>> that new code will tend not to break x86 even if it is introduced
>> on another platform, and it's low cost to require alignment.
>>
>> Signed-off-by: Chris Metcalf <cmetcalf@tilera.com>
> Acked-by: David Rientjes <rientjes@google.com>
>
>> ---
>> This needs to be pushed for 3.0 to allow arch/tile to boot.
>> I'm happy to push it but I assume it would be better coming
>> from an mm or percpu tree. Thanks!
>>
> Should also be marked for stable for 2.6.39.x, right?
No, in 2.6.39 the irqsafe_cpu_cmpxchg_double() was guarded under "#ifdef
CONFIG_CMPXCHG_LOCAL". Now it's not. I suppose we could take the comment
change in percpu.h for 2.6.39, but it probably doesn't merit churning the
stable tree.
--
Chris Metcalf, Tilera Corp.
http://www.tilera.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-06-02 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-02 14:19 Chris Metcalf
2011-06-02 17:16 ` David Rientjes
2011-06-02 18:13 ` Chris Metcalf [this message]
2011-06-03 5:49 ` Pekka Enberg
2011-06-03 14:06 ` Christoph Lameter
2011-06-03 14:33 ` Chris Metcalf
2011-06-03 14:41 ` Christoph Lameter
2011-06-03 18:06 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE7D2AC.1070503@tilera.com \
--to=cmetcalf@tilera.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox