From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail137.messagelabs.com (mail137.messagelabs.com [216.82.249.19]) by kanga.kvack.org (Postfix) with SMTP id CF6BB6B0011 for ; Wed, 1 Jun 2011 12:03:18 -0400 (EDT) Message-ID: <4DE662BF.3000309@redhat.com> Date: Wed, 01 Jun 2011 12:03:11 -0400 From: Rik van Riel MIME-Version: 1.0 Subject: Re: [PATCH v2 05/10] compaction: make isolate_lru_page with filter aware References: <4feb21bdac4c00a30f3c0d9361bd3565e6afa72f.1306689214.git.minchan.kim@gmail.com> In-Reply-To: <4feb21bdac4c00a30f3c0d9361bd3565e6afa72f.1306689214.git.minchan.kim@gmail.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Minchan Kim Cc: Andrew Morton , linux-mm , LKML , KAMEZAWA Hiroyuki , KOSAKI Motohiro , Mel Gorman , Andrea Arcangeli , Johannes Weiner On 05/29/2011 02:13 PM, Minchan Kim wrote: > In async mode, compaction doesn't migrate dirty or writeback pages. > So, it's meaningless to pick the page and re-add it to lru list. > > Of course, when we isolate the page in compaction, the page might > be dirty or writeback but when we try to migrate the page, the page > would be not dirty, writeback. So it could be migrated. But it's > very unlikely as isolate and migration cycle is much faster than > writeout. > > So, this patch helps cpu and prevent unnecessary LRU churning. > > Reviewed-by: KAMEZAWA Hiroyuki > Reviewed-by: KOSAKI Motohiro > Acked-by: Johannes Weiner > Acked-by: Mel Gorman > Cc: Rik van Riel > Cc: Andrea Arcangeli > Signed-off-by: Minchan Kim ACked-by: Rik van Riel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org