* [PATCH 1/8] mm: Kill set but not used var in bdi_debug_stats_show()
@ 2011-05-20 19:12 Gustavo F. Padovan
2011-05-20 19:23 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Gustavo F. Padovan @ 2011-05-20 19:12 UTC (permalink / raw)
To: linux-kernel
Cc: Jens Axboe, Christoph Hellwig, Artem Bityutskiy, Andrew Morton,
Dave Chinner, open list:MEMORY MANAGEMENT
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
---
mm/backing-dev.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/backing-dev.c b/mm/backing-dev.c
index befc875..f032e6e 100644
--- a/mm/backing-dev.c
+++ b/mm/backing-dev.c
@@ -63,10 +63,10 @@ static int bdi_debug_stats_show(struct seq_file *m, void *v)
unsigned long background_thresh;
unsigned long dirty_thresh;
unsigned long bdi_thresh;
- unsigned long nr_dirty, nr_io, nr_more_io, nr_wb;
+ unsigned long nr_dirty, nr_io, nr_more_io;
struct inode *inode;
- nr_wb = nr_dirty = nr_io = nr_more_io = 0;
+ nr_dirty = nr_io = nr_more_io = 0;
spin_lock(&inode_wb_list_lock);
list_for_each_entry(inode, &wb->b_dirty, i_wb_list)
nr_dirty++;
--
1.7.5.1
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/8] mm: Kill set but not used var in bdi_debug_stats_show()
2011-05-20 19:12 [PATCH 1/8] mm: Kill set but not used var in bdi_debug_stats_show() Gustavo F. Padovan
@ 2011-05-20 19:23 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2011-05-20 19:23 UTC (permalink / raw)
To: Gustavo F. Padovan
Cc: linux-kernel, Christoph Hellwig, Artem Bityutskiy, Andrew Morton,
Dave Chinner, MEMORY MANAGEMENT
On 2011-05-20 21:12, Gustavo F. Padovan wrote:
> Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
> ---
> mm/backing-dev.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/backing-dev.c b/mm/backing-dev.c
> index befc875..f032e6e 100644
> --- a/mm/backing-dev.c
> +++ b/mm/backing-dev.c
> @@ -63,10 +63,10 @@ static int bdi_debug_stats_show(struct seq_file *m, void *v)
> unsigned long background_thresh;
> unsigned long dirty_thresh;
> unsigned long bdi_thresh;
> - unsigned long nr_dirty, nr_io, nr_more_io, nr_wb;
> + unsigned long nr_dirty, nr_io, nr_more_io;
> struct inode *inode;
>
> - nr_wb = nr_dirty = nr_io = nr_more_io = 0;
> + nr_dirty = nr_io = nr_more_io = 0;
> spin_lock(&inode_wb_list_lock);
> list_for_each_entry(inode, &wb->b_dirty, i_wb_list)
> nr_dirty++;
Good catch, nr_wb should have been killed with the removal of the worker
list. I'll queue this up.
--
Jens Axboe
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-05-20 19:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-20 19:12 [PATCH 1/8] mm: Kill set but not used var in bdi_debug_stats_show() Gustavo F. Padovan
2011-05-20 19:23 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox