From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
To: wilsons@start.ca
Cc: akpm@linux-foundation.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, hughd@google.com,
rientjes@google.com, lee.schermerhorn@hp.com,
adobriyan@gmail.com, cl@linux-foundation.org
Subject: Re: [PATCH v2 7/9] mm: proc: move show_numa_map() to fs/proc/task_mmu.c
Date: Wed, 18 May 2011 09:02:38 +0900 [thread overview]
Message-ID: <4DD30C9E.8010200@jp.fujitsu.com> (raw)
In-Reply-To: <1305498029-11677-8-git-send-email-wilsons@start.ca>
(2011/05/16 7:20), Stephen Wilson wrote:
> Moving show_numa_map() from mempolicy.c to task_mmu.c solves several
> issues.
>
> - Having the show() operation "miles away" from the corresponding
> seq_file iteration operations is a maintenance burden.
>
> - The need to export ad hoc info like struct proc_maps_private is
> eliminated.
>
> - The implementation of show_numa_map() can be improved in a simple
> manner by cooperating with the other seq_file operations (start,
> stop, etc) -- something that would be messy to do without this
> change.
>
> Signed-off-by: Stephen Wilson<wilsons@start.ca>
> Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> Cc: Hugh Dickins<hughd@google.com>
> Cc: David Rientjes<rientjes@google.com>
> Cc: Lee Schermerhorn<lee.schermerhorn@hp.com>
> Cc: Alexey Dobriyan<adobriyan@gmail.com>
> Cc: Christoph Lameter<cl@linux-foundation.org>
Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-05-18 0:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-15 22:20 [PATCH v2 0/9] avoid allocation in show_numa_map() Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 1/9] mm: export get_vma_policy() Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 2/9] mm: use walk_page_range() instead of custom page table walking code Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 3/9] mm: remove MPOL_MF_STATS Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 4/9] mm: make gather_stats() type-safe and remove forward declaration Stephen Wilson
2011-05-18 0:01 ` KOSAKI Motohiro
2011-05-15 22:20 ` [PATCH v2 5/9] mm: remove check_huge_range() Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 6/9] mm: declare mpol_to_str() when CONFIG_TMPFS=n Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 7/9] mm: proc: move show_numa_map() to fs/proc/task_mmu.c Stephen Wilson
2011-05-18 0:02 ` KOSAKI Motohiro [this message]
2011-05-15 22:20 ` [PATCH v2 8/9] proc: make struct proc_maps_private truly private Stephen Wilson
2011-05-15 22:20 ` [PATCH v2 9/9] proc: allocate storage for numa_maps statistics once Stephen Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD30C9E.8010200@jp.fujitsu.com \
--to=kosaki.motohiro@jp.fujitsu.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=hughd@google.com \
--cc=lee.schermerhorn@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
--cc=wilsons@start.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox