linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Rik van Riel <riel@redhat.com>
To: Maxin B John <maxin.john@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
	walken@google.com, aarcange@redhat.com, hughd@google.com,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: memory: remove unreachable code
Date: Sun, 08 May 2011 17:29:41 -0400	[thread overview]
Message-ID: <4DC70B45.3020503@redhat.com> (raw)
In-Reply-To: <20110508211834.GA4410@maxin>

On 05/08/2011 05:18 PM, Maxin B John wrote:
> Remove the unreachable code found in mm/memory.c
>
> Signed-off-by: Maxin B. John<maxin.john@gmail.com>
> ---
> diff --git a/mm/memory.c b/mm/memory.c
> index 27f4253..d3b30af 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -3695,7 +3695,6 @@ static int __access_remote_vm(struct task_struct *tsk, struct mm_struct *mm,
>   			if (ret<= 0)
>   #endif
>   				break;
> -			bytes = ret;
>   		} else {
>   			bytes = len;
>   			offset = addr&  (PAGE_SIZE-1);

Is it really impossible for vma->vm_ops->access to return a
positive value?

-- 
All rights reversed

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2011-05-08 21:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-08 21:18 Maxin B John
2011-05-08 21:29 ` Rik van Riel [this message]
2011-05-08 21:44   ` Maxin John

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4DC70B45.3020503@redhat.com \
    --to=riel@redhat.com \
    --cc=aarcange@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hughd@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=maxin.john@gmail.com \
    --cc=walken@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox