From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail191.messagelabs.com (mail191.messagelabs.com [216.82.242.19]) by kanga.kvack.org (Postfix) with SMTP id D1F416B0087 for ; Tue, 4 Jan 2011 03:58:26 -0500 (EST) Message-ID: <4D22E0CF.8000307@leadcoretech.com> Date: Tue, 04 Jan 2011 16:56:47 +0800 From: "Figo.zhang" MIME-Version: 1.0 Subject: Re: [PATCH v3]mm/oom-kill: direct hardware access processes should get bonus References: <1288662213.10103.2.camel@localhost.localdomain> <1289305468.10699.2.camel@localhost.localdomain> <1289402093.10699.25.camel@localhost.localdomain> <1289402666.10699.28.camel@localhost.localdomain> <4D22D190.1080706@leadcoretech.com> <20110104172833.1ff20b41.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20110104172833.1ff20b41.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: lkml , KOSAKI Motohiro , "linux-mm@kvack.org" , Andrew Morton , Linus Torvalds , "Figo.zhang" , "rientjes@google.com" , Wu Fengguang List-ID: On 01/04/2011 04:28 PM, KAMEZAWA Hiroyuki wrote: > On Tue, 04 Jan 2011 15:51:44 +0800 > "Figo.zhang" wrote: > >> >> i had send the patch to protect the hardware access processes for >> oom-killer before, but rientjes have not agree with me. >> >> but today i catch log from my desktop. oom-killer have kill my "minicom" >> and "Xorg". so i think it should add protection about it. >> > > Off topic. > > In this log, I found > >>> Jan 4 15:22:55 figo-desktop kernel: Free swap = -1636kB >>> Jan 4 15:22:55 figo-desktop kernel: Total swap = 0kB >>> Jan 4 15:22:55 figo-desktop kernel: 515070 pages RAM > > ... This means total_swap_pages = 0 while pages are read-in at swapoff. > > Let's see 'points' for oom > == > points = (get_mm_rss(p->mm) + get_mm_counter(p->mm, MM_SWAPENTS)) * 1000 / > totalpages; > == > > Here, totalpages = total_ram + total_swap but totalswap is 0 here. > > So, points can be> 1000, easily. > (This seems not to be related to the Xorg's death itself) total_swap is 0, so totalpages = total_ram, get_mm_counter(p->mm, MM_SWAPENTS) = 0, so points = (get_mm_rss(p->mm)) * 1000 / totalpages; so points canot larger than 1000. > > > > Thanks, > -Kame > > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/ Don't email: email@kvack.org