From: Rik van Riel <riel@redhat.com>
To: Minchan Kim <minchan.kim@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH v4 3/7] move memcg reclaimable page into tail of inactive list
Date: Sun, 05 Dec 2010 22:04:55 -0500 [thread overview]
Message-ID: <4CFC52D7.8040003@redhat.com> (raw)
In-Reply-To: <a11d438e09af9808ac0cb0aba3e74c8a8deb4076.1291568905.git.minchan.kim@gmail.com>
On 12/05/2010 12:29 PM, Minchan Kim wrote:
> Golbal page reclaim moves reclaimalbe pages into inactive list
> to reclaim asap. This patch apply the rule in memcg.
> It can help to prevent unnecessary working page eviction of memcg.
The patch is right, but the description is wrong.
The rotate_reclaimable_page function moves just written out
pages, which the VM wanted to reclaim, to the end of the
inactive list. That way the VM will find those pages first
next time it needs to free memory.
> Cc: Balbir Singh<balbir@linux.vnet.ibm.com>
> Cc: KAMEZAWA Hiroyuki<kamezawa.hiroyu@jp.fujitsu.com>
> Cc: Rik van Riel<riel@redhat.com>
> Cc: KOSAKI Motohiro<kosaki.motohiro@jp.fujitsu.com>
> Signed-off-by: Minchan Kim<minchan.kim@gmail.com>
Reviewed-by: Rik van Riel <riel@redhat.com>
--
All rights reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-12-06 3:05 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-05 17:29 [PATCH v4 0/7] f/madivse(DONTNEED) support Minchan Kim
2010-12-05 17:29 ` [PATCH v4 1/7] Fix checkpatch's report in swap.c Minchan Kim
2010-12-06 1:47 ` Rik van Riel
2010-12-07 14:37 ` Johannes Weiner
2010-12-05 17:29 ` [PATCH v4 2/7] deactivate invalidated pages Minchan Kim
2010-12-06 14:53 ` Mel Gorman
2010-12-07 14:49 ` Johannes Weiner
2010-12-07 15:07 ` Minchan Kim
2010-12-07 15:19 ` Johannes Weiner
2010-12-07 15:26 ` Minchan Kim
2010-12-07 15:56 ` Johannes Weiner
2010-12-07 22:51 ` Minchan Kim
2010-12-08 0:56 ` KAMEZAWA Hiroyuki
2010-12-08 1:43 ` Minchan Kim
2010-12-08 1:56 ` KAMEZAWA Hiroyuki
2010-12-08 2:15 ` Minchan Kim
2010-12-08 6:56 ` Balbir Singh
2010-12-09 0:19 ` Minchan Kim
2010-12-05 17:29 ` [PATCH v4 3/7] move memcg reclaimable page into tail of inactive list Minchan Kim
2010-12-06 0:04 ` KAMEZAWA Hiroyuki
2010-12-06 3:04 ` Rik van Riel [this message]
2010-12-07 0:17 ` Minchan Kim
2010-12-06 3:34 ` Balbir Singh
2010-12-07 0:20 ` Minchan Kim
2010-12-07 14:52 ` Johannes Weiner
2010-12-08 8:08 ` KOSAKI Motohiro
2010-12-05 17:29 ` [PATCH v4 4/7] Reclaim invalidated page ASAP Minchan Kim
2010-12-07 15:05 ` Johannes Weiner
2010-12-07 15:21 ` Minchan Kim
2010-12-08 8:04 ` KOSAKI Motohiro
2010-12-08 8:16 ` Minchan Kim
2010-12-08 13:01 ` Ben Gamari
2010-12-08 23:10 ` Minchan Kim
2010-12-13 15:31 ` Minchan Kim
2010-12-13 20:06 ` Ben Gamari
2010-12-14 2:36 ` Minchan Kim
2011-07-25 3:08 ` Ben Gamari
2011-07-25 3:47 ` Minchan Kim
2010-12-14 2:07 ` KAMEZAWA Hiroyuki
2010-12-14 2:34 ` Minchan Kim
2010-12-05 17:29 ` [PATCH v4 5/7] add profile information for invalidated page reclaim Minchan Kim
2010-12-06 3:24 ` Rik van Riel
2010-12-08 8:02 ` KOSAKI Motohiro
2010-12-08 8:13 ` Minchan Kim
2010-12-08 8:36 ` KOSAKI Motohiro
2010-12-05 17:29 ` [PATCH v4 6/7] Remove zap_details NULL dependency Minchan Kim
2010-12-06 3:25 ` Rik van Riel
2010-12-07 4:26 ` Hugh Dickins
2010-12-07 5:30 ` Minchan Kim
2010-12-05 17:29 ` [PATCH v4 7/7] Prevent activation of page in madvise_dontneed Minchan Kim
2010-12-07 4:48 ` Hugh Dickins
2010-12-07 5:44 ` Minchan Kim
2010-12-08 7:26 ` Hugh Dickins
2010-12-08 7:55 ` Minchan Kim
[not found] ` <AANLkTim71krrCcmhTTCZTzxeUDkvOdBTOkeYQu6EXt32@mail.gmail.com>
2010-12-07 1:52 ` [PATCH v4 0/7] f/madivse(DONTNEED) support Ben Gamari
2010-12-07 2:16 ` Minchan Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4CFC52D7.8040003@redhat.com \
--to=riel@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=minchan.kim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox