From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC887D1CDAB for ; Tue, 22 Oct 2024 07:31:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D4DF76B0083; Tue, 22 Oct 2024 03:31:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CFDA56B0085; Tue, 22 Oct 2024 03:31:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BECBB6B0088; Tue, 22 Oct 2024 03:31:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A0D216B0083 for ; Tue, 22 Oct 2024 03:31:00 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 1552BC0B46 for ; Tue, 22 Oct 2024 07:30:43 +0000 (UTC) X-FDA: 82700415966.08.0AC6A2D Received: from out-175.mta0.migadu.com (out-175.mta0.migadu.com [91.218.175.175]) by imf14.hostedemail.com (Postfix) with ESMTP id 9271B10000F for ; Tue, 22 Oct 2024 07:30:40 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=j9FxgkJG; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729582221; a=rsa-sha256; cv=none; b=ID6WJjG7f0qFS553Da72VWVZuIsqlwI10iVsb8XmS9hrx6T7PE/KRo8ROoOXK80a2QyEv+ ewhdT+eVWKxbUbWsbk0NMh1S8XExYiMFK3eRA+0naT7KSgpq7z/P3Pw40cyjryHljl2UPT bQtljmUWNUsnHhXZvypv5X1S34OUKK4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=j9FxgkJG; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf14.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.175 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729582221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SwAyDyVKA/SOfuimo1rAiUn62XNNlwrTRrrwVlZsQwc=; b=5mI9xSfe4AQ5WjLfI5SStBcfGESnBowUtgd+tA7pmELspyXLMGUW/l+SyuAIrPgy2OupvW s+fDOMvL5uSmqLvev/NjZHCcoM9EEtYBfrZBIOPbRGDk0H0yCE+gQq6CPMHy38hbs41yt8 89hx4Dzk7RhD7kHJNAHT+/Nkx6skBjY= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1729582256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SwAyDyVKA/SOfuimo1rAiUn62XNNlwrTRrrwVlZsQwc=; b=j9FxgkJGvCbzrhPbm9O6+LEBgxwozxYBsqijgU3wETTzsY9s5rVoaY/nYX/UnOxD1VCuqU c5xJFBYYmPnpaucos/hjLjDDd+VdXDo9QXCcoKxaFFykjndC6sNPK110vfMash8gKvDfTA 8Bsyyxdjbp5md2pskvk8kVOKztvv/fI= Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3818.100.11.1.3\)) Subject: Re: [PATCH v2] mm/memcontrol: Fix seq_buf size to save memory when PAGE_SIZE is large X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20241021130027.3615969-1-ryan.roberts@arm.com> Date: Tue, 22 Oct 2024 15:30:11 +0800 Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Andrew Morton , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Michal Hocko Content-Transfer-Encoding: 7bit Message-Id: <4BEA4D18-A71B-40EB-82C0-6450B78C4627@linux.dev> References: <20241021130027.3615969-1-ryan.roberts@arm.com> To: Ryan Roberts X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Stat-Signature: 9mubt3q3sfwu4dq7u5fctj36kgx66zci X-Rspamd-Queue-Id: 9271B10000F X-Rspamd-Server: rspam02 X-HE-Tag: 1729582240-326038 X-HE-Meta: U2FsdGVkX1+wMKa/Zc2MxJ4zyPRufkDZdK2MuhFE5oh34V5bZFaJQbb8hFnFW3NwdtJmHnHfx1QHTxDYKCDISxAtw+WbZsFmZhv+3vxXUGhyRApURYFvf8r97cCChen0R6KRR9e1SOb21swPJlVrkUaz9fwCyTI8+gzOM/QsGRhdt8SuWRoPVqp4Jg/mqjn/QTsjGkFUCxjCNSTzIJZwBoio6jMcwUabzq1sYG+WdCHR9dKB9s1sAS7W0vhLgCS3A17npBIee6HxfJvaxRJ/tbGM6C0HDgz1MVCyxf6qtD1DU6Z3/NJSAUl4xBGuwEo3oeHgTRanTh78unrBTlQKk5o+wEwTW5kXljJZ7EFq34AXFoQdjf55l7Yy29GRzawVMG6zoemEuETnYnlL2Im/0Ip4y8rpUf68lw9fFxoc48xjxo5nBfhJdpSREoYW4GMYYUjytX/860RyrwDf62gyPjuXsBWIJwyiQjbgRftXKCL7YVHvZbOlCNiXtKcV8K3INiR0qPLl4hRwXpyAkxvsmt/b6KQb2kx57UN5+o7Y9Vdnm0OAeN6cEEUHTdl9vUcxPIZZ/nRXe384jfAU580JJ4H4sbk3xcztM+vSeE5/wdT6JTfwW3lkD88FfTjdKjUudFXi93KnF8S5sxjWlBrUYdDZA9PUWqqX+e41zuCTNGVFfRl2QCEFeeAggc72HiEKTkiuYkbyul3zFWWC5GF8TrcfuVfO0GFGOXDL/+22hAqzZOef9LepuoIs7hPhL21TTXnkPB032XijprC/OAYZqRnDihgKfmCYm1GcuO/nxfGEGPwt6BYqN5G1Xn+c+I6rc4Ot9kTqhmjxULjHfWFsY1XimKYdHUsOURdBfwP545MGvXyz0CPpwdPHIgXFDYmTGcaT6ndpf4rXslkZSjAQO1izcHl6zUCO08AxjPey+7PCEW7VjSeaYlD3SOAXBqGigZCb94auOlv9BcLINwl FD/C72Hb 5JgYgP+d4rqEFqzFkhu/XCPeKav6v5uPRaQuyZqgFGnKBLIP1jZmh43S+w87N1K67+6rHO+dmp1Qnz11aK+YlCknRTAVHMWQYHBn3qWOg7nxRXHacIvcHfRnkRQLfRUKQfs1Fn1ErJBRAvvdlPBKwWaFlJzw5q1b/8q2MT9AqZX2M7iiXYpjvjl3yqULphjluny09AifLmMW5zTb80hnTj7RQmX8MCnDYHHtq33MrMdZtDsisMQ7XVN/FU6sOc7yZ/ZaTW2FEK4OXDP5QueT38twoNRlJuo0JBYVwDDNr5E1L6m4cKnXVWbGAkixPWahORW7G69zYaopGVBIngK0APPP0zy5vazv5JIr9FFS1omTOiMlMKrEEfijSbkjV4DQXQTo+eVpK8WdQXxjPZK2nNUCJ1g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Oct 21, 2024, at 21:00, Ryan Roberts wrote: > > Previously the seq_buf used for accumulating the memory.stat output was > sized at PAGE_SIZE. But the amount of output is invariant to PAGE_SIZE; > If 4K is enough on a 4K page system, then it should also be enough on a > 64K page system, so we can save 60K on the static buffer used in > mem_cgroup_print_oom_meminfo(). Let's make it so. > > This also has the beneficial side effect of removing a place in the code > that assumed PAGE_SIZE is a compile-time constant. So this helps our > quest towards supporting boot-time page size selection. > > Signed-off-by: Ryan Roberts > Acked-by: Johannes Weiner > Acked-by: Shakeel Butt > Acked-by: Michal Hocko > Acked-by: Roman Gushchin Acked-by: Muchun Song Thanks.