From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FBBCC83F11 for ; Mon, 28 Aug 2023 07:16:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 96B07280012; Mon, 28 Aug 2023 03:16:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91BF08E0001; Mon, 28 Aug 2023 03:16:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 830F2280012; Mon, 28 Aug 2023 03:16:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 76F048E0001 for ; Mon, 28 Aug 2023 03:16:14 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3F89D160353 for ; Mon, 28 Aug 2023 07:16:14 +0000 (UTC) X-FDA: 81172654668.24.6595C13 Received: from out-244.mta1.migadu.com (out-244.mta1.migadu.com [95.215.58.244]) by imf17.hostedemail.com (Postfix) with ESMTP id 3F73F4001C for ; Mon, 28 Aug 2023 07:16:12 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="UVbI66/q"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.244 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693206972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ea3oJojfHwYhg/cah6p3oZm1twpvjQ6dlwY+OIn4Srk=; b=biFAixuEq5OYf2VTpCYeldN02CChBlvM4dxxpVAOomNsvsrooXNskBNs54JDFPaa5oADR9 gaJkub1V+cYrZTI9cF3N0yXkHq4qZbj93uicoIkvze9V4Va5nGgMy4wY3wanY/xZaMtWSK rAXbJbt2+q+Zxft8WpHkxEKAJ5gPifY= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="UVbI66/q"; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf17.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.244 as permitted sender) smtp.mailfrom=muchun.song@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693206972; a=rsa-sha256; cv=none; b=CPL7RfOrzP+i3QyXNpCxJtbf6b+0Fua3p/NrjYVtOR6PxZTJz4fqb3wQOIlf3DdgxRjU6a 6lx9NjPKvTCaYwM8XLMLADAAwKcKx01QMYInOqujW+R8imbDxO0hnIUPHv/Z+nmbDBVcrD 9RBKkmjKE/uoHgxjhec8aFgSR0ENXuE= Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1693206969; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ea3oJojfHwYhg/cah6p3oZm1twpvjQ6dlwY+OIn4Srk=; b=UVbI66/qKVdEmeAVCoKGswbLzkvWdcdpCEDlNWN0G2s7DtDg0Si1KNkza71j4IE+FaNSJN xCGP/SSOXcHOoLTA/ExQDA3NHQf8445cgKbcJHqQrOVIuGccwXlbtJ1NUQYrbcAlBow3GW /znAvrd/G4DyATPrrLdQ3zoRb8LgF28= Mime-Version: 1.0 Subject: Re: [v3 1/4] mm: hugetlb_vmemmap: Use nid of the head page to reallocate it X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20230825111836.1715308-2-usama.arif@bytedance.com> Date: Mon, 28 Aug 2023 15:15:27 +0800 Cc: Linux-MM , Mike Kravetz , Mike Rapoport , LKML , Muchun Song , fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com Content-Transfer-Encoding: 7bit Message-Id: <4BE9BCF9-AD29-484B-BBB0-3709B77E2236@linux.dev> References: <20230825111836.1715308-1-usama.arif@bytedance.com> <20230825111836.1715308-2-usama.arif@bytedance.com> To: Usama Arif X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 3F73F4001C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: qspqqohsabobuny95pwt6zc7z1g3boq1 X-HE-Tag: 1693206971-111377 X-HE-Meta: U2FsdGVkX1+JEj/1OHLaDrAsXJX+48nvb0tmTw3dESCNCpgoQ0URAxyNiXwQr0cRAW3HqCJEGOjkKKeFChV8J8KgLVNmmcXglFG20BFh6RN8hAd3xfVSfFBDNbuQqbZ8genX7q6wUienCVPFrNKwTQ2ppnYqH6SYHQDYTVQm2tb6kfvOQYWs3cLJUTr9BEoIocH9OY47QlWvlue4tCbpLwseuasqccmy+/wVbZRu9aKdIv+S1bVYLoWiU0eeKmZexfxrMTuY9y48t2nPdSdqnPq/IRFoC/OwxzDgEAtaOAm2KEQ2AHj3ClHuCpNf5SAcVhww5tBm5QA2wK+yCJnc/+3wCFvLUiEzNOu6quua+amEJU0W3f2cq/x9aW3sHT0J9w+vRUYjd0HR4JJT3bKnS2M8QZmaMXS/+0EbpYyCfjrKuyJ1frgMcECPj429IpIGNiEQHU+hf5QP6v858md2tke3a7U9mJTIiIMYfVTDx8rRelUCf5hvQK1VSMRLUig5pbqY09gueiKVXF49HIcBvGzeGbsQ7jLC7kxLkatDA/eGwEnI9cwdweH/Xv6QgY2zHg5konwGgSxML7cIB7uhzQVRzwayQW4TnMuAQqmKpSb+MlDzQGCCQlijfZB/EVznsYv7cbYAA1EI6GawUGBJH4WNTFWCinkeO/VYACBb6uLQYXqo2L/Q4ZGyzDD8u4KVWhzvOCjYHvjJ/sdJX010SDM+w4iZGnbwoCiwJkcAPsrUK0jiDRKkeU88lpcwlWnn0JWr06feCZGFgvXaVTXZPtm5i0z+j4Pr5VPrhN6oKF04CP3mZRbQewMZxj6aSDnY3UV2bSuI0GgC4WFN0/KHFRTfvQifuX5LIWO3K3/YfO/h7XCTd9Z995Sxzy8ohP9CZjJwCcEm4fJF4HbcP2H/vyy9G+tfeS9u/xiphR/mTGt7eu66ShY7Q7aS5CKRl5i/nZf9HVTW9/VQizTzty6 H/2VR+6V u6W4nn2pblCwGFoSYTZAScHMqJgMykpuKZKmV5/2aoXCAmdRL0S0Hty3WTFmA7mIrgIcOYmRCK4k4mUhhMFbAuX8UX1Bxti/sRPd2NZ3KSH7u9No4muMdZYhyPUw0OTKfY3VWqmhx7Ag2jhK6YPsjGebQEfmXmCpk6eNvTKaoN8b6208+IjUG2pvtrjtIalLJUs1Y2vTYe1qZeTXIhBiMoklwAaS9ZxhetrhQl3GXpN0XgNAnGvk2fv9WJYJvLtJjsGIB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > On Aug 25, 2023, at 19:18, Usama Arif wrote: > > If tail page prep and initialization is skipped, then the "start" > page will not contain the correct nid. Use the nid from first > vmemap page. > > Signed-off-by: Usama Arif Make sense even if without your optimization. Because the nid is used for allocation for "reuse" page, it really should be extracted from "reuse" page instead of "start" page. Reviewed-by: Muchun Song