From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with ESMTP id A2D586B0071 for ; Thu, 4 Feb 2010 21:28:35 -0500 (EST) Message-ID: <4B6B8165.107@bx.jp.nec.com> Date: Thu, 04 Feb 2010 21:24:37 -0500 From: Keiichi KII MIME-Version: 1.0 Subject: [RFC PATCH -tip 1/2 v3] tracepoints: add tracepoints for pagecache References: <4B6B7FBF.9090005@bx.jp.nec.com> In-Reply-To: <4B6B7FBF.9090005@bx.jp.nec.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Keiichi KII Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, lwoodman@redhat.com, linux-mm@kvack.org, Tom Zanussi , riel@redhat.com, rostedt@goodmis.org, akpm@linux-foundation.org, fweisbec@gmail.com, Munehiro Ikeda , Atsushi Tsuji List-ID: This patch adds several tracepoints to track pagecach behavior. These trecepoints would help us monitor pagecache usage with high resolution. Signed-off-by: Keiichi Kii Cc: Atsushi Tsuji --- include/trace/events/filemap.h | 83 +++++++++++++++++++++++++++++++++++++++++ mm/filemap.c | 5 ++ mm/truncate.c | 2 mm/vmscan.c | 3 + 4 files changed, 93 insertions(+) Index: linux-2.6-tip/include/trace/events/filemap.h =================================================================== --- /dev/null +++ linux-2.6-tip/include/trace/events/filemap.h @@ -0,0 +1,75 @@ +#undef TRACE_SYSTEM +#define TRACE_SYSTEM filemap + +#if !defined(_TRACE_FILEMAP_H) || defined(TRACE_HEADER_MULTI_READ) +#define _TRACE_FILEMAP_H + +#include +#include + +TRACE_EVENT(find_get_page, + + TP_PROTO(struct address_space *mapping, pgoff_t offset, + struct page *page), + + TP_ARGS(mapping, offset, page), + + TP_STRUCT__entry( + __field(dev_t, s_dev) + __field(ino_t, i_ino) + __field(pgoff_t, offset) + __field(struct page *, page) + ), + + TP_fast_assign( + __entry->s_dev = mapping->host ? mapping->host->i_sb->s_dev : 0; + __entry->i_ino = mapping->host ? mapping->host->i_ino : 0; + __entry->offset = offset; + __entry->page = page; + ), + + TP_printk("s_dev=%u:%u i_ino=%lu offset=%lu %s", MAJOR(__entry->s_dev), + MINOR(__entry->s_dev), __entry->i_ino, __entry->offset, + __entry->page == NULL ? "page_not_found" : "page_found") +); + +DECLARE_EVENT_CLASS(page_cache_template, + + TP_PROTO(struct address_space *mapping, pgoff_t offset), + + TP_ARGS(mapping, offset), + + TP_STRUCT__entry( + __field(dev_t, s_dev) + __field(ino_t, i_ino) + __field(pgoff_t, offset) + ), + + TP_fast_assign( + __entry->s_dev = mapping->host->i_sb->s_dev; + __entry->i_ino = mapping->host->i_ino; + __entry->offset = offset; + ), + + TP_printk("s_dev=%u:%u i_ino=%lu offset=%lu", MAJOR(__entry->s_dev), + MINOR(__entry->s_dev), __entry->i_ino, __entry->offset) +); + +DEFINE_EVENT(page_cache_template, add_to_page_cache, + + TP_PROTO(struct address_space *mapping, pgoff_t offset), + + TP_ARGS(mapping, offset) +); + +DEFINE_EVENT(page_cache_template, remove_from_page_cache, + + TP_PROTO(struct address_space *mapping, pgoff_t offset), + + TP_ARGS(mapping, offset) +); + +#endif /* _TRACE_FILEMAP_H */ + +/* This part must be outside protection */ +#include Index: linux-2.6-tip/mm/filemap.c =================================================================== --- linux-2.6-tip.orig/mm/filemap.c +++ linux-2.6-tip/mm/filemap.c @@ -34,6 +34,8 @@ #include /* for BUG_ON(!in_atomic()) only */ #include #include /* for page_is_file_cache() */ +#define CREATE_TRACE_POINTS +#include #include "internal.h" /* @@ -149,6 +151,7 @@ void remove_from_page_cache(struct page spin_lock_irq(&mapping->tree_lock); __remove_from_page_cache(page); spin_unlock_irq(&mapping->tree_lock); + trace_remove_from_page_cache(mapping, page->index); mem_cgroup_uncharge_cache_page(page); } @@ -419,6 +422,7 @@ int add_to_page_cache_locked(struct page if (PageSwapBacked(page)) __inc_zone_page_state(page, NR_SHMEM); spin_unlock_irq(&mapping->tree_lock); + trace_add_to_page_cache(mapping, offset); } else { page->mapping = NULL; spin_unlock_irq(&mapping->tree_lock); @@ -642,6 +646,7 @@ repeat: } rcu_read_unlock(); + trace_find_get_page(mapping, offset, page); return page; } EXPORT_SYMBOL(find_get_page); Index: linux-2.6-tip/mm/truncate.c =================================================================== --- linux-2.6-tip.orig/mm/truncate.c +++ linux-2.6-tip/mm/truncate.c @@ -20,6 +20,7 @@ do_invalidatepage */ #include "internal.h" +#include /** * do_invalidatepage - invalidate part or all of a page @@ -388,6 +389,7 @@ invalidate_complete_page2(struct address BUG_ON(page_has_private(page)); __remove_from_page_cache(page); spin_unlock_irq(&mapping->tree_lock); + trace_remove_from_page_cache(mapping, page->index); mem_cgroup_uncharge_cache_page(page); page_cache_release(page); /* pagecache ref */ return 1; Index: linux-2.6-tip/mm/vmscan.c =================================================================== --- linux-2.6-tip.orig/mm/vmscan.c +++ linux-2.6-tip/mm/vmscan.c @@ -48,6 +48,8 @@ #include "internal.h" +#include + struct scan_control { /* Incremented by the number of inactive pages that were scanned */ unsigned long nr_scanned; @@ -477,6 +479,7 @@ static int __remove_mapping(struct addre } else { __remove_from_page_cache(page); spin_unlock_irq(&mapping->tree_lock); + trace_remove_from_page_cache(mapping, page->index); mem_cgroup_uncharge_cache_page(page); } -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org