From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 741A9C46CD2 for ; Tue, 2 Jan 2024 06:31:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1CD2C6B0283; Tue, 2 Jan 2024 01:31:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 17D496B0284; Tue, 2 Jan 2024 01:31:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 044EA6B0285; Tue, 2 Jan 2024 01:31:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E6BA26B0283 for ; Tue, 2 Jan 2024 01:31:02 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B96931606A8 for ; Tue, 2 Jan 2024 06:31:02 +0000 (UTC) X-FDA: 81633398364.08.FF17405 Received: from out-184.mta0.migadu.com (out-184.mta0.migadu.com [91.218.175.184]) by imf02.hostedemail.com (Postfix) with ESMTP id F1AE480016 for ; Tue, 2 Jan 2024 06:31:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=o38+Omru; spf=pass (imf02.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704177061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xwM83SlsLb1lbvo4JCqZZv0h8wT6KPgcWS/HAwN04/0=; b=PlXA/b9GHZ8BX9VDFjp0/n2f3suK/N/NATmlMZD/Hy6GOeoDLJvshIaif+ycBVzyIR1G5u M5iwArgT0ZH77iAWKB/5pXhGjbFAYJ/w1SbMlOh7apHrB17qz7iA3nFV65PokPXfXPJpDJ LA587WnhWFqWmfSAvdfFRcW1Z4geZx4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704177061; a=rsa-sha256; cv=none; b=m5isANIRJrrgRPsWLcUJjHFYXZpYQDdPu+AWXDciEb+j6Bs9oH32pXlBZFTuf/8mqTiPss rhoaU8UcfzgJzm2m8Kz+f+k06gQHhxT75w2bAS8+T6+slgnHob/FVNY1b8Dx0GoDuFi51v dlj3HHAB68byZS2arJbYbbJztV9zwGg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=o38+Omru; spf=pass (imf02.hostedemail.com: domain of muchun.song@linux.dev designates 91.218.175.184 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Content-Type: text/plain; charset=us-ascii DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704177059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xwM83SlsLb1lbvo4JCqZZv0h8wT6KPgcWS/HAwN04/0=; b=o38+Omrur7cm8Q/e0nLnXqBIsWvLMDkbm5ptAnn/ZlZWQiCVmcDjZtwoEs60A94RgcAauv E132opwWBTvCsPeDzfzlh9A4yzPTIVTPtHNC/5L0+b6GA84IBDoYN0L7I27E5LuYL9UL8A OyzbfsSDRORVadxA5D4C39d8zPUzD98= Mime-Version: 1.0 Subject: Re: [PATCH 03/13] mm: Provide generic pmd_thp_or_huge() X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: Date: Tue, 2 Jan 2024 14:30:25 +0800 Cc: LKML , Linux-MM , Matthew Wilcox , Christophe Leroy , Lorenzo Stoakes , David Hildenbrand , Vlastimil Babka , Mike Kravetz , Mike Rapoport , Christoph Hellwig , John Hubbard , Andrew Jones , linux-arm-kernel@lists.infradead.org, Michael Ellerman , "Kirill A . Shutemov" , linuxppc-dev@lists.ozlabs.org, Rik van Riel , linux-riscv@lists.infradead.org, Yang Shi , James Houghton , "Aneesh Kumar K . V" , Andrew Morton , Jason Gunthorpe , Andrea Arcangeli , Axel Rasmussen Content-Transfer-Encoding: quoted-printable Message-Id: <4B38660D-3AC2-4F96-9DD1-2D8CAA55E7E4@linux.dev> References: <20231219075538.414708-1-peterx@redhat.com> <20231219075538.414708-4-peterx@redhat.com> <135b3189-f459-4b57-9861-bb8acb999d91@linux.dev> To: Peter Xu X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: F1AE480016 X-Rspam-User: X-Stat-Signature: n6fgh9m3kg76zbqbim5wnoo85nyjmmeq X-Rspamd-Server: rspam03 X-HE-Tag: 1704177060-678548 X-HE-Meta: U2FsdGVkX19Fa/0Qja7uX4y0Y23BA+nlMsmtSuL1WX5Rqh+wdgMZpw2e1i3ar01KbGxz4m9b0CvuUAg+JJIg7QmE+orbPX728muZLxpXhNZF8itXicPK89rO6OYvFuwISZHOxweRrG23yb2xeoptKl5Pgego6fEZNwVUDaZiYs+jtBIIP5Cky0QBIdOJ1uzhbpN3hHB+AMvRVB+/xMC7GN8qGlJGRGYgl7sJI9mJ5si6fe8P6dlfBWGGb2WJOpe6XV4r+WbQXuek2uTcHqSJ9g3LOTjPSleNBb6vbOK8WGr1ppHhRjsPg/Aa6RHptJzxKPZ03C9PGOtiQT20eAKJx/cR2sYoW9QdE4XAEWxly+mmbzMVjbXR9zbnw2eegQNvcRrcPD8UGRZdmkLeKTiOBHV99tfYfQrOzXKWcS0TRoulzBYKm9QkL5HGg8bBu9STQKOZx5lvu04kZYWk+9TIRYjxiyAA4VPndbTWXu7eoT/4gZyIOD8OXg88FpCdIksIbuzD5iHiZ5a96eLNQsVhlDCiE6ahJ14TBr8juyM81LCdHznzk9Th4apbzFgztGu0NMfthnbAnqnfVMRGfXVZbGKLw50wYpGRXasxFgvYAAv5iNcVKYf68tmq8MPmeA19ePO6PSfHgwgEpB4cRbJsO+1MIUGs5gq9yjyajgWxNuaI6F7dRs4EJMYDVx03gkPuzjLH3jx3FtgtGIAoyG2KXRagV91kX2rdtJZCO+Y2x8i7cWVPp5OJvR6mZWebwWrvCqmpABIk6odGHrbOoqf+XfpMs+fB4GfvWCxRTepObwZHv5RgBMTHCDfUWvKgkDDHKmHdqdcDBgWU2cqGjcr8z5jUCFvpGVPXJAWk+0qcp6i0+5Bq8fNk9O450yeQt0Iy10ENzp1VCPRbBQh+MKSfeS4W+IdCKtgUDKvoWbLsfWIml+HnAjN/Al4ZG8Fy6Jlh/uoR3NiN6M0Q4RTi8uP UGFhAqlx yhnX+xcXkO4iTOEphbJ2e0XWvsWKIJLNGvlewZgGSIPSFS2MR5XhprrozI2NKQbT8dm0RupfQM1qPO53yDmhBnByiKyvT3Juz3BDOH4D5DtWZRxh4+t1lQELw+B7O91JOcKRUBL2mMtye5U8HNZyx6xW/k2h1DtI/+MRsZJm35Hgqc1MpSR72Rb4enOz2dqX8FelMz6GwY88L5P3CTwrDj+AttgLqOJmnDcAK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > On Jan 2, 2024, at 13:37, Peter Xu wrote: >=20 > On Mon, Dec 25, 2023 at 02:29:53PM +0800, Muchun Song wrote: >>> @@ -1355,6 +1355,10 @@ static inline int pmd_write(pmd_t pmd) >>> #endif /* pmd_write */ >>> #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ >>> +#ifndef pmd_thp_or_huge >>=20 >> I think it may be the time to rename to pmd_thp_or_hugetlb, >> the "huge" is really confusing. thp is not huge? Actually, >> it is huge. It is better to make it more specific from now on, like >> "hugetlb". >=20 > The rename will need to touch ARM code, which I wanted to avoid, see: I see. >=20 > arch/arm64/include/asm/pgtable.h:#define pmd_thp_or_huge(pmd) = (pmd_huge(pmd) || pmd_trans_huge(pmd)) >=20 > So far this series only touches generic code. Would you mind I keep = this > patch as-is, and leave renaming to later? OK. THanks. >=20 >>=20 >> BTW, please cc me via the new email (muchun.song@linux.dev) next = edition. >=20 > Sure. Thanks for taking a look. >=20 > --=20 > Peter Xu >=20