From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail202.messagelabs.com (mail202.messagelabs.com [216.82.254.227]) by kanga.kvack.org (Postfix) with SMTP id 3577A6B0044 for ; Tue, 15 Dec 2009 21:00:53 -0500 (EST) Message-ID: <4B283F40.5080706@cn.fujitsu.com> Date: Wed, 16 Dec 2009 10:00:32 +0800 From: Li Zefan MIME-Version: 1.0 Subject: Re: [PATCH RFC v2 1/4] cgroup: implement eventfd-based generic API for notifications References: <4B283B7F.2050403@cn.fujitsu.com> In-Reply-To: <4B283B7F.2050403@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: "Kirill A. Shutemov" Cc: containers@lists.linux-foundation.org, linux-mm@kvack.org, Paul Menage , Andrew Morton , KAMEZAWA Hiroyuki , Balbir Singh , Pavel Emelyanov , Dan Malek , Vladislav Buzov , Daisuke Nishimura , linux-kernel@vger.kernel.org List-ID: >> +/* >> + * Check if a file is a control file >> + */ >> +static inline struct cftype *__file_cft(struct file *file) >> +{ >> + if (file->f_dentry->d_inode->i_fop != &cgroup_file_operations) >> + return ERR_PTR(-EINVAL); > > I don't think this check is needed. > Sorry, please ignore this comment -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org