From: Li Zefan <lizf@cn.fujitsu.com>
To: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Ingo Molnar <mingo@elte.hu>,
Christoph Lameter <cl@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
Subject: Re: [PATCH 1/2] tracing: Define kmem_trace_alloc_notrace unconditionally
Date: Fri, 11 Dec 2009 15:06:21 +0800 [thread overview]
Message-ID: <4B21EF6D.4070207@cn.fujitsu.com> (raw)
In-Reply-To: <4B21E806.6070207@cs.helsinki.fi>
>>>> Always define kmem_trace_alloc_{,node}_notrace(), otherwise
>>>> perf-kmem will show wrong stats ifndef CONFIG_KMEMTRACE,
>>>> because a kmalloc() memory allocation may be traced by
>>>> both trace_kmalloc() and trace_kmem_cache_alloc().
>>>>
>>>> Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
>>> Did you check how much this will make kernel text bigger because of the
>>> inlining happening in kmem_cache_alloc_notrace()?
>>>
>>
>> I'm not sure I understood what you meant, but I'm not inlining
>> kmem_cache_alloc_notrace(), and instead I'm removing the inline
>> version in !CONFIG_KMEMTRACE case.
>
> In SLUB, slab_alloc() will be inlined to kmem_cache_alloc_notrace()
> increasing mm/slub.o size so we don't want to define
> kmem_cache_alloc_notrace() unconditionally.
>
I got your point. I'll make a new patch based on your suggestion.
Thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2009-12-11 7:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 5:50 Li Zefan
2009-12-11 5:50 ` [PATCH 2/2] tracing: Fix no callsite ifndef CONFIG_KMEMTRACE Li Zefan
2009-12-11 6:00 ` Pekka Enberg
2009-12-11 5:57 ` [PATCH 1/2] tracing: Define kmem_trace_alloc_notrace unconditionally Pekka Enberg
2009-12-11 6:01 ` Pekka Enberg
2009-12-11 6:11 ` Li Zefan
2009-12-11 6:35 ` Pekka Enberg
2009-12-11 6:02 ` Li Zefan
2009-12-11 6:34 ` Pekka Enberg
2009-12-11 7:06 ` Li Zefan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B21EF6D.4070207@cn.fujitsu.com \
--to=lizf@cn.fujitsu.com \
--cc=cl@linux-foundation.org \
--cc=eduard.munteanu@linux360.ro \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@elte.hu \
--cc=penberg@cs.helsinki.fi \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox