From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail190.messagelabs.com (mail190.messagelabs.com [216.82.249.51]) by kanga.kvack.org (Postfix) with ESMTP id 544C16B00A7 for ; Fri, 11 Dec 2009 01:35:18 -0500 (EST) Message-ID: <4B21E826.5060502@cs.helsinki.fi> Date: Fri, 11 Dec 2009 08:35:18 +0200 From: Pekka Enberg MIME-Version: 1.0 Subject: Re: [PATCH 1/2] tracing: Define kmem_trace_alloc_notrace unconditionally References: <4B21DD88.7080806@cn.fujitsu.com> <4B21DF33.7010906@cs.helsinki.fi> <4B21E028.3030107@cs.helsinki.fi> <4B21E29E.2030507@cn.fujitsu.com> In-Reply-To: <4B21E29E.2030507@cn.fujitsu.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org To: Li Zefan Cc: Ingo Molnar , Christoph Lameter , Steven Rostedt , Frederic Weisbecker , "linux-mm@kvack.org" , LKML , Eduard - Gabriel Munteanu List-ID: Li Zefan kirjoitti: > ao? 2009a1'12ae??11ae?JPY 14:01, Pekka Enberg a??e??: >> Pekka Enberg wrote: >>> Li Zefan wrote: >>>> Always define kmem_trace_alloc_{,node}_notrace(), otherwise >>>> perf-kmem will show wrong stats ifndef CONFIG_KMEMTRACE, >>>> because a kmalloc() memory allocation may be traced by >>>> both trace_kmalloc() and trace_kmem_cache_alloc(). >>>> >>>> Signed-off-by: Li Zefan >>> Did you check how much this will make kernel text bigger because of >>> the inlining happening in kmem_cache_alloc_notrace()? >> Maybe use CONFIG_TRACING instead of CONFIG_KMEMTRACE here like in the >> other patch? >> > > Wouldn't removing CONFIG_KMEMTRACE make the code cleaner? > Anyway, if CONFIG_TRACING is not enabled, all the trace_xxx() > will be turned into no-op. Again, I am talking about kernel text size increase in mm/slub.c. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org