From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with ESMTP id 5C4AA60021B for ; Tue, 8 Dec 2009 03:23:45 -0500 (EST) Message-Id: <4B1E1B1B0200007800024345@vpn.id2.novell.com> Date: Tue, 08 Dec 2009 08:23:39 +0000 From: "Jan Beulich" Subject: Re: [PATCH] mm/vmalloc: don't use vmalloc_end References: <4B1D3A3302000078000241CD@vpn.id2.novell.com> <20091207153552.0fadf335.akpm@linux-foundation.org> In-Reply-To: <20091207153552.0fadf335.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: owner-linux-mm@kvack.org To: Andrew Morton Cc: tony.luck@intel.com, tj@kernel.org, linux-mm@kvack.org, Geert Uytterhoeven , linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org List-ID: >>> Andrew Morton 08.12.09 00:35 >>> >(cc linux-ia64) > >On Mon, 07 Dec 2009 16:24:03 +0000 >"Jan Beulich" wrote: > >> At least on ia64 vmalloc_end is a global variable that VMALLOC_END >> expands to. Hence having a local variable named vmalloc_end and >> initialized from VMALLOC_END won't work on such platforms. Rename >> these variables, and for consistency also rename vmalloc_start. >>=20 > >erk. So does 2.6.32's vmalloc() actually work correctly on ia64? According to Tejun the problem is just cosmetic (i.e. causes build warnings), since the functions affected aren't being used (yet) on ia64. So feel free to drop the patch again, given that he has a patch queued to address the issue by renaming the arch variable. I wonder though why that code is being built on ia64 at all if it's not being used (i.e. why it doesn't depend on a CONFIG_*, HAVE_*, or NEED_* manifest constant). Jan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org