From: Rik van Riel <riel@redhat.com>
To: Larry Woodman <lwoodman@redhat.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org,
Hugh Dickins <hugh.dickins@tiscali.co.uk>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
Andrea Arcangeli <aarcange@redhat.com>
Subject: Re: [RFC] high system time & lock contention running large mixed workload
Date: Thu, 03 Dec 2009 19:29:33 -0500 [thread overview]
Message-ID: <4B1857ED.30304@redhat.com> (raw)
In-Reply-To: <1259878496.2345.57.camel@dhcp-100-19-198.bos.redhat.com>
On 12/03/2009 05:14 PM, Larry Woodman wrote:
> The attached patch addresses this issue by changing page_check_address()
> to return -1 if the spin_trylock() fails and page_referenced_one() to
> return 1 in that path so the page gets moved back to the active list.
Your patch forgot to add the code to vmscan.c to actually move
the page back to the active list.
Also, please use an enum for the page_referenced return
values, so the code in vmscan.c can use symbolic names.
enum page_reference {
NOT_REFERENCED,
REFERENCED,
LOCK_CONTENDED,
};
--
All rights reversed.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-12-04 0:29 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-25 18:37 [PATCH] vmscan: do not evict inactive pages when skipping an active list scan Rik van Riel
2009-11-25 20:35 ` Johannes Weiner
2009-11-25 20:47 ` Rik van Riel
2009-11-26 2:50 ` KOSAKI Motohiro
2009-11-26 2:57 ` Rik van Riel
2009-11-30 22:00 ` [RFC] high system time & lock contention running large mixed workload Larry Woodman
2009-12-01 10:04 ` Andrea Arcangeli
2009-12-01 12:31 ` KOSAKI Motohiro
2009-12-01 12:46 ` Andrea Arcangeli
2009-12-02 2:02 ` KOSAKI Motohiro
2009-12-02 2:04 ` Rik van Riel
2009-12-02 2:00 ` Rik van Riel
2009-12-01 12:23 ` KOSAKI Motohiro
2009-12-01 16:41 ` Larry Woodman
2009-12-02 2:20 ` Rik van Riel
2009-12-02 2:41 ` KOSAKI Motohiro
2009-12-03 22:14 ` Larry Woodman
2009-12-04 0:29 ` Rik van Riel [this message]
2009-12-04 21:26 ` Larry Woodman
2009-12-06 21:04 ` Rik van Riel
2009-12-04 0:36 ` KOSAKI Motohiro
2009-12-04 19:31 ` Larry Woodman
2009-12-02 2:55 ` [PATCH] Clear reference bit although page isn't mapped KOSAKI Motohiro
2009-12-02 3:07 ` Rik van Riel
2009-12-02 3:28 ` [PATCH] Replace page_mapping_inuse() with page_mapped() KOSAKI Motohiro
2009-12-02 4:57 ` Rik van Riel
2009-12-02 11:07 ` Johannes Weiner
2009-12-02 1:55 ` [RFC] high system time & lock contention running large mixed workload Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B1857ED.30304@redhat.com \
--to=riel@redhat.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hugh.dickins@tiscali.co.uk \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lwoodman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox